Processes::addProcess() - Code Metrics - Inspection of "Start to split up Run command." - jwage/phpchunkit - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 5ef5a6...726f17 )

by Jonathan

created 2016-10-30 05:27 UTC

Processes::addProcess() A

↳ Parent: Processes

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	4
ccs	0
cts	3
cp	0
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	1
crap	2

<?php

declare(strict_types = 1);

namespace PHPChunkit;

use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Process\Process;

class Processes
{
    /**
     * @var ChunkResults
     */
    private $chunkResults;

    /**
     * @var OutputInterface
     */
    private $output;

    /**
     * @var int
     */
    private $numProcesses;


    /**
     * @var bool
     */
    private $verbose;

    /**
     * @var bool
     */
    private $stop;

    /**
     * @var array
     */
    private $processes = [];

    public function __construct(
        ChunkResults $chunkResults,
        OutputInterface $output,
        int $numParallelProcesses = 1,
        bool $verbose = false,
        bool $stop = false)
    {
        $this->chunkResults = $chunkResults;
        $this->output = $output;
        $this->numParallelProcesses = $numParallelProcesses;

        $this->verbose = $verbose;
        $this->stop = $stop;
    }

    public function addProcess(Process $process)
    {
        $this->processes[] = $process;
    }

    public function wait()
    {
        if (count($this->processes) < $this->numParallelProcesses) {

            return;
        }

        while (count($this->processes)) {
            foreach ($this->processes as $i => $process) {
                $chunkNum = $i + 1;

                if ($process->isRunning()) {
                    continue;
                }

                unset($this->processes[$i]);

                $this->chunkResults->addCode($code = $process->getExitCode());

                if ($code > 0) {
                    $this->chunkResults->incrementNumChunkFailures();

                    $this->output->writeln(sprintf('Chunk #%s <error>FAILED</error>', $chunkNum));

                    $this->output->writeln('');
                    $this->output->write($process->getOutput());

                    if ($this->stop) {
                        return $code;
                    }
                } else {

                    $this->output->writeln(sprintf('Chunk #%s <info>PASSED</info>', $chunkNum));

                    if ($this->verbose) {
                        $this->output->writeln('');
                        $this->output->write($process->getOutput());
                    }
                }
            }
        }
    }
}


1			<?php
2
3			declare(strict_types = 1);
4
5			namespace PHPChunkit;
6
7			use Symfony\Component\Console\Output\OutputInterface;
8			use Symfony\Component\Process\Process;
9
10			class Processes
11			{
12			/**
13			* @var ChunkResults
14			*/
15			private $chunkResults;
16
17			/**
18			* @var OutputInterface
19			*/
20			private $output;
21
22			/**
23			* @var int
24			*/
25			private $numProcesses;
			0 ignored issues – show Unused Code introduced 2016-10-30 05:29 UTC by Report Bug Copy Issue Report The property `$numProcesses` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
26
27			/**
28			* @var bool
29			*/
30			private $verbose;
31
32			/**
33			* @var bool
34			*/
35			private $stop;
36
37			/**
38			* @var array
39			*/
40			private $processes = [];
41
42	1		public function __construct(
43			ChunkResults $chunkResults,
44			OutputInterface $output,
45			int $numParallelProcesses = 1,
46			bool $verbose = false,
47			bool $stop = false)
48			{
49	1		$this->chunkResults = $chunkResults;
50	1		$this->output = $output;
51	1		$this->numParallelProcesses = $numParallelProcesses;
			0 ignored issues – show Bug introduced 2016-10-30 05:29 UTC by Report Bug Copy Issue Report The property `numParallelProcesses` does not seem to exist. Did you mean `processes`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
52	1		$this->verbose = $verbose;
53	1		$this->stop = $stop;
54	1		}
55
56			public function addProcess(Process $process)
57			{
58			$this->processes[] = $process;
59			}
60
61			public function wait()
62			{
63			if (count($this->processes) < $this->numParallelProcesses) {
			0 ignored issues – show Bug introduced 2016-10-30 05:29 UTC by Report Bug Copy Issue Report The property `numParallelProcesses` does not seem to exist. Did you mean `processes`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
64			return;
65			}
66
67			while (count($this->processes)) {
68			foreach ($this->processes as $i => $process) {
69			$chunkNum = $i + 1;
70
71			if ($process->isRunning()) {
72			continue;
73			}
74
75			unset($this->processes[$i]);
76
77			$this->chunkResults->addCode($code = $process->getExitCode());
78
79			if ($code > 0) {
80			$this->chunkResults->incrementNumChunkFailures();
81
82			$this->output->writeln(sprintf('Chunk #%s <error>FAILED</error>', $chunkNum));
83
84			$this->output->writeln('');
85			$this->output->write($process->getOutput());
86
87			if ($this->stop) {
88			return $code;
89			}
90		View Code Duplication	} else {
			1 ignored issue – show Duplication introduced 2016-10-30 05:29 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
91			$this->output->writeln(sprintf('Chunk #%s <info>PASSED</info>', $chunkNum));
92
93			if ($this->verbose) {
94			$this->output->writeln('');
95			$this->output->write($process->getOutput());
96			}
97			}
98			}
99			}
100			}
101			}
102

jwage / phpchunkit

Push — master ( 5ef5a6...726f17 )

Processes::addProcess() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like