Issues in SocketClient.php (master) - Issues in master - jwage/php-apns - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/JWage/APNS/SocketClient.php (1 issue)

Labels

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace JWage\APNS;

use ErrorException;

class SocketClient
{
    const PAYLOAD_MAX_BYTES = 256;

    /**
     * @var \JWage\APNS\Certificate
     */
    private $certificate;

    /**
     * @var string
     */
    private $host;

    /**
     * @var int
     */
    private $port;

    /**
     * @var Resource
     */
    private $apnsResource;

    /**
     * @var integer
     */
    private $error;

    /**
     * @var string
     */
    private $errorString;

    /**
     * Construct.
     *
     * @param \JWage\APNS\Certificate $certificate
     * @param string $host
     * @param string $port
     */
    public function __construct(Certificate $certificate, $host, $port)
    {
        $this->certificate = $certificate;
        $this->host = $host;
        $this->port = $port;
$answer = 42;

$correct = false;

$correct = (bool) $answer;
    }

    public function __destruct()
    {
        if (is_resource($this->apnsResource)) {
            fclose($this->apnsResource);
        }
    }

    /**
     * Writes a binary message to apns.
     *
     * @param string $binaryMessage
     * @return integer Returns the number of bytes written, or FALSE on error.
     */
    public function write($binaryMessage)
    {
        if (strlen($binaryMessage) > self::PAYLOAD_MAX_BYTES) {
            throw new \InvalidArgumentException(
                sprintf('The maximum size allowed for a notification payload is %s bytes; Apple Push Notification Service refuses any notification that exceeds this limit.', self::PAYLOAD_MAX_BYTES)
            );
        }

        return fwrite($this->getApnsResource(), $binaryMessage);
    }

    /**
     * @return Resource
     */
    protected function getApnsResource()
    {
        if (!is_resource($this->apnsResource)) {
            $this->apnsResource = $this->createStreamClient();
        }

        return $this->apnsResource;
    }

    /**
     * @return Resource
     */
    protected function createStreamContext()
    {
        $streamContext = stream_context_create();
        stream_context_set_option($streamContext, 'ssl', 'local_cert', $this->certificate->writeToTmp());

        return $streamContext;
    }

    /**
     * @return Resource
     */
    protected function createStreamClient()
    {
        $address = $this->getSocketAddress();

        $client = @stream_socket_client(
            $address,
            $this->error,
            $this->errorString,
            2,
            STREAM_CLIENT_CONNECT,
            $this->createStreamContext()
        );

        if (!$client) {
            throw new ErrorException(
                sprintf('Failed to create stream socket client to "%s". %s', $address, $this->errorString), $this->error
            );
        }

        return $client;
    }

    /**
     * @return string $socketAddress
     */
    protected function getSocketAddress()
    {
        return sprintf('ssl://%s:%s', $this->host, $this->port);
    }
}


1			<?php
2
3			namespace JWage\APNS;
4
5			use ErrorException;
6
7			class SocketClient
8			{
9			const PAYLOAD_MAX_BYTES = 256;
10
11			/**
12			* @var \JWage\APNS\Certificate
13			*/
14			private $certificate;
15
16			/**
17			* @var string
18			*/
19			private $host;
20
21			/**
22			* @var int
23			*/
24			private $port;
25
26			/**
27			* @var Resource
28			*/
29			private $apnsResource;
30
31			/**
32			* @var integer
33			*/
34			private $error;
35
36			/**
37			* @var string
38			*/
39			private $errorString;
40
41			/**
42			* Construct.
43			*
44			* @param \JWage\APNS\Certificate $certificate
45			* @param string $host
46			* @param string $port
47			*/
48			public function __construct(Certificate $certificate, $host, $port)
49			{
50			$this->certificate = $certificate;
51			$this->host = $host;
52			$this->port = $port;
			0 ignored issues – show Documentation Bug introduced 2016-02-13 10:23 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$port` was declared of type `integer`, but `$port` is of type `string`. Maybe add a type cast? This check looks for assignments to scalar types that may be of the wrong type. To ensure the code behaves as expected, it may be a good idea to add an explicit type cast. $answer = 42; $correct = false; $correct = (bool) $answer; Loading history...
53			}
54
55			public function __destruct()
56			{
57			if (is_resource($this->apnsResource)) {
58			fclose($this->apnsResource);
59			}
60			}
61
62			/**
63			* Writes a binary message to apns.
64			*
65			* @param string $binaryMessage
66			* @return integer Returns the number of bytes written, or FALSE on error.
67			*/
68			public function write($binaryMessage)
69			{
70			if (strlen($binaryMessage) > self::PAYLOAD_MAX_BYTES) {
71			throw new \InvalidArgumentException(
72			sprintf('The maximum size allowed for a notification payload is %s bytes; Apple Push Notification Service refuses any notification that exceeds this limit.', self::PAYLOAD_MAX_BYTES)
73			);
74			}
75
76			return fwrite($this->getApnsResource(), $binaryMessage);
77			}
78
79			/**
80			* @return Resource
81			*/
82			protected function getApnsResource()
83			{
84			if (!is_resource($this->apnsResource)) {
85			$this->apnsResource = $this->createStreamClient();
86			}
87
88			return $this->apnsResource;
89			}
90
91			/**
92			* @return Resource
93			*/
94			protected function createStreamContext()
95			{
96			$streamContext = stream_context_create();
97			stream_context_set_option($streamContext, 'ssl', 'local_cert', $this->certificate->writeToTmp());
98
99			return $streamContext;
100			}
101
102			/**
103			* @return Resource
104			*/
105			protected function createStreamClient()
106			{
107			$address = $this->getSocketAddress();
108
109			$client = @stream_socket_client(
110			$address,
111			$this->error,
112			$this->errorString,
113			2,
114			STREAM_CLIENT_CONNECT,
115			$this->createStreamContext()
116			);
117
118			if (!$client) {
119			throw new ErrorException(
120			sprintf('Failed to create stream socket client to "%s". %s', $address, $this->errorString), $this->error
121			);
122			}
123
124			return $client;
125			}
126
127			/**
128			* @return string $socketAddress
129			*/
130			protected function getSocketAddress()
131			{
132			return sprintf('ssl://%s:%s', $this->host, $this->port);
133			}
134			}
135

jwage / php-apns

Issues (1)

Security Analysis no request data

src/JWage/APNS/SocketClient.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like