ChangelogGeneratorTest::testGenerate() - Code Metrics - Inspection of "Merge pull request #1 from jwage/test-coverage" - jwage/changelog-generator - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( aaccd5...c6e65b )

by Jonathan

created 2018-05-19 16:16 UTC

ChangelogGeneratorTest::testGenerate() A

↳ Parent: ChangelogGeneratorTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	57
Code Lines	41

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	41
nc	1
nop	0
dl	0
loc	57
rs	9.6818
c	0
b	0
f	0

How to fix Long Method

<?php

declare(strict_types=1);

namespace ChangelogGenerator\Tests;

use ChangelogGenerator\ChangelogGenerator;
use ChangelogGenerator\Issue;
use ChangelogGenerator\IssueGroup;
use ChangelogGenerator\IssueGrouper;
use ChangelogGenerator\IssueRepository;
use PHPUnit\Framework\TestCase;
use Symfony\Component\Console\Output\OutputInterface;

final class ChangelogGeneratorTest extends TestCase
{
    /** @var \PHPUnit_Framework_MockObject_MockObject|IssueRepository */
    private $issueRepository;

    /** @var \PHPUnit_Framework_MockObject_MockObject|IssueGrouper */
    private $issueGrouper;

    /** @var ChangelogGenerator */
    private $changelogGenerator;

    public function testGenerate() : void
    {
        $user       = 'jwage';
        $repository = 'changelog-generator';
        $milestone  = '1.0';

        $output = $this->createMock(OutputInterface::class);

        $issue      = $this->createMock(Issue::class);
        $issueGroup = $this->createMock(IssueGroup::class);

        $milestoneIssues = [$issue];
        $issueGroups     = [$issueGroup];

        $this->issueRepository->expects($this->once())
            ->method('getMilestoneIssues')
            ->with($user, $repository, $milestone)
            ->willReturn($milestoneIssues);

        $this->issueGrouper->expects($this->once())
            ->method('groupIssues')
            ->with($milestoneIssues)
            ->willReturn($issueGroups);

        $issueGroup->expects($this->once())
            ->method('getName')
            ->willReturn('Enhancement');

        $issueGroup->expects($this->once())
            ->method('getIssues')
            ->willReturn([$issue]);

        $issue->expects($this->once())
            ->method('render')
            ->willReturn('Issue #1');

        $output->expects($this->at(0))
            ->method('writeln')
            ->with([
                '## 1.0',
                '',
                'Total issues resolved: **1**',
            ]);

        $output->expects($this->at(1))
            ->method('writeln')
            ->with([
                '',
                '### Enhancement',
                '',
            ]);

        $output->expects($this->at(2))
            ->method('writeln')
            ->with('Issue #1');

        $this->changelogGenerator->generate($user, $repository, $milestone, $output);
    }

    protected function setUp() : void
    {
        $this->issueRepository = $this->createMock(IssueRepository::class);
        $this->issueGrouper    = $this->createMock(IssueGrouper::class);

        $this->changelogGenerator = new ChangelogGenerator(
            $this->issueRepository,
            $this->issueGrouper
        );
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace ChangelogGenerator\Tests;
6
7			use ChangelogGenerator\ChangelogGenerator;
8			use ChangelogGenerator\Issue;
9			use ChangelogGenerator\IssueGroup;
10			use ChangelogGenerator\IssueGrouper;
11			use ChangelogGenerator\IssueRepository;
12			use PHPUnit\Framework\TestCase;
13			use Symfony\Component\Console\Output\OutputInterface;
14
15			final class ChangelogGeneratorTest extends TestCase
16			{
17			/** @var \PHPUnit_Framework_MockObject_MockObject\|IssueRepository */
18			private $issueRepository;
19
20			/** @var \PHPUnit_Framework_MockObject_MockObject\|IssueGrouper */
21			private $issueGrouper;
22
23			/** @var ChangelogGenerator */
24			private $changelogGenerator;
25
26			public function testGenerate() : void
27			{
28			$user = 'jwage';
29			$repository = 'changelog-generator';
30			$milestone = '1.0';
31
32			$output = $this->createMock(OutputInterface::class);
33
34			$issue = $this->createMock(Issue::class);
35			$issueGroup = $this->createMock(IssueGroup::class);
36
37			$milestoneIssues = [$issue];
38			$issueGroups = [$issueGroup];
39
40			$this->issueRepository->expects($this->once())
41			->method('getMilestoneIssues')
42			->with($user, $repository, $milestone)
43			->willReturn($milestoneIssues);
44
45			$this->issueGrouper->expects($this->once())
46			->method('groupIssues')
47			->with($milestoneIssues)
48			->willReturn($issueGroups);
49
50			$issueGroup->expects($this->once())
51			->method('getName')
52			->willReturn('Enhancement');
53
54			$issueGroup->expects($this->once())
55			->method('getIssues')
56			->willReturn([$issue]);
57
58			$issue->expects($this->once())
59			->method('render')
60			->willReturn('Issue #1');
61
62			$output->expects($this->at(0))
63			->method('writeln')
64			->with([
65			'## 1.0',
66			'',
67			'Total issues resolved: 1',
68			]);
69
70			$output->expects($this->at(1))
71			->method('writeln')
72			->with([
73			'',
74			'### Enhancement',
75			'',
76			]);
77
78			$output->expects($this->at(2))
79			->method('writeln')
80			->with('Issue #1');
81
82			$this->changelogGenerator->generate($user, $repository, $milestone, $output);
83			}
84
85			protected function setUp() : void
86			{
87			$this->issueRepository = $this->createMock(IssueRepository::class);
88			$this->issueGrouper = $this->createMock(IssueGrouper::class);
89
90			$this->changelogGenerator = new ChangelogGenerator(
91			$this->issueRepository,
92			$this->issueGrouper
93			);
94			}
95			}
96

jwage / changelog-generator

Push — master ( aaccd5...c6e65b )

ChangelogGeneratorTest::testGenerate() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like