IssueRepository::getMilestoneIssues() - Code Metrics - Inspection of "Merge pull request #1 from jwage/test-coverage" - jwage/changelog-generator - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( aaccd5...c6e65b )

by Jonathan

created 2018-05-19 16:16 UTC

IssueRepository::getMilestoneIssues() A

↳ Parent: IssueRepository

Complexity

Conditions	2
Paths	2

Size

Total Lines	17
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	11
CRAP Score	2

Importance

Changes

Metric	Value
cc	2
eloc	10
nc	2
nop	3
dl	0
loc	17
rs	9.4285
c	0
b	0
f	0
ccs	11
cts	11
cp	1
crap	2

<?php

declare(strict_types=1);

namespace ChangelogGenerator;

use const ENT_COMPAT;
use function array_column;
use function htmlentities;
use function sort;
use function str_replace;

class IssueRepository
{
    /** @var IssueFetcher */
    private $issueFetcher;

    /** @var IssueFactory */
    private $issueFactory;

    public function __construct(IssueFetcher $issueFetcher, IssueFactory $issueFactory)
    {
        $this->issueFetcher = $issueFetcher;
        $this->issueFactory = $issueFactory;
    }

    /**
     * @return Issue[]
     */
    public function getMilestoneIssues(string $user, string $repository, string $milestone) : array
    {
        $issuesData = $this->issueFetcher->fetchMilestoneIssues($user, $repository, $milestone);

        $issues = [];

        foreach ($issuesData as $issue) {
            $issues[$issue['number']] = $this->issueFactory->create(
                $issue['number'],
                $this->getTitle($issue['title']),
                $issue['html_url'],
                $issue['user']['login'],
                $this->getLabels($issue['labels'])
            );
        }

        return $issues;
    }

    private function getTitle(string $title) : string
    {
        $title = htmlentities($title, ENT_COMPAT, 'UTF-8');
        $title = str_replace(['[', ']', '_'], ['&#91;', '&#92;', '&#95;'], $title);

        return $title;
    }

    /**
     * @param string[] $labels
     *
     * @return string[]
     */
    private function getLabels(array $labels) : array
    {
        $labels = array_column($labels, 'name');

        sort($labels);

        return $labels;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace ChangelogGenerator;
6
7		use const ENT_COMPAT;
8		use function array_column;
9		use function htmlentities;
10		use function sort;
11		use function str_replace;
12
13		class IssueRepository
14		{
15		/** @var IssueFetcher */
16		private $issueFetcher;
17
18		/** @var IssueFactory */
19		private $issueFactory;
20
21	1	public function __construct(IssueFetcher $issueFetcher, IssueFactory $issueFactory)
22		{
23	1	$this->issueFetcher = $issueFetcher;
24	1	$this->issueFactory = $issueFactory;
25	1	}
26
27		/**
28		* @return Issue[]
29		*/
30	1	public function getMilestoneIssues(string $user, string $repository, string $milestone) : array
31		{
32	1	$issuesData = $this->issueFetcher->fetchMilestoneIssues($user, $repository, $milestone);
33
34	1	$issues = [];
35
36	1	foreach ($issuesData as $issue) {
37	1	$issues[$issue['number']] = $this->issueFactory->create(
38	1	$issue['number'],
39	1	$this->getTitle($issue['title']),
40	1	$issue['html_url'],
41	1	$issue['user']['login'],
42	1	$this->getLabels($issue['labels'])
43		);
44		}
45
46	1	return $issues;
47		}
48
49	1	private function getTitle(string $title) : string
50		{
51	1	$title = htmlentities($title, ENT_COMPAT, 'UTF-8');
52	1	$title = str_replace(['[', ']', '_'], ['[', '\', '_'], $title);
53
54	1	return $title;
55		}
56
57		/**
58		* @param string[] $labels
59		*
60		* @return string[]
61		*/
62	1	private function getLabels(array $labels) : array
63		{
64	1	$labels = array_column($labels, 'name');
65
66	1	sort($labels);
67
68	1	return $labels;
69		}
70		}
71

jwage / changelog-generator

Push — master ( aaccd5...c6e65b )

IssueRepository::getMilestoneIssues() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like