IssueClient::execute() - Code Metrics - Inspection of "Add test coverage for all classes." - jwage/changelog-generator - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#1)

by Jonathan

created 2018-05-19 16:10 UTC

IssueClient::execute() A

↳ Parent: IssueClient

Complexity

Conditions	1
Paths	1

Size

Total Lines	9
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	1

Importance

Changes

Metric	Value
cc	1
eloc	4
nc	1
nop	1
dl	0
loc	9
rs	9.6666
c	0
b	0
f	0
ccs	5
cts	5
cp	1
crap	1

<?php

declare(strict_types=1);

namespace ChangelogGenerator;

use GuzzleHttp\Client;
use GuzzleHttp\Psr7\Response;
use function json_decode;
use function preg_match;

class IssueClient
{
    /** @var Client */
    private $client;

    public function __construct(Client $client)
    {
        $this->client = $client;
    }

    public function execute(string $url) : IssueClientResponse
    {
        $response = $this->client->request('GET', $url);

        $body = (string) $response->getBody();

        $body = json_decode($body, true);

        return new IssueClientResponse($body, $this->getNextUrl($response));
    }

    private function getNextUrl(Response $response) : ?string
    {
        $links = $response->getHeader('Link');

        foreach ($links as $link) {
            $matches = [];

            if (preg_match('#<(?P<url>.*)>; rel="next"#', $link, $matches)) {
                return $matches['url'];
            }
        }

        return null;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace ChangelogGenerator;
6
7		use GuzzleHttp\Client;
8		use GuzzleHttp\Psr7\Response;
9		use function json_decode;
10		use function preg_match;
11
12		class IssueClient
13		{
14		/** @var Client */
15		private $client;
16
17	2	public function __construct(Client $client)
18		{
19	2	$this->client = $client;
20	2	}
21
22	2	public function execute(string $url) : IssueClientResponse
23		{
24	2	$response = $this->client->request('GET', $url);
25
26	2	$body = (string) $response->getBody();
27
28	2	$body = json_decode($body, true);
29
30	2	return new IssueClientResponse($body, $this->getNextUrl($response));
31		}
32
33	2	private function getNextUrl(Response $response) : ?string
34		{
35	2	$links = $response->getHeader('Link');
36
37	2	foreach ($links as $link) {
38	1	$matches = [];
39
40	1	if (preg_match('#<(?P<url>.*)>; rel="next"#', $link, $matches)) {
41	1	return $matches['url'];
42		}
43		}
44
45	1	return null;
46		}
47		}
48

jwage / changelog-generator

Pull Request — master (#1)

IssueClient::execute() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like