ChangelogConfig::getMilestoneIssuesUrl() - Code Metrics - Inspection of "Allow changelog to be filtered by label names." - jwage/changelog-generator - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#12)

by Jonathan

created 2018-05-19 20:16 UTC

ChangelogConfig::getMilestoneIssuesUrl() A

↳ Parent: ChangelogConfig

Complexity

Conditions	2
Paths	1

Size

Total Lines	11
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	2

Importance

Changes

Metric	Value
cc	2
eloc	7
nc	1
nop	1
dl	0
loc	11
rs	9.4285
c	0
b	0
f	0
ccs	8
cts	8
cp	1
crap	2

<?php

declare(strict_types=1);

namespace ChangelogGenerator;

use function sprintf;
use function str_replace;
use function urlencode;

class ChangelogConfig
{
    private const ROOT_URL = 'https://api.github.com';

    /** @var string */
    private $user;

    /** @var string */
    private $repository;

    /** @var string */
    private $milestone;

    /** @var string[] */
    private $labels;

    /**
     * @param string[] $labels
     */
    public function __construct(
        string $user,
        string $repository,
        string $milestone,
        array $labels
    ) {
        $this->user       = $user;
        $this->repository = $repository;
        $this->milestone  = $milestone;
        $this->labels     = $labels;
    }

    public function getUser() : string
    {
        return $this->user;
    }

    public function getRepository() : string
    {
        return $this->repository;
    }

    public function getMilestone() : string
    {
        return $this->milestone;
    }

    /**
     * @return string[]
     */
    public function getLabels() : array
    {
        return $this->labels;
    }

    public function getMilestoneIssuesUrl(string $label) : string
    {
        $query = urlencode(sprintf(
            'milestone:"%s" repo:%s/%s state:closed%s',
            str_replace('"', '\"', $this->milestone),
            $this->user,
            $this->repository,
            $label !== '' ? ' label:' . $label : ''
        ));

        return sprintf('%s/search/issues?q=%s', self::ROOT_URL, $query);
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace ChangelogGenerator;
6
7		use function sprintf;
8		use function str_replace;
9		use function urlencode;
10
11		class ChangelogConfig
12		{
13		private const ROOT_URL = 'https://api.github.com';
14
15		/** @var string */
16		private $user;
17
18		/** @var string */
19		private $repository;
20
21		/** @var string */
22		private $milestone;
23
24		/** @var string[] */
25		private $labels;
26
27		/**
28		* @param string[] $labels
29		*/
30	14	public function __construct(
31		string $user,
32		string $repository,
33		string $milestone,
34		array $labels
35		) {
36	14	$this->user = $user;
37	14	$this->repository = $repository;
38	14	$this->milestone = $milestone;
39	14	$this->labels = $labels;
40	14	}
41
42	1	public function getUser() : string
43		{
44	1	return $this->user;
45		}
46
47	1	public function getRepository() : string
48		{
49	1	return $this->repository;
50		}
51
52	2	public function getMilestone() : string
53		{
54	2	return $this->milestone;
55		}
56
57		/**
58		* @return string[]
59		*/
60	2	public function getLabels() : array
61		{
62	2	return $this->labels;
63		}
64
65	3	public function getMilestoneIssuesUrl(string $label) : string
66		{
67	3	$query = urlencode(sprintf(
68	3	'milestone:"%s" repo:%s/%s state:closed%s',
69	3	str_replace('"', '\"', $this->milestone),
70	3	$this->user,
71	3	$this->repository,
72	3	$label !== '' ? ' label:' . $label : ''
73		));
74
75	3	return sprintf('%s/search/issues?q=%s', self::ROOT_URL, $query);
76		}
77		}
78

jwage / changelog-generator

Pull Request — master (#12)

ChangelogConfig::getMilestoneIssuesUrl() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like