Conditions | 2 |
Total Lines | 58 |
Lines | 0 |
Ratio | 0 % |
Changes | 1 | ||
Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | from json import loads |
||
86 | def setUp(self): |
||
87 | self.testdate = datetime(2000, 1, 1) |
||
88 | self.timesince = timesince(self.testdate).encode('utf8').replace( |
||
89 | b'\xc2\xa0', b' ').decode() |
||
90 | self.group_ct = ContentType.objects.get_for_model(Group) |
||
91 | super(DataTestCase, self).setUp() |
||
92 | self.group = Group.objects.create(name='CoolGroup') |
||
93 | self.another_group = Group.objects.create(name='NiceGroup') |
||
94 | if 'email' in getargspec(self.User.objects.create_superuser).args: |
||
95 | self.user1 = self.User.objects.create_superuser('admin', '[email protected]', 'admin') |
||
96 | self.user2 = self.User.objects.create_user('Two', '[email protected]') |
||
97 | self.user3 = self.User.objects.create_user('Three', '[email protected]') |
||
98 | self.user4 = self.User.objects.create_user('Four', '[email protected]') |
||
99 | else: |
||
100 | self.user1 = self.User.objects.create_superuser('admin', 'admin') |
||
101 | self.user2 = self.User.objects.create_user('Two') |
||
102 | self.user3 = self.User.objects.create_user('Three') |
||
103 | self.user4 = self.User.objects.create_user('Four') |
||
104 | # User1 joins group |
||
105 | self.user1.groups.add(self.group) |
||
106 | self.join_action = action.send(self.user1, verb='joined', |
||
107 | target=self.group, |
||
108 | timestamp=self.testdate)[0][1] |
||
109 | |||
110 | # User1 follows User2 |
||
111 | follow(self.user1, self.user2, timestamp=self.testdate) |
||
112 | |||
113 | # User2 joins group |
||
114 | self.user2.groups.add(self.group) |
||
115 | action.send(self.user2, verb='joined', target=self.group, |
||
116 | timestamp=self.testdate) |
||
117 | |||
118 | # User2 follows group |
||
119 | follow(self.user2, self.group, timestamp=self.testdate) |
||
120 | |||
121 | # User1 comments on group |
||
122 | # Use a site object here and predict the "__unicode__ method output" |
||
123 | action.send(self.user1, verb='commented on', target=self.group, |
||
124 | timestamp=self.testdate) |
||
125 | |||
126 | self.comment = Site.objects.create( |
||
127 | domain="admin: Sweet Group!...") |
||
128 | |||
129 | # Group responds to comment |
||
130 | action.send(self.group, verb='responded to', target=self.comment, |
||
131 | timestamp=self.testdate) |
||
132 | |||
133 | # User 3 did something but doesn't following someone |
||
134 | action.send(self.user3, verb='liked actstream', timestamp=self.testdate) |
||
135 | |||
136 | # User4 likes group |
||
137 | follow(self.user4, self.another_group, timestamp=self.testdate, flag='liking') |
||
138 | # User4 watches group |
||
139 | follow(self.user4, self.another_group, timestamp=self.testdate, flag='watching') |
||
140 | # User4 likes User1 |
||
141 | follow(self.user4, self.user1, timestamp=self.testdate, flag='liking') |
||
142 | # User4 blacklist user3 |
||
143 | follow(self.user4, self.user3, timestamp=self.testdate, flag='blacklisting') |
||
144 |