Issues in test2.php (master) - Issues in master - jupitern/table - Measure and Improve Code Quality continuously with Scrutinizer

Issues (5)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Examples/test2.php (3 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

require '../../vendor/autoload.php';

// grab data from db with PDO or in alternative from your framework ORM
$db = new PDO('mysql:host=HOST_NAME;dbname=DB_NAME;charset=utf8', 'DB_USERNAME', 'DB_PASSWORD',
	array(PDO::ATTR_EMULATE_PREPARES => false, PDO::ATTR_ERRMODE => PDO::ERRMODE_EXCEPTION)
);
// data to populate table
$data = $db->query("SELECT id, name, age, phone FROM persons")->fetchAll(PDO::FETCH_OBJ);
// used for column filter
$filterData = $db->query("SELECT name as val, name FROM persons limit 10")->fetchAll(PDO::FETCH_OBJ);

\Jupitern\Table\Table::instance()
class User
{
    private $email;

    public function getEmail()
    {
        return $this->email;
    }

    public function setEmail($email)
    {
        $this->email = $email;
    }
}
	->setData($data)
	->attr('table', 'id', 'demoTable')
	->attr('table', 'class', 'table table-bordered table-striped table-hover')
	->attr('table', 'cellspacing', '0')
	->attr('table', 'width', '100%')
	->column()
		->title('Name')
		->value(function ($row) {

			return rand(1,10)%2 ? '<b>'.$row['name'].'</b>' : $row['name'];
		})
		->filter($filterData)
		->css('td', 'color', 'green')
		->css('td', 'width', '50%')
		->css('td', 'background-color', '#ccc')
	->add()
	->column()
		->title('Age')
		->value('age')
		->filter()
		->css('td', 'color', 'red')
		->css('td', 'width', '20%')
	->add()
	->column('Phone')

		->filter()
		->value('phone')
		->css('td', 'color', 'red')
		->css('td', 'width', '20%')
	->add()
	->column()
		->value(function ($row) {
			return '<a href="country/'. $row['id'] .'">edit</a>';
		})
		->css('td', 'width', '10%')
	->add()
?>

<html>
<head>
	<!-- JQUERY -->
	<script src="https://code.jquery.com/jquery-3.1.1.min.js"></script>

	<!-- DATATABLES -->
	<link href="https://cdn.datatables.net/1.10.12/css/jquery.dataTables.min.css" rel="stylesheet">
	<script src="https://cdn.datatables.net/1.10.12/js/jquery.dataTables.min.js"></script>

	<!-- Bootstrap and Datatables Bootstrap theme (OPTIONAL) -->
	<link href="https://maxcdn.bootstrapcdn.com/bootstrap/3.3.7/css/bootstrap.min.css" rel="stylesheet">
	<link href="https://cdn.datatables.net/1.10.12/css/dataTables.bootstrap.min.css" rel="stylesheet">
	<script src="https://maxcdn.bootstrapcdn.com/bootstrap/3.3.7/js/bootstrap.min.js"></script>

	<script type="text/javascript">

		$(document).ready(function(){
			$('#demoTable').DataTable();
		});

	</script>
</head>
<body>
<div style="width: 50%; margin: 30px;">
	<?php $table->render(); ?>
</div>
</body>
</html>

1		<?php
2
3		require '../../vendor/autoload.php';
4
5		// grab data from db with PDO or in alternative from your framework ORM
6		$db = new PDO('mysql:host=HOST_NAME;dbname=DB_NAME;charset=utf8', 'DB_USERNAME', 'DB_PASSWORD',
7		array(PDO::ATTR_EMULATE_PREPARES => false, PDO::ATTR_ERRMODE => PDO::ERRMODE_EXCEPTION)
8		);
9		// data to populate table
10		$data = $db->query("SELECT id, name, age, phone FROM persons")->fetchAll(PDO::FETCH_OBJ);
11		// used for column filter
12		$filterData = $db->query("SELECT name as val, name FROM persons limit 10")->fetchAll(PDO::FETCH_OBJ);
13
14		\Jupitern\Table\Table::instance()
		0 ignored issues – show Unused Code introduced 2016-11-21 15:36 UTC by Report Bug Copy Issue Report Show Similar Issues like this The call to the method `Jupitern\Table\TableColumn::add()` seems un-needed as the method has no side-effects. PHP Analyzer performs a side-effects analysis of your code. A side-effect is basically anything that might be visible after the scope of the method is left. Let’s take a look at an example: class User { private $email; public function getEmail() { return $this->email; } public function setEmail($email) { $this->email = $email; } } If we look at the `getEmail()` method, we can see that it has no side-effect. Whether you call this method or not, no future calls to other methods are affected by this. As such code as the following is useless: $user = new User(); $user->getEmail(); // This line could safely be removed as it has no effect. On the hand, if we look at the `setEmail()`, this method _has_ side-effects. In the following case, we could not remove the method call: $user = new User(); $user->setEmail('email@domain'); // This line has a side-effect (it changes an // instance variable). Loading history...
15		->setData($data)
16		->attr('table', 'id', 'demoTable')
17		->attr('table', 'class', 'table table-bordered table-striped table-hover')
18		->attr('table', 'cellspacing', '0')
19		->attr('table', 'width', '100%')
20		->column()
21		->title('Name')
22	View Code Duplication	->value(function ($row) {
		0 ignored issues – show Duplication introduced 2016-11-21 15:36 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
23		return rand(1,10)%2 ? '<b>'.$row['name'].'</b>' : $row['name'];
24		})
25		->filter($filterData)
26		->css('td', 'color', 'green')
27		->css('td', 'width', '50%')
28		->css('td', 'background-color', '#ccc')
29		->add()
30		->column()
31		->title('Age')
32		->value('age')
33		->filter()
34		->css('td', 'color', 'red')
35		->css('td', 'width', '20%')
36		->add()
37		->column('Phone')
		0 ignored issues – show Unused Code introduced 2016-11-21 15:36 UTC by Report Bug Copy Issue Report Show Similar Issues like this The call to `Table::column()` has too many arguments starting with `'Phone'`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
38		->filter()
39		->value('phone')
40		->css('td', 'color', 'red')
41		->css('td', 'width', '20%')
42		->add()
43		->column()
44		->value(function ($row) {
45		return '<a href="country/'. $row['id'] .'">edit</a>';
46		})
47		->css('td', 'width', '10%')
48		->add()
49		?>
50
51		<html>
52		<head>
53		<!-- JQUERY -->
54		<script src="https://code.jquery.com/jquery-3.1.1.min.js"></script>
55
56		<!-- DATATABLES -->
57		<link href="https://cdn.datatables.net/1.10.12/css/jquery.dataTables.min.css" rel="stylesheet">
58		<script src="https://cdn.datatables.net/1.10.12/js/jquery.dataTables.min.js"></script>
59
60		<!-- Bootstrap and Datatables Bootstrap theme (OPTIONAL) -->
61		<link href="https://maxcdn.bootstrapcdn.com/bootstrap/3.3.7/css/bootstrap.min.css" rel="stylesheet">
62		<link href="https://cdn.datatables.net/1.10.12/css/dataTables.bootstrap.min.css" rel="stylesheet">
63		<script src="https://maxcdn.bootstrapcdn.com/bootstrap/3.3.7/js/bootstrap.min.js"></script>
64
65		<script type="text/javascript">
66
67		$(document).ready(function(){
68		$('#demoTable').DataTable();
69		});
70
71		</script>
72		</head>
73		<body>
74		<div style="width: 50%; margin: 30px;">
75		<?php $table->render(); ?>
76		</div>
77		</body>
78		</html>

jupitern / table

Issues (5)

Security Analysis no request data

src/Examples/test2.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like