Crawler::hasError() - Code Metrics - juniorb2ss/zServices - Measure and Improve Code Quality continuously with Scrutinizer

Crawler::hasError() A
last analyzed 2017-08-07 13:13 UTC

↳ Parent: Crawler

Complexity

Conditions	2
Paths	2

Size

Total Lines	9
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	4
nc	2
nop	0
dl	0
loc	9
rs	9.6666
c	0
b	0
f	0

<?php namespace zServices\Sintegra\Services\Portais\SP;

use zServices\Miscellany\Interfaces\CrawlerInterface;
use Symfony\Component\DomCrawler\Crawler as BaseCrawler;
use zServices\Miscellany\Exceptions\ErrorFoundData;

/**
* 
*/
class Crawler extends BaseCrawler implements CrawlerInterface
{

	/**
	 * Selectors to crawler
	 * @var array
	 */
	private $selectors = [];

	/**
	 * Get selectors and initialize crawler in HTML
	 * @param string $html      
	 * @param array  $selectors
	 * @return void

	 */
	public function __construct($html, $selectors)
	{
		$this->selectors = $selectors;

		parent::__construct($html);
	}

	/**
	 * Verifica antes de fazer o crawler se possui erros
	 * na requisição
	 * @return boolean|null 
	 */
	public function hasError()
	{
		$node = $this->scrap($this->selectors['razao_social']);

		if (!$node->count())
		{
			throw new ErrorFoundData($this->clearString($this->scrap($this->selectors['error'])->text()), 1);
		}
	}

	/**
	 * Extrai informações do HTML através do DOM
	 *
	 * @return array
	 */
	public function scraping()

	{
		$scrapped = [];

		$this->hasError();

		foreach ($this->selectors as $name => $selector) {
			if (is_string($selector)) {
				$node = $this->scrap($selector);

				if ($node->count()) {
					$scrapped[$name] = $this->clearString($node->text());
				}
			} elseif (is_array($selector)) {
				foreach ($selector as $selector => $repeat) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
					$node = $this->scrap($selector);
					if ($node->count()) {
						foreach ($node->filter($repeat) as $loop)
						{
							$scrapped[$name][] = $this->clearString($loop->nodeValue);
						}
					}
				}
			}
		}

		return $scrapped;
	}

	/**
	 * Limpa o valor repassado
	 * @param  string $string
	 * @return string
	 */
	public function clearString($string)
	{
		return trim(preg_replace(['/[\s]+/mu'], ' ', $string));
	}

	/**
	 * Filtra selector no crawler
	 */
	public function scrap($selector)
	{
		$node = $this->filter($selector);
		return $node;
	}
}

1		<?php namespace zServices\Sintegra\Services\Portais\SP;
2
3		use zServices\Miscellany\Interfaces\CrawlerInterface;
4		use Symfony\Component\DomCrawler\Crawler as BaseCrawler;
5		use zServices\Miscellany\Exceptions\ErrorFoundData;
6
7		/**
8		*
9		*/
10		class Crawler extends BaseCrawler implements CrawlerInterface
11		{
12
13		/**
14		* Selectors to crawler
15		* @var array
16		*/
17		private $selectors = [];
18
19		/**
20		* Get selectors and initialize crawler in HTML
21		* @param string $html
22		* @param array $selectors
23		* @return void
		0 ignored issues – show Comprehensibility Best Practice introduced 2016-05-02 17:42 UTC by Report Bug Copy Issue Report Adding a `@return` annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Adding a `@return` annotation to a constructor is not recommended, since a constructor does not have a meaningful return value. Please refer to the PHP core documentation on constructors. Loading history...
24		*/
25		public function __construct($html, $selectors)
26		{
27		$this->selectors = $selectors;
28
29		parent::__construct($html);
30		}
31
32		/**
33		* Verifica antes de fazer o crawler se possui erros
34		* na requisição
35		* @return boolean\|null
36		*/
37		public function hasError()
38		{
39		$node = $this->scrap($this->selectors['razao_social']);
40
41		if (!$node->count())
42		{
43		throw new ErrorFoundData($this->clearString($this->scrap($this->selectors['error'])->text()), 1);
44		}
45		}
46
47		/**
48		* Extrai informações do HTML através do DOM
49		*
50		* @return array
51		*/
52	View Code Duplication	public function scraping()
		0 ignored issues – show Duplication introduced 2017-08-02 16:49 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
53		{
54		$scrapped = [];
55
56		$this->hasError();
57
58		foreach ($this->selectors as $name => $selector) {
59		if (is_string($selector)) {
60		$node = $this->scrap($selector);
61
62		if ($node->count()) {
63		$scrapped[$name] = $this->clearString($node->text());
64		}
65		} elseif (is_array($selector)) {
66		foreach ($selector as $selector => $repeat) {
		0 ignored issues – show Bug introduced 2016-05-02 15:20 UTC by Report Bug Copy Issue Report The expression `$selector` of type `integer\|string\|array` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
67		$node = $this->scrap($selector);
68		if ($node->count()) {
69		foreach ($node->filter($repeat) as $loop)
70		{
71		$scrapped[$name][] = $this->clearString($loop->nodeValue);
72		}
73		}
74		}
75		}
76		}
77
78		return $scrapped;
79		}
80
81		/**
82		* Limpa o valor repassado
83		* @param string $string
84		* @return string
85		*/
86		public function clearString($string)
87		{
88		return trim(preg_replace(['/[\s]+/mu'], ' ', $string));
89		}
90
91		/**
92		* Filtra selector no crawler
93		*/
94		public function scrap($selector)
95		{
96		$node = $this->filter($selector);
97		return $node;
98		}
99		}

juniorb2ss / zServices

GitHub Access Token became invalid

Crawler::hasError() A last analyzed 2017-08-07 13:13 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

Crawler::hasError() A
last analyzed 2017-08-07 13:13 UTC