junebug12851 / pokered-save-editor

electron/AppMenu.js

const { Menu } = require('electron');
const menuStructure = require("./data/menu.json");

The constant menuStructure seems to be never used. Consider removing it.

const _ = require("lodash");

The constant _ seems to be never used. Consider removing it.

module.exports = class AppMenu {
    constructor(app) {
        this.app = app;
        this.rebuildMenu();

        app.store.onDidChange('recentDocs', this.onRecentDocsChange.bind(this));
    }

    // Determines if a menu item can completely skip check or not
    doMenuItemSkip(obj) {
        // Is it not the wrong platform
        if (obj.platform !== undefined &&
            process.platform !== obj.platform)
            return true;

Curly braces around statements make for more readable code and help prevent bugs when you add further statements.

        if (obj.notPlatform !== undefined &&
            process.platform === obj.notPlatform)
            return true;

Curly braces around statements make for more readable code and help prevent bugs when you add further statements.

        // Is it the wrong build
        if (obj.env === "dev" &&
            this.app.isDev !== true)
            return true;

Curly braces around statements make for more readable code and help prevent bugs when you add further statements.

        if (obj.env === "prod" &&
            this.app.isDev === true)
            return true;

Curly braces around statements make for more readable code and help prevent bugs when you add further statements.

        return false;
    }

    _rebuildMenu(arr) {
        for (var i = 0; i < arr.length; i++) {
            const obj = arr[i];

            // Is not designated platform
            if (this.doMenuItemSkip(obj)) {
                arr.splice(i, 1);
                i--;

You seem to be assigning a new value to the loop variable i here. Please check if this was indeed your intention. Even if it was, consider using another kind of loop instead.

                continue;
            }

            if (obj.placeholder !== undefined) {
                arr.splice(i, 1);
                i--;

You seem to be assigning a new value to the loop variable i here. Please check if this was indeed your intention. Even if it was, consider using another kind of loop instead.

                if (obj.placeholder === "recentList")
                    arr.splice(i + 1, 0, ...this.recentFilesStructure);

Curly braces around statements make for more readable code and help prevent bugs when you add further statements.

                continue;
            }

            if (obj.trigger !== undefined) {
                obj.click = () => {
                    if (Array.isArray(obj.triggerData))
                        this.app.emit(`menu-${obj.trigger}`, ...obj.triggerData);

Curly braces around statements make for more readable code and help prevent bugs when you add further statements.

                    else
                        this.app.emit(`menu-${obj.trigger}`, obj.triggerData);
                }
            }

            if (obj.submenu !== undefined) {
                this._rebuildMenu(obj.submenu);
            }
        }
    }

    get recentFilesStructure() {
        const store = this.app.store;
        const structure = [];

        // Grab recent docs list
        const recentDocs = store.get('recentDocs', []);

        for (let i = 0; i < recentDocs.length; i++) {
            const recentDoc = recentDocs[i];

            structure.push({
                label: `${recentDoc}`,
                trigger: "openRecentDocs",
                triggerData: i,
                accelerator: `CommandOrControl+Shift+${i}`
            });
        }

        return structure;
    }

    rebuildMenu() {
        this.menuStructure = _.cloneDeep(menuStructure);

The variable _ seems to be never declared. If this is a global, consider adding a /** global: _ */ comment.

The variable menuStructure seems to be never declared. If this is a global, consider adding a /** global: menuStructure */ comment.

        this._rebuildMenu(this.menuStructure);

        let menu = Menu.buildFromTemplate(this.menuStructure);

The variable Menu seems to be never declared. If this is a global, consider adding a /** global: Menu */ comment.

        Menu.setApplicationMenu(menu);
    }

    onRecentDocsChange(newVal, oldVal) {

The parameter oldVal is not used and could be removed.

The parameter newVal is not used and could be removed.

        this.rebuildMenu();
    }
}