junebug12851 / pokered-save-editor

electron/App.js

const { app, ipcMain } = require('electron');
const path = require("path");

The constant path seems to be never used. Consider removing it.

const Window = require("./Window");

The constant Window seems to be never used. Consider removing it.

const AppMenu = require("./AppMenu");

The constant AppMenu seems to be never used. Consider removing it.

const Store = require('electron-store');

The constant Store seems to be never used. Consider removing it.

const EventEmitter = require('events');

The constant EventEmitter seems to be never used. Consider removing it.

const SaveFile = require('./SaveFile');

The constant SaveFile seems to be never used. Consider removing it.

/**
 * App Singleton (Wrapper around electron app singleton var)
 */
module.exports = class App extends EventEmitter {
    constructor() {
        super();

        // Make Single Instance and ensure single instance
        // if (app.requestSingleInstanceLock()) {
        //     this.quit();
        //     return;
        // }
        //app.on('second-instance', this.onSecondInstance.bind(this));

        // Electron app var
        this.app = app;

        // Window
        this.mainWindow = null;

        // Is development or not
        this.isDev = process.env.DEV
            ? (process.env.DEV.trim() == "true")
            : false;

        // Adjust process working directory depending on dev enviroment or not
        if (this.isDev)
            process.chdir(path.join(__dirname, '../src'));

Curly braces around statements make for more readable code and help prevent bugs when you add further statements.

The variable path seems to be never declared. If this is a global, consider adding a /** global: path */ comment.

        else
            process.chdir(path.join(__dirname, '../dist/pokered-save-editor'));

        this.store = new Store();

The variable Store seems to be never declared. If this is a global, consider adding a /** global: Store */ comment.

        this.saveFile = new SaveFile(this);

The variable SaveFile seems to be never declared. If this is a global, consider adding a /** global: SaveFile */ comment.

        // App Icon
        this.icon = 'assets/icons/512x512.png';

        // Set Name
        app.setName("Pokered Save Editor");

        // App events to hook into for wrapper
        app.on('ready', this.createWindow.bind(this));
        app.on('window-all-closed', this.quit.bind(this));

        ipcMain.on('ipcFrom', this.onIpcFrom.bind(this));

The variable ipcMain seems to be never declared. If this is a global, consider adding a /** global: ipcMain */ comment.

    }

    onIpcFrom(sender, event, ...args) {
        this.emit(`ipcFrom-${event}`, ...args);
    }

    onSecondInstance(argv, cwd) {

The parameter cwd is not used and could be removed.

The parameter argv is not used and could be removed.

        if (this.mainWindow)
            this.mainWindow.reOpen();

Curly braces around statements make for more readable code and help prevent bugs when you add further statements.

    }

    createWindow() {
        // Menu must be called around this time so it's placed here
        this.menu = new AppMenu(this);

The variable AppMenu seems to be never declared. If this is a global, consider adding a /** global: AppMenu */ comment.

        this.mainWindow = new Window(this);

The variable Window seems to be never declared. If this is a global, consider adding a /** global: Window */ comment.

    }

    quit() {
        app.quit();
    }
}