DeCaptchaAbstractTest - Code Metrics - Inspection of "Merge remote-tracking branch 'origin/master'" - jumper423/decaptcha - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 90d111...2a2a91 )

by Владислав

created 2016-12-13 17:09 UTC

DeCaptchaAbstractTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	239
Duplicated Lines	7.53 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

Metric	Value
wmc	15
lcom	1
cbo	1
dl	18
loc	239
rs	10
c	0
b	0
f	0

15 Methods

Rating	Name	Duplication	Size	Complexity
A	newInstance()	0	7	1
A	testGetBaseUrl()	0	10	1
A	testSetApiKey()	0	19	1
A	testGetActionUrl()	0	20	1
A	testGetFilePath()	0	13	1
A	testGetFilePathErrorFileNotFound()	9	9	1
A	testGetFilePathErrorFileIsNotLoaded()	9	9	1
A	testGetFilePathErrorFileIsNotWriteAccessFile()	0	11	1
A	testGetResponse()	0	11	1
B	testExecutionDelayed()	0	34	1
A	testGetInUrl()	0	11	1
A	testIsError()	0	9	1
A	testIsErrorNot()	0	9	1
A	testGetCurlResponseError()	0	10	1
A	testGetCurlResponse()	0	14	1

How to fix Duplicated Code

<?php

/**
 * Class DeCaptchaAbstractTest.
 */
class DeCaptchaAbstractTest extends PHPUnit_Framework_TestCase
namespace YourVendor;

class YourClass { }
{
    /**
     * @return PHPUnit_Framework_MockObject_MockObject|\jumper423\decaptcha\core\DeCaptchaAbstract
     */
    public function newInstance()
    {
        $abstract = $this->getMockForAbstractClass(\jumper423\decaptcha\core\DeCaptchaAbstract::class);
        $abstract->errorLang = \jumper423\decaptcha\core\DeCaptchaErrors::LANG_RU;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}

        return $abstract;
    }

    public function testGetBaseUrl()
    {
        $abstract = $this->newInstance();
        $getBaseUrlCaller = function () {
            return $this->getBaseUrl();

        };
        $abstract->domain = 'domain';
        $bound = $getBaseUrlCaller->bindTo($abstract, $abstract);
        $this->assertEquals('http://domain/', $bound());
    }

    public function testSetApiKey()
    {
        $abstract = $this->newInstance();
        $abstract->setApiKey('123456val');
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        $apiKeyValCaller = function () {
            return $this->apiKey;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        };
        $bound = $apiKeyValCaller->bindTo($abstract, $abstract);
        $this->assertEquals('123456val', $bound());

        $abstract->setApiKey(function () {
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            return '123456'.'fun';
        });
        $apiKeyFunCaller = function () {
            return $this->apiKey;
        };
        $bound = $apiKeyFunCaller->bindTo($abstract, $abstract);
        $this->assertEquals('123456fun', $bound());
    }

    public function testGetActionUrl()
    {
        $abstract = $this->newInstance();
        $getBaseUrlGetCodeCaller = function () {
            $this->captchaId = 123;
class MyClass { }

$x = new MyClass();
$x->foo = true;

            return $this->getActionUrl('get_code');

        };
        $getBaseUrlGetBalanceCaller = function () {
            $this->captchaId = 234;

            return $this->getActionUrl('get_balance');

        };
        $abstract->domain = 'domain';
        $abstract->setApiKey('123456');
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        $bound = $getBaseUrlGetCodeCaller->bindTo($abstract, $abstract);
        $this->assertEquals('http://domain/res.php?key=123456&action=get_code&id=123', $bound());
        $bound = $getBaseUrlGetBalanceCaller->bindTo($abstract, $abstract);
        $this->assertEquals('http://domain/res.php?key=123456&action=get_balance&id=234', $bound());
    }

    public function testGetFilePath()
    {
        $abstract = $this->newInstance();
        $getFilePathCaller = function ($val) {
            return $this->getFilePath($val);

        };
        $bound = $getFilePathCaller->bindTo($abstract, $abstract);
        $this->assertEquals(__DIR__.'/data/Captcha.jpg', $bound(__DIR__.'/data/Captcha.jpg'));
        $filePathUpload = $bound('https://upload.wikimedia.org/wikipedia/commons/6/69/Captcha.jpg');
        $file1 = file_get_contents(__DIR__.'/data/Captcha.jpg');
        $file2 = file_get_contents($filePathUpload);
        $this->assertEquals($file1, $file2);
    }

    /**
     * @expectedException \jumper423\decaptcha\core\DeCaptchaErrors
     * @expectedExceptionCode 16
     */
    public function testGetFilePathErrorFileNotFound()

    {
        $abstract = $this->newInstance();
        $getFilePathCaller = function ($val) {
            return $this->getFilePath($val);

        };
        $bound = $getFilePathCaller->bindTo($abstract, $abstract);
        $bound(__DIR__.'/data/Captcha1.jpg');
    }

    /**
     * @expectedException \jumper423\decaptcha\core\DeCaptchaErrors
     * @expectedExceptionMessage Файл не загрузился: https://upload.wikimedia.org/wikipedia/commons/6/69/Captcha46.jpg123
     * @expectedExceptionCode 15
     */
    public function testGetFilePathErrorFileIsNotLoaded()

    {
        $abstract = $this->newInstance();
        $getFilePathCaller = function ($val) {
            return $this->getFilePath($val);

        };
        $bound = $getFilePathCaller->bindTo($abstract, $abstract);
        $bound('https://upload.wikimedia.org/wikipedia/commons/6/69/Captcha46.jpg123');
    }

    /**
     * @expectedException \jumper423\decaptcha\core\DeCaptchaErrors
     * @expectedExceptionMessage Файл не загрузился: https://upload.wikimedia.org/wikipedia/commons/6/69/Captcha46.jpg123
     * @expectedExceptionCode 14
     */
    public function testGetFilePathErrorFileIsNotWriteAccessFile()
    {
        $abstract = $this->newInstance();
        $getFilePathCaller = function ($val) {
            return $this->getFilePath($val);

        };
        $bound = $getFilePathCaller->bindTo($abstract, $abstract);
        $path = tempnam(sys_get_temp_dir(), 'WRITE_ACCESS_FILE');
        chmod($path, 0000);
        $bound($path);
    }

    public function testGetResponse()
    {
        $abstract = $this->newInstance();
        $abstract->domain = 'echo.jsontest.com/aaa/bbb';
        $getResponseCaller = function ($val) {
            return $this->getResponse($val);

        };
        $bound = $getResponseCaller->bindTo($abstract, $abstract);
        $res = $bound('');
        $this->assertEquals('{"res.php":"","aaa":"bbb"}', str_replace("\n", '', str_replace(' ', '', $res)));
    }

    public function testExecutionDelayed()
    {
        $abstract = $this->newInstance();
        $executionDelayedCaller = function ($second, $call = null) {
            return $this->executionDelayed($second, $call);

        };
        $bound = $executionDelayedCaller->bindTo($abstract, $abstract);
        $start = microtime(true);
        $bound(0);
        $bound(0.1);
        $timePassed = microtime(true) - $start;
        $this->assertTrue(abs($timePassed - 0.1) < 0.035);

        $start = microtime(true);
        $bound(0.15, function () {
            sleep(0.2);
        });
        $bound(0.1);
        $timePassed = microtime(true) - $start;
        $this->assertTrue(abs($timePassed - 0.25) < 0.035);

        $start = microtime(true);
        $bound(0.15, function () {
            sleep(0.2);
        });
        $bound(0.3);
        $timePassed = microtime(true) - $start;
        $this->assertTrue(abs($timePassed - 0.45) < 0.035);

        $this->assertEquals(2, $bound(0, function () {
            return 2;
        }));
        $this->assertEquals(null, $bound(0));
    }

    public function testGetInUrl()
    {
        $abstract = $this->newInstance();
        $getInUrlCaller = function () {
            return $this->getInUrl();

        };
        $abstract->domain = 'domain';
        $abstract->setApiKey('123456');
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        $bound = $getInUrlCaller->bindTo($abstract, $abstract);
        $this->assertEquals('http://domain/in.php', $bound());
    }

    /**
     * @expectedException \jumper423\decaptcha\core\DeCaptchaErrors
     * @expectedExceptionCode 4
     */
    public function testIsError()
    {
        $abstract = $this->newInstance();
        $isErrorCaller = function ($val) {
            return $this->isError($val);

        };
        $bound = $isErrorCaller->bindTo($abstract, $abstract);
        $bound('ERROR_IP_NOT_ALLOWED');
    }

    public function testIsErrorNot()
    {
        $abstract = $this->newInstance();
        $isErrorCaller = function ($val) {
            return $this->isError($val);

        };
        $bound = $isErrorCaller->bindTo($abstract, $abstract);
        $this->assertNull($bound('BALANCE:56'));
    }

    /**
     * @expectedException \jumper423\decaptcha\core\DeCaptchaErrors
     * @expectedExceptionCode 17
     * @expectedExceptionMessage Ошибка CURL: Could
     */
    public function testGetCurlResponseError()
    {
        $abstract = $this->newInstance();
        $abstract->domain = 'domain';
        $getCurlResponseCaller = function ($val) {
            return $this->getCurlResponse($val);

        };
        $bound = $getCurlResponseCaller->bindTo($abstract, $abstract);
        $bound(['protected' => 'value']);
    }

    public function testGetCurlResponse()
    {
        $abstract = $this->newInstance();
        $abstract->domain = 'httpbin.org';
        $getCurlResponseCaller = function ($val) {
            $this->inUrl = 'post';
class MyClass { }

$x = new MyClass();
$x->foo = true;

            return $this->getCurlResponse($val);

        };
        $bound = $getCurlResponseCaller->bindTo($abstract, $abstract);
        $data = $bound(['protected' => 'value']);
        $data = json_decode($data, true);
        $this->assertEquals(['protected' => 'value'], $data['form']);
    }
}


Push — master ( 90d111...2a2a91 )

DeCaptchaAbstractTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

15 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

1			<?php
2
3			/**
4			* Class DeCaptchaAbstractTest.
5			*/
6			class DeCaptchaAbstractTest extends PHPUnit_Framework_TestCase
			1 ignored issue – show Coding Style Compatibility introduced 2016-12-09 15:40 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
7			{
8			/**
9			* @return PHPUnit_Framework_MockObject_MockObject\|\jumper423\decaptcha\core\DeCaptchaAbstract
10			*/
11			public function newInstance()
12			{
13			$abstract = $this->getMockForAbstractClass(\jumper423\decaptcha\core\DeCaptchaAbstract::class);
14			$abstract->errorLang = \jumper423\decaptcha\core\DeCaptchaErrors::LANG_RU;
			0 ignored issues – show Bug introduced 2016-12-09 15:40 UTC by Report Bug Copy Issue Report Accessing `errorLang` on the interface `PHPUnit_Framework_MockObject_MockObject` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
15
16			return $abstract;
17			}
18
19			public function testGetBaseUrl()
20			{
21			$abstract = $this->newInstance();
22			$getBaseUrlCaller = function () {
23			return $this->getBaseUrl();
			1 ignored issue – show Bug introduced 2016-12-09 15:40 UTC by Report Bug Copy Issue Report The method `getBaseUrl()` does not exist on `DeCaptchaAbstractTest`. Did you maybe mean `testGetBaseUrl()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
24			};
25			$abstract->domain = 'domain';
26			$bound = $getBaseUrlCaller->bindTo($abstract, $abstract);
27			$this->assertEquals('http://domain/', $bound());
28			}
29
30			public function testSetApiKey()
31			{
32			$abstract = $this->newInstance();
33			$abstract->setApiKey('123456val');
			0 ignored issues – show Bug introduced 2016-12-10 16:17 UTC by Report Bug Copy Issue Report The method `setApiKey` does only exist in `jumper423\decaptcha\core\DeCaptchaAbstract`, but not in `PHPUnit_Framework_MockObject_MockObject`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
34			$apiKeyValCaller = function () {
35			return $this->apiKey;
			0 ignored issues – show Bug introduced 2016-12-09 15:40 UTC by Report Bug Copy Issue Report The property `apiKey` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...

jumper423 / decaptcha

Push — master ( 90d111...2a2a91 )

DeCaptchaAbstractTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

15 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like