Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 12 | class DeCaptchaBase extends DeCaptchaAbstract implements DeCaptchaInterface |
||
| 13 | { |
||
| 14 | const PARAM_FIELD_METHOD = 0; |
||
| 15 | const PARAM_FIELD_KEY = 1; |
||
| 16 | const PARAM_FIELD_FILE = 2; |
||
| 17 | const PARAM_FIELD_PHRASE = 3; |
||
| 18 | const PARAM_FIELD_REGSENSE = 4; |
||
| 19 | const PARAM_FIELD_NUMERIC = 5; |
||
| 20 | const PARAM_FIELD_MIN_LEN = 6; |
||
| 21 | const PARAM_FIELD_MAX_LEN = 7; |
||
| 22 | const PARAM_FIELD_LANGUAGE = 8; |
||
| 23 | const PARAM_FIELD_SOFT_ID = 9; |
||
| 24 | const PARAM_FIELD_CAPTCHA_ID = 10; |
||
| 25 | const PARAM_FIELD_ACTION = 11; |
||
| 26 | |||
| 27 | const ACTION_RECOGNIZE = 0; |
||
| 28 | const ACTION_UNIVERSAL = 1; |
||
| 29 | const ACTION_UNIVERSAL_WITH_CAPTCHA = 2; |
||
| 30 | |||
| 31 | protected $paramsNames = [ |
||
| 32 | self::PARAM_FIELD_METHOD => 'method', |
||
| 33 | self::PARAM_FIELD_KEY => 'key', |
||
| 34 | self::PARAM_FIELD_FILE => 'file', |
||
| 35 | self::PARAM_FIELD_PHRASE => 'phrase', |
||
| 36 | self::PARAM_FIELD_REGSENSE => 'regsense', |
||
| 37 | self::PARAM_FIELD_NUMERIC => 'numeric', |
||
| 38 | self::PARAM_FIELD_MIN_LEN => 'min_len', |
||
| 39 | self::PARAM_FIELD_MAX_LEN => 'max_len', |
||
| 40 | self::PARAM_FIELD_LANGUAGE => 'language', |
||
| 41 | self::PARAM_FIELD_SOFT_ID => 'soft_id', |
||
| 42 | self::PARAM_FIELD_CAPTCHA_ID => 'id', |
||
| 43 | self::PARAM_FIELD_ACTION => 'action', |
||
| 44 | ]; |
||
| 45 | |||
| 46 | protected $paramsSettings = [ |
||
| 47 | self::ACTION_RECOGNIZE => [ |
||
| 48 | self::PARAM_FIELD_METHOD => [ |
||
| 49 | self::PARAM_SLUG_DEFAULT => 'post', |
||
| 50 | self::PARAM_SLUG_TYPE => self::PARAM_FIELD_TYPE_STRING, |
||
| 51 | ], |
||
| 52 | self::PARAM_FIELD_KEY => [ |
||
| 53 | self::PARAM_SLUG_REQUIRE => true, |
||
| 54 | self::PARAM_SLUG_SPEC => self::PARAM_SPEC_KEY, |
||
| 55 | self::PARAM_SLUG_TYPE => self::PARAM_FIELD_TYPE_STRING, |
||
| 56 | ], |
||
| 57 | self::PARAM_FIELD_FILE => [ |
||
| 58 | self::PARAM_SLUG_REQUIRE => true, |
||
| 59 | self::PARAM_SLUG_SPEC => self::PARAM_SPEC_FILE, |
||
| 60 | self::PARAM_SLUG_TYPE => self::PARAM_FIELD_TYPE_STRING, |
||
| 61 | ], |
||
| 62 | self::PARAM_FIELD_PHRASE => [ |
||
| 63 | self::PARAM_SLUG_DEFAULT => 0, |
||
| 64 | self::PARAM_SLUG_TYPE => self::PARAM_FIELD_TYPE_INTEGER, |
||
| 65 | ], |
||
| 66 | self::PARAM_FIELD_REGSENSE => [ |
||
| 67 | self::PARAM_SLUG_DEFAULT => 0, |
||
| 68 | self::PARAM_SLUG_TYPE => self::PARAM_FIELD_TYPE_INTEGER, |
||
| 69 | ], |
||
| 70 | self::PARAM_FIELD_NUMERIC => [ |
||
| 71 | self::PARAM_SLUG_DEFAULT => 0, |
||
| 72 | self::PARAM_SLUG_TYPE => self::PARAM_FIELD_TYPE_INTEGER, |
||
| 73 | ], |
||
| 74 | self::PARAM_FIELD_MIN_LEN => [ |
||
| 75 | self::PARAM_SLUG_DEFAULT => 0, |
||
| 76 | self::PARAM_SLUG_TYPE => self::PARAM_FIELD_TYPE_INTEGER, |
||
| 77 | ], |
||
| 78 | self::PARAM_FIELD_MAX_LEN => [ |
||
| 79 | self::PARAM_SLUG_DEFAULT => 0, |
||
| 80 | self::PARAM_SLUG_TYPE => self::PARAM_FIELD_TYPE_INTEGER, |
||
| 81 | ], |
||
| 82 | self::PARAM_FIELD_LANGUAGE => [ |
||
| 83 | self::PARAM_SLUG_DEFAULT => 0, |
||
| 84 | self::PARAM_SLUG_TYPE => self::PARAM_FIELD_TYPE_INTEGER, |
||
| 85 | ], |
||
| 86 | self::PARAM_FIELD_SOFT_ID => [ |
||
| 87 | self::PARAM_SLUG_VARIABLE => false, |
||
| 88 | self::PARAM_SLUG_TYPE => self::PARAM_FIELD_TYPE_INTEGER, |
||
| 89 | ], |
||
| 90 | ], |
||
| 91 | self::ACTION_UNIVERSAL => [ |
||
| 92 | self::PARAM_FIELD_KEY => [ |
||
| 93 | self::PARAM_SLUG_REQUIRE => true, |
||
| 94 | self::PARAM_SLUG_SPEC => self::PARAM_SPEC_KEY, |
||
| 95 | self::PARAM_SLUG_TYPE => self::PARAM_FIELD_TYPE_STRING, |
||
| 96 | ], |
||
| 97 | self::PARAM_FIELD_ACTION => [ |
||
| 98 | self::PARAM_SLUG_REQUIRE => true, |
||
| 99 | self::PARAM_SLUG_TYPE => self::PARAM_FIELD_TYPE_STRING, |
||
| 100 | ], |
||
| 101 | ], |
||
| 102 | self::ACTION_UNIVERSAL_WITH_CAPTCHA => [ |
||
| 103 | self::PARAM_FIELD_KEY => [ |
||
| 104 | self::PARAM_SLUG_REQUIRE => true, |
||
| 105 | self::PARAM_SLUG_SPEC => self::PARAM_SPEC_KEY, |
||
| 106 | self::PARAM_SLUG_TYPE => self::PARAM_FIELD_TYPE_STRING, |
||
| 107 | ], |
||
| 108 | self::PARAM_FIELD_CAPTCHA_ID => [ |
||
| 109 | self::PARAM_SLUG_REQUIRE => true, |
||
| 110 | self::PARAM_SLUG_SPEC => self::PARAM_SPEC_CAPTCHA, |
||
| 111 | self::PARAM_SLUG_TYPE => self::PARAM_FIELD_TYPE_INTEGER, |
||
| 112 | ], |
||
| 113 | self::PARAM_FIELD_ACTION => [ |
||
| 114 | self::PARAM_SLUG_REQUIRE => true, |
||
| 115 | self::PARAM_SLUG_TYPE => self::PARAM_FIELD_TYPE_STRING, |
||
| 116 | ], |
||
| 117 | ], |
||
| 118 | ]; |
||
| 119 | |||
| 120 | public function recognize($filePath) |
||
| 154 | |||
| 155 | public function getCode() |
||
| 158 | |||
| 159 | public function getError() |
||
| 162 | |||
| 163 | /** |
||
| 164 | * Запуск распознавания капчи. |
||
| 165 | * |
||
| 166 | * @deprecated |
||
| 167 | * |
||
| 168 | * @param string $filePath Путь до файла или ссылка на него |
||
| 169 | * |
||
| 170 | * @return bool |
||
| 171 | */ |
||
| 172 | public function run($filePath) |
||
| 176 | |||
| 177 | /** |
||
| 178 | * Не верно распознана. |
||
| 179 | */ |
||
| 180 | public function notTrue() |
||
| 184 | |||
| 185 | protected function decodeResponse($data, $type, $format = self::RESPONSE_TYPE_STRING) |
||
| 200 | } |
||
| 201 |
This check marks calls to methods that do not seem to exist on an object.
This is most likely the result of a method being renamed without all references to it being renamed likewise.