DeCaptchaAbstractTest - Code Metrics - Inspection of "Create .scrutinizer.yml" - jumper423/decaptcha - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b6da7b...a9dd77 )

by Владислав

created 2016-12-09 16:18 UTC

DeCaptchaAbstractTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	185
Duplicated Lines	34.59 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

Metric	Value
wmc	11
lcom	1
cbo	1
dl	64
loc	185
rs	10
c	0
b	0
f	0

11 Methods

Rating	Name	Duplication	Size	Complexity
A	testSetApiKey()	0	19	1
A	testGetActionUrl()	0	18	1
A	testGetFilePath()	0	13	1
A	testGetResponse()	0	11	1
B	testExecutionDelayed()	0	34	1
A	testGetBaseUrl()	13	13	1
A	testGetFilePathErrorFileNotFound()	10	10	1
A	testGetFilePathErrorFileIsNotLoaded()	10	10	1
A	testGetInUrl()	11	11	1
A	testIsError()	10	10	1
A	testIsErrorNot()	10	10	1

How to fix Duplicated Code

<?php

class DeCaptchaAbstractTest extends PHPUnit_Framework_TestCase
namespace YourVendor;

class YourClass { }
{
    public function testGetBaseUrl()

    {
        $abstract = $this->getMockForAbstractClass(\jumper423\decaptcha\core\DeCaptchaAbstract::class);
//        $foo->expects($this->any())

//            ->method("baz")
//            ->will($this->returnValue("You called baz!"));
        $getBaseUrlCaller = function () {
            return $this->getBaseUrl();

        };
        $abstract->domain = 'domain';
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $bound = $getBaseUrlCaller->bindTo($abstract, $abstract);
        $this->assertEquals('http://domain/', $bound());
    }

    public function testSetApiKey()
    {
        $abstract = $this->getMockForAbstractClass(\jumper423\decaptcha\core\DeCaptchaAbstract::class);
        $abstract->setApiKey('123456val');
        $apiKeyValCaller = function () {
            return $this->apiKey;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        };
        $bound = $apiKeyValCaller->bindTo($abstract, $abstract);
        $this->assertEquals('123456val', $bound());

        $abstract->setApiKey(function () {
            return '123456' . 'fun';
        });
        $apiKeyFunCaller = function () {
            return $this->apiKey;
        };
        $bound = $apiKeyFunCaller->bindTo($abstract, $abstract);
        $this->assertEquals('123456fun', $bound());
    }

    public function testGetActionUrl()
    {
        $abstract = $this->getMockForAbstractClass(\jumper423\decaptcha\core\DeCaptchaAbstract::class);
        $getBaseUrlGetCodeCaller = function () {
            $this->captchaId = 123;
class MyClass { }

$x = new MyClass();
$x->foo = true;
            return $this->getActionUrl('get_code');

        };
        $getBaseUrlGetBalanceCaller = function () {
            $this->captchaId = 234;
            return $this->getActionUrl('get_balance');

        };
        $abstract->domain = 'domain';
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $abstract->setApiKey('123456');
        $bound = $getBaseUrlGetCodeCaller->bindTo($abstract, $abstract);
        $this->assertEquals('http://domain/res.php?key=123456&action=get_code&id=123', $bound());
        $bound = $getBaseUrlGetBalanceCaller->bindTo($abstract, $abstract);
        $this->assertEquals('http://domain/res.php?key=123456&action=get_balance&id=234', $bound());
    }

    public function testGetFilePath()
    {
        $abstract = $this->getMockForAbstractClass(\jumper423\decaptcha\core\DeCaptchaAbstract::class);
        $getFilePathCaller = function ($val) {
            return $this->getFilePath($val);

        };
        $bound = $getFilePathCaller->bindTo($abstract, $abstract);
        $this->assertEquals(__DIR__ . '/data/Captcha.jpg', $bound(__DIR__ . '/data/Captcha.jpg'));
        $filePathUpload = $bound('https://upload.wikimedia.org/wikipedia/commons/6/69/Captcha.jpg');
        $file1 = file_get_contents(__DIR__ . '/data/Captcha.jpg');
        $file2 = file_get_contents($filePathUpload);
        $this->assertEquals($file1, $file2);
    }

    /**
     * @expectedException \jumper423\decaptcha\core\DeCaptchaErrors
     * @expectedExceptionCode 16
     */
    public function testGetFilePathErrorFileNotFound()

    {
        $abstract = $this->getMockForAbstractClass(\jumper423\decaptcha\core\DeCaptchaAbstract::class);
        $abstract->errorLang = \jumper423\decaptcha\core\DeCaptchaErrors::LANG_RU;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $getFilePathCaller = function ($val) {
            return $this->getFilePath($val);

        };
        $bound = $getFilePathCaller->bindTo($abstract, $abstract);
        $bound(__DIR__ . '/data/Captcha1.jpg');
    }

    /**
     * @expectedException \jumper423\decaptcha\core\DeCaptchaErrors
     * @expectedExceptionMessage Файл не загрузился: https://upload.wikimedia.org/wikipedia/commons/6/69/Captcha46.jpg123
     * @expectedExceptionCode 15
     */
    public function testGetFilePathErrorFileIsNotLoaded()

    {
        $abstract = $this->getMockForAbstractClass(\jumper423\decaptcha\core\DeCaptchaAbstract::class);
        $abstract->errorLang = \jumper423\decaptcha\core\DeCaptchaErrors::LANG_RU;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $getFilePathCaller = function ($val) {
            return $this->getFilePath($val);

        };
        $bound = $getFilePathCaller->bindTo($abstract, $abstract);
        $bound('https://upload.wikimedia.org/wikipedia/commons/6/69/Captcha46.jpg123');
    }

    public function testGetResponse()
    {
        $abstract = $this->getMockForAbstractClass(\jumper423\decaptcha\core\DeCaptchaAbstract::class);
        $abstract->domain = 'echo.jsontest.com/aaa/bbb';
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $getResponseCaller = function ($val) {
            return $this->getResponse($val);

        };
        $bound = $getResponseCaller->bindTo($abstract, $abstract);
        $res = $bound('');
        $this->assertEquals('{"res.php":"","aaa":"bbb"}', str_replace("\n", '', str_replace(" ", '', $res)));
    }

    public function testExecutionDelayed()
    {
        $abstract = $this->getMockForAbstractClass(\jumper423\decaptcha\core\DeCaptchaAbstract::class);
        $executionDelayedCaller = function ($second, $call = null) {
            return $this->executionDelayed($second, $call);

        };
        $bound = $executionDelayedCaller->bindTo($abstract, $abstract);
        $start = microtime(true);
        $bound(0);
        $bound(0.1);
        $timePassed = microtime(true) - $start;
        $this->assertTrue(abs($timePassed - 0.1) < 0.025);

        $start = microtime(true);
        $bound(0.15, function () {
            sleep(0.2);
        });
        $bound(0.1);
        $timePassed = microtime(true) - $start;
        $this->assertTrue(abs($timePassed - 0.25) < 0.025);

        $start = microtime(true);
        $bound(0.15, function () {
            sleep(0.2);
        });
        $bound(0.3);
        $timePassed = microtime(true) - $start;
        $this->assertTrue(abs($timePassed - 0.45) < 0.025);

        $this->assertEquals(2, $bound(0, function () {
            return 2;
        }));
        $this->assertEquals(null, $bound(0));
    }

    public function testGetInUrl()

    {
        $abstract = $this->getMockForAbstractClass(\jumper423\decaptcha\core\DeCaptchaAbstract::class);
        $getInUrlCaller = function () {
            return $this->getInUrl();

        };
        $abstract->domain = 'domain';
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $abstract->setApiKey('123456');
        $bound = $getInUrlCaller->bindTo($abstract, $abstract);
        $this->assertEquals('http://domain/in.php', $bound());
    }

    /**
     * @expectedException \jumper423\decaptcha\core\DeCaptchaErrors
     * @expectedExceptionCode 4
     */
    public function testIsError()

    {
        $abstract = $this->getMockForAbstractClass(\jumper423\decaptcha\core\DeCaptchaAbstract::class);
        $abstract->errorLang = \jumper423\decaptcha\core\DeCaptchaErrors::LANG_RU;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $isErrorCaller = function ($val) {
            return $this->isError($val);

        };
        $bound = $isErrorCaller->bindTo($abstract, $abstract);
        $bound('ERROR_IP_NOT_ALLOWED');
    }

    public function testIsErrorNot()

    {
        $abstract = $this->getMockForAbstractClass(\jumper423\decaptcha\core\DeCaptchaAbstract::class);
        $abstract->errorLang = \jumper423\decaptcha\core\DeCaptchaErrors::LANG_RU;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $isErrorCaller = function ($val) {
            return $this->isError($val);

        };
        $bound = $isErrorCaller->bindTo($abstract, $abstract);
        $this->assertNull($bound('BALANCE:56'));
    }
}

Push — master ( b6da7b...a9dd77 )

DeCaptchaAbstractTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

11 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

1		<?php
2
3		class DeCaptchaAbstractTest extends PHPUnit_Framework_TestCase
		1 ignored issue – show Coding Style Compatibility introduced 2016-12-09 15:40 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
4		{
5	View Code Duplication	public function testGetBaseUrl()
		0 ignored issues – show Duplication introduced 2016-12-09 15:40 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
6		{
7		$abstract = $this->getMockForAbstractClass(\jumper423\decaptcha\core\DeCaptchaAbstract::class);
8		// $foo->expects($this->any())
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-12-09 15:40 UTC by Report Bug Copy Issue Report `68%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
9		// ->method("baz")
10		// ->will($this->returnValue("You called baz!"));
11		$getBaseUrlCaller = function () {
12		return $this->getBaseUrl();
		1 ignored issue – show Bug introduced 2016-12-09 15:40 UTC by Report Bug Copy Issue Report The method `getBaseUrl()` does not exist on `DeCaptchaAbstractTest`. Did you maybe mean `testGetBaseUrl()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
13		};
14		$abstract->domain = 'domain';
		0 ignored issues – show Bug introduced 2016-12-09 15:40 UTC by Report Bug Copy Issue Report Accessing `domain` on the interface `PHPUnit_Framework_MockObject_MockObject` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
15		$bound = $getBaseUrlCaller->bindTo($abstract, $abstract);
16		$this->assertEquals('http://domain/', $bound());
17		}
18
19		public function testSetApiKey()
20		{
21		$abstract = $this->getMockForAbstractClass(\jumper423\decaptcha\core\DeCaptchaAbstract::class);
22		$abstract->setApiKey('123456val');
23		$apiKeyValCaller = function () {
24		return $this->apiKey;
		0 ignored issues – show Bug introduced 2016-12-09 15:40 UTC by Report Bug Copy Issue Report The property `apiKey` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
25		};
26		$bound = $apiKeyValCaller->bindTo($abstract, $abstract);
27		$this->assertEquals('123456val', $bound());
28
29		$abstract->setApiKey(function () {
30		return '123456' . 'fun';
31		});
32		$apiKeyFunCaller = function () {
33		return $this->apiKey;
34		};

jumper423 / decaptcha

Push — master ( b6da7b...a9dd77 )

DeCaptchaAbstractTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

11 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like