Issues in GeneratorCommandTrait.php (master) - Issues in master - jumilla/laravel-extension - Measure and Improve Code Quality continuously with Scrutinizer

Issues (53)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

sources/Generators/GeneratorCommandTrait.php (3 issues)

Labels

Severity

Fumio Furukawa 3

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace LaravelPlus\Extension\Generators;

use Jumilla\Addomnipot\Laravel\Environment as AddonEnvironment;
use Jumilla\Addomnipot\Laravel\Addon;
use UnexpectedValueException;

trait GeneratorCommandTrait
{
    /**
     * addon.
     *
     * @var \LaravelPlus\Extension\Addons\Addon
     */
    protected $addon;

    /**
     * Execute the console command.
     *
     * @return bool
     */
    public function handle()
    {
        if (!$this->processArguments()) {
            return false;
        }

        $this->addon = $this->getAddon();


        return parent::handle();
    }

    /**
     * Process command line arguments
     *
     * @return bool
     */
    protected function processArguments()
    {
        return true;
    }

    /**
     * Option --addon specified.
     *
     * @return bool
     */
    protected function onAddon()
    {
        return $this->option('addon') !== null;
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Get addon.
     *
     * @return string
     */
    protected function getAddon()
    {
        if ($addon = $this->option('addon')) {
            $env = app(AddonEnvironment::class);

            if (!$env->exists($addon)) {
                throw new UnexpectedValueException("Addon '$addon' is not found.");
            }

            return $env->addon($addon);
        } else {
            return;
        }
    }

    /**
     * Get the application namespace.
     *
     * @return $string
     */
    protected function getAppNamespace()
    {
        return trim($this->laravel->getNamespace(), '\\');
    }

    /**
    * Get the addon namespace.
     *
     * @return $string

     */
    protected function getAddonNamespace()
    {
        return $this->addon->phpNamespace();
    }

    /**
     * Get the default namespace for the class.
     *
     * @return $string
     */
    protected function getRootNamespace()
    {
        return $this->addon ? $this->getAddonNamespace() : $this->getAppNamespace();
    }

    /**
     * Get the directory path for root namespace.
     *
     * @return string
     */
    protected function getRootDirectory()
    {
        if ($this->addon) {
            $directories = $this->addon->config('addon.directories');

            if (! $directories) {
                $directories = ['classes'];
            }

            return $this->addon->path($directories[0]);
        }
        else {
            return parent::getRootDirectory();
        }
    }
}


1		<?php
2
3		namespace LaravelPlus\Extension\Generators;
4
5		use Jumilla\Addomnipot\Laravel\Environment as AddonEnvironment;
6		use Jumilla\Addomnipot\Laravel\Addon;
7		use UnexpectedValueException;
8
9		trait GeneratorCommandTrait
10		{
11		/**
12		* addon.
13		*
14		* @var \LaravelPlus\Extension\Addons\Addon
15		*/
16		protected $addon;
17
18		/**
19		* Execute the console command.
20		*
21		* @return bool
22		*/
23	67	public function handle()
24		{
25	67	if (!$this->processArguments()) {
26	1	return false;
27		}
28
29	65	$this->addon = $this->getAddon();
		0 ignored issues – show Documentation Bug introduced 2016-08-04 17:58 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$this->getAddon()` of type `string` is incompatible with the declared type `object<LaravelPlus\Extension\Addons\Addon>` of property `$addon`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
30
31	49	return parent::handle();
32		}
33
34		/**
35		* Process command line arguments
36		*
37		* @return bool
38		*/
39	60	protected function processArguments()
40		{
41	60	return true;
42		}
43
44		/**
45		* Option --addon specified.
46		*
47		* @return bool
48		*/
49	19	protected function onAddon()
50		{
51	19	return $this->option('addon') !== null;
		0 ignored issues – show Bug introduced 2016-08-26 16:45 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `option()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
52		}
53
54		/**
55		* Get addon.
56		*
57		* @return string
58		*/
59	69	protected function getAddon()
60		{
61	69	if ($addon = $this->option('addon')) {
62	43	$env = app(AddonEnvironment::class);
63
64	43	if (!$env->exists($addon)) {
65	17	throw new UnexpectedValueException("Addon '$addon' is not found.");
66		}
67
68	26	return $env->addon($addon);
69		} else {
70	26	return;
71		}
72		}
73
74		/**
75		* Get the application namespace.
76		*
77		* @return $string
78		*/
79	34	protected function getAppNamespace()
80		{
81	34	return trim($this->laravel->getNamespace(), '\\');
82		}
83
84		/**
85		* Get the addon namespace.
86		*
87		* @return $string
		0 ignored issues – show Documentation introduced 2017-09-19 07:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this The doc-type `$string` could not be parsed: Unknown type name "$string" at position 0. (view supported doc-types) This check marks PHPDoc comments that could not be parsed by our parser. To see which comment annotations we can parse, please refer to our documentation on supported doc-types. Loading history...
88		*/
89	24	protected function getAddonNamespace()
90		{
91	24	return $this->addon->phpNamespace();
92		}
93
94		/**
95		* Get the default namespace for the class.
96		*
97		* @return $string
98		*/
99	48	protected function getRootNamespace()
100		{
101	48	return $this->addon ? $this->getAddonNamespace() : $this->getAppNamespace();
102		}
103
104		/**
105		* Get the directory path for root namespace.
106		*
107		* @return string
108		*/
109	48	protected function getRootDirectory()
110		{
111	48	if ($this->addon) {
112	24	$directories = $this->addon->config('addon.directories');
113
114	24	if (! $directories) {
115	24	$directories = ['classes'];
116		}
117
118	24	return $this->addon->path($directories[0]);
119		}
120		else {
121	24	return parent::getRootDirectory();
122		}
123		}
124		}
125

jumilla / laravel-extension

Issues (53)

Security Analysis not enabled

sources/Generators/GeneratorCommandTrait.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like