Issues in RegisterController.php (master) - Issues in master - jumilla/laravel-addomnipot - Measure and Improve Code Quality continuously with Scrutinizer

Issues (181)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

classes/Controllers/RegisterController.php (2 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php


namespace {$namespace}\Controllers;


use Illuminate\Foundation\Auth\RegistersUsers;
use {$namespace}\User;

class RegisterController extends Controller
{
    /*
    |--------------------------------------------------------------------------
    | Register Controller
    |--------------------------------------------------------------------------
    |
    | This controller handles the registration of new users as well as their
    | validation and creation. By default this controller uses a trait to
    | provide this functionality without requiring any additional code.
    |
    */

    use RegistersUsers;

    /**
     * Where to redirect users after login / registration.
     *
     * @var string
     */
    protected $redirectTo;

    /**
     * Create a new controller instance.
     *
     * @return void
     */
    public function __construct()
    {
        $this->redirectTo = addon()->config('addon.routes.home', '/home');

        $this->middleware('guest');
    }

    /**
     * Show the application registration form.
     *
     * @return \Illuminate\Http\Response
     */
    public function showRegistrationForm()
    {
        return view('{$addon_name}::register');
    }

    /**
     * Get a validator for an incoming registration request.
     *
     * @param  array  $data
     * @return \Illuminate\Contracts\Validation\Validator
     */
    protected function validator(array $data)
    {
        return Validator::make($data, [
            'name' => 'required|max:255',
            'email' => 'required|email|max:255|unique:users',
            'password' => 'required|confirmed|min:6',
        ]);
    }

    /**
     * Create a new user instance after a valid registration.
     *
     * @return \{$namespace}\User
     * @param  array  $data
     */
    protected function create(array $data)
    {
        return User::create([
            'name' => $data['name'],
            'email' => $data['email'],
            'password' => bcrypt($data['password']),
        ]);
    }
}


1			<?php
			0 ignored issues – show Coding Style Compatibility introduced 2016-08-28 06:03 UTC by Report Bug Copy Issue Report Show Similar Issues like this For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 8 and the first side effect is on line 3. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2
3			namespace {$namespace}\Controllers;
			0 ignored issues – show Bug introduced 2015-12-27 01:46 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code did not parse for me. Apparently, there is an error somewhere around this line: Syntax error, unexpected '}' Loading history...
4
5			use Illuminate\Foundation\Auth\RegistersUsers;
6			use {$namespace}\User;
7
8			class RegisterController extends Controller
9			{
10			/*
11			\|--------------------------------------------------------------------------
12			\| Register Controller
13			\|--------------------------------------------------------------------------
14			\|
15			\| This controller handles the registration of new users as well as their
16			\| validation and creation. By default this controller uses a trait to
17			\| provide this functionality without requiring any additional code.
18			\|
19			*/
20
21			use RegistersUsers;
22
23			/**
24			* Where to redirect users after login / registration.
25			*
26			* @var string
27			*/
28			protected $redirectTo;
29
30			/**
31			* Create a new controller instance.
32			*
33			* @return void
34			*/
35			public function __construct()
36			{
37			$this->redirectTo = addon()->config('addon.routes.home', '/home');
38
39			$this->middleware('guest');
40			}
41
42			/**
43			* Show the application registration form.
44			*
45			* @return \Illuminate\Http\Response
46			*/
47			public function showRegistrationForm()
48			{
49			return view('{$addon_name}::register');
50			}
51
52			/**
53			* Get a validator for an incoming registration request.
54			*
55			* @param array $data
56			* @return \Illuminate\Contracts\Validation\Validator
57			*/
58			protected function validator(array $data)
59			{
60			return Validator::make($data, [
61			'name' => 'required\|max:255',
62			'email' => 'required\|email\|max:255\|unique:users',
63			'password' => 'required\|confirmed\|min:6',
64			]);
65			}
66
67			/**
68			* Create a new user instance after a valid registration.
69			*
70			* @return \{$namespace}\User
71			* @param array $data
72			*/
73			protected function create(array $data)
74			{
75			return User::create([
76			'name' => $data['name'],
77			'email' => $data['email'],
78			'password' => bcrypt($data['password']),
79			]);
80			}
81			}
82

jumilla / laravel-addomnipot

Issues (181)

Security Analysis no request data

classes/Controllers/RegisterController.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like