jumilla / laravel-addomnipot

sources/Commands/AddonMakeCommand.php

<?php

namespace Jumilla\Addomnipot\Laravel\Commands;

use Illuminate\Console\Command;
use Illuminate\Filesystem\Filesystem;
use Jumilla\Addomnipot\Laravel\Environment as AddonEnvironment;
use Jumilla\Addomnipot\Laravel\Generator as AddonGenerator;
use UnexpectedValueException;
use Exception;

/**
 * Modules console commands.
 *
 * @author Fumio Furukawa <fumio.furukawa@gmail.com>
 */
class AddonMakeCommand extends Command
{
    use Functions;
    use MakeCommandTrait;

    /**
     * The console command signature.
     *
     * @var string
     */
    protected $signature = 'make:addon
        {name : The name of the addon.}
        {skeleton? : Skeleton of addon.}
        {--space= : Addons space.}
        {--namespace= : PHP namespace of addon. Slash OK.}
        {--no-namespace : No PHP namespace.}
        {--language= : Languages, comma separated.}
        {--yes : No confirm.}
    ';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'Create a new addon directory';

    /**
     * @var array
     */
    protected $skeletons = [
        1 => 'minimum',
        2 => 'simple',
        3 => 'asset',
        4 => 'library',
        5 => 'api',
        6 => 'ui',
        11 => 'ui-sample',
        12 => 'debug',
        13 => 'generator',
        14 => 'laravel5',
        15 => 'laravel5-auth',
    ];

    /**
     * @var string
     */
    protected $default_skeleton = 'ui-sample';

    /**
     * Execute the console command.
     *
     * @param \Jumilla\Addomnipot\Laravel\Addons\AddonGenerator $generator
     *
     * @return mixed
     */
    public function handle(Filesystem $filesystem, AddonEnvironment $env, AddonGenerator $generator)
    {
        $addon_name = preg_replace('#(/+)#', '-', $this->argument('name'));

        // Check addon-directory
        if ($env->exists($addon_name)) {

It seems like $addon_name defined by preg_replace('#(/+)#', '-', $this->argument('name')) on line 75 can also be of type array<integer,string>; however, Jumilla\Addomnipot\Laravel\Environment::exists() does only seem to accept string, maybe add an additional type check?

            throw new UnexpectedValueException("addon directory '{$addon_name}' is already exists.");
        }

        $output_path = $env->spacePath($this->option('space'), $addon_name);

It seems like $this->option('space') targeting Illuminate\Console\Command::option() can also be of type array; however, Jumilla\Addomnipot\Laravel\Environment::spacePath() does only seem to accept string, maybe add an additional type check?

It seems like $addon_name defined by preg_replace('#(/+)#', '-', $this->argument('name')) on line 75 can also be of type array<integer,string>; however, Jumilla\Addomnipot\Laravel\Environment::spacePath() does only seem to accept string|null, maybe add an additional type check?

        // Adjust addon_name
        $addon_name = preg_replace('/[^\w_\-]/', '', $addon_name);

        $addon_class = preg_replace(
            ['/[^\w_]/', '/^(\d)/'],
            ['', '_$1'],
            studly_case($addon_name)

It seems like $addon_name defined by preg_replace('/[^\\w_\\-]/', '', $addon_name) on line 85 can also be of type array<integer,string>; however, studly_case() does only seem to accept string, maybe add an additional type check?

        );

        // namespace
        if ($this->option('no-namespace')) {
            $namespace = '';
        } else {
            if ($this->option('namespace')) {
                $namespace = str_replace('/', '\\', $this->option('namespace'));
            } else {
                $namespace = 'App\\'.$addon_class;
            }

            if (! $this->validPhpNamespace($namespace)) {
                throw new UnexpectedValueException("PHP namespace '{$namespace}' is invalid.");
            }
        }

        // languages
        $languages = $this->option('language') ? explode($this->option('language')) : [];

        // Show select prompt if not specified
        $skeleton = $this->chooseSkeleton($this->argument('skeleton'));

It seems like $this->argument('skeleton') targeting Illuminate\Console\Command::argument() can also be of type array; however, Jumilla\Addomnipot\Laravel\Commands\MakeCommandTrait::chooseSkeleton() does only seem to accept string, maybe add an additional type check?

        $properties = [
            'addon_name' => $addon_name,
            'addon_class' => $addon_class,
            'namespace' => $namespace,
            'languages' => array_unique(array_merge(['en', $this->laravel['config']->get('app.locale')], $languages)),
            'test_namespace' => 'Tests\\'.studly_case($addon_name),

It seems like $addon_name defined by preg_replace('/[^\\w_\\-]/', '', $addon_name) on line 85 can also be of type array<integer,string>; however, studly_case() does only seem to accept string, maybe add an additional type check?

        ];

        // confirm
        $this->line('Addon name: '.$properties['addon_name']);
        $this->line('PHP namespace: '.$properties['namespace']);
        $this->line('Skeleton: '.$skeleton);
        $this->line('Languages: '.implode(', ', $properties['languages']));

        if (!$this->option('yes') && !$this->confirm('generate ready? [Y/n]', true)) {

This code seems to be duplicated across your project.

            $this->comment('canceled');
            return;
        }

        try {
            $generator->generateAddon($output_path, str_replace(':', '-', $skeleton), $properties);
            $this->info('Addon Generated.');
        } catch (Exception $ex) {
            $filesystem->deleteDirectory($output_path);

            throw $ex;
        }
    }
}