OCA\AppOrder\Controller\SettingsController

Complexity

Total Complexity

7

Size/Duplication

Total Lines	89
Duplicated Lines	26.97 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

100%

Importance

Changes	4
Bugs	0	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	1
A	adminIndex()	12	12	1
A	personalIndex()	12	12	1
A	saveDefaultOrder()	0	6	2
A	getOrder()	0	4	1
A	savePersonal()	0	9	1

<?php
/**
 * @copyright Copyright (c) 2016 Julius Härtl <jus@bitgrid.net>
 *
 * @author Julius Härtl <jus@bitgrid.net>
 *
 * @license GNU AGPL version 3 or any later version
 *
 *  This program is free software: you can redistribute it and/or modify
 *  it under the terms of the GNU Affero General Public License as
 *  published by the Free Software Foundation, either version 3 of the
 *  License, or (at your option) any later version.
 *
 *  This program is distributed in the hope that it will be useful,
 *  but WITHOUT ANY WARRANTY; without even the implied warranty of
 *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 *  GNU Affero General Public License for more details.
 *
 *  You should have received a copy of the GNU Affero General Public License
 *  along with this program.  If not, see <http://www.gnu.org/licenses/>.
 *
 */

namespace OCA\AppOrder\Controller;

use \OCP\AppFramework\Controller;
use \OCP\AppFramework\Http\TemplateResponse;
use \OCP\IRequest;
use \OCP\INavigationManager;
use \OCA\AppOrder\Service\ConfigService;
use \OCA\AppOrder\Util;

class SettingsController extends Controller {

	private $userId;
	private $appConfig;
	private $navigationManager;
	private $util;

	public function __construct($appName, IRequest $request, ConfigService $appConfig, INavigationManager $urlGenerator, Util $util, $userId) {

This line exceeds maximum limit of 80 characters; contains 140 characters

		parent::__construct($appName, $request);
		$this->userId = $userId;
		$this->appConfig = $appConfig;
		$this->navigationManager = $urlGenerator;
		$this->util = $util;
	}

	/**
	 * Admin: render admin page
	 * FIXME: Move to dedicated class
	 *
	 * @return TemplateResponse
	 */
	public function adminIndex() {

This method seems to be duplicated in your project.

		// Private API call
		$navigation = $this->navigationManager->getAll();
		$order = json_decode($this->appConfig->getAppValue('order'));
		$nav = $this->util->matchOrder($navigation, $order);
		return new TemplateResponse(
			$this->appName,
			'admin',
			["nav" => $nav, 'type' => 'admin'],
			'blank'
		);
	}

	public function personalIndex() {

This method seems to be duplicated in your project.

		// Private API call
		$navigation = $this->navigationManager->getAll();
		$order = json_decode($this->appConfig->getUserValue('order', $this->userId));
		$nav = $this->util->matchOrder($navigation, $order);
		return new TemplateResponse(
			$this->appName,
			'admin',
			["nav" => $nav, 'type' => 'personal'],
			'blank'
		);
	}

	/**
	 * Admin: save default order
	 *
	 * @param $order
	 * @return array response
	 */
	public function saveDefaultOrder($order) {
		if (!is_null($order)) {
			$this->appConfig->setAppValue('order', $order);
		}
		return array('status' => 'success', 'order' => $order);
	}

	/**
	 * Return order for current user
	 *
	 * @NoAdminRequired
	 * @return array response
	 */
	public function getOrder() {
		$order = $this->util->getAppOrder();
		return array('status' => 'success', 'order' => $order);
	}

	/**
	 * Save order for current user
	 *
	 * @NoAdminRequired
	 * @param $order string
	 * @return array response
	 */
	public function savePersonal($order) {
		$this->appConfig->setUserValue('order', $this->userId, $order);
		$response = array(
			'status' => 'success',
			'data' => array('message' => 'User order saved successfully.'),
			'order' => $order
		);
		return $response;
	}

}