CondorcetException::__construct() - Code Metrics - Inspection of "Improve scrutinizer" - julien-boudry/Condorcet - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — master (73ca69)

by Boudry

created 2018-01-08 14:14 UTC

CondorcetException::__construct() A

↳ Parent: CondorcetException

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	6
ccs	0
cts	4
cp	0
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	3
nc	1
nop	2
crap	2

<?php
/*
    Condorcet PHP Class, with Schulze Methods and others !

    By Julien Boudry - MIT LICENSE (Please read LICENSE.txt)
    https://github.com/julien-boudry/Condorcet
*/
declare(strict_types=1);

namespace Condorcet;

use Condorcet\Condorcet;
use Condorcet\CondorcetVersion;

// Custom Exeption
class CondorcetException extends \Exception
{
    use CondorcetVersion;

    protected $_infos;

    public function __construct (int $code = 0, $infos = '')
    {
        $this->_infos = $infos;

        parent::__construct($this->correspondence($code), $code);
    }

    public function __toString () : string
    {
           return __CLASS__ . ": [{$this->code}]: {$this->message} (line: {$this->file}:{$this->line})\n";
    }

    protected function correspondence (int $code) : string
    {
        // Common
        $error[1] = 'Bad candidate format';
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $error[2] = 'The voting process has already started';
        $error[3] = 'This candidate ID is already registered';
        $error[4] = 'This candidate ID do not exist';
        $error[5] = 'Bad vote format | '.$this->_infos;
        $error[6] = 'You need to specify votes before results';
        $error[7] = 'Your Candidate ID is too long > ' . Election::MAX_LENGTH_CANDIDATE_ID;
        $error[8] = 'This method do not exist';
        $error[9] = 'The algo class you want has not been defined';
        $error[10] = 'The algo class you want is not correct';
        $error[11] = 'You try to unserialize an object version older than your actual Class version. This is a problematic thing';
        $error[12] = 'You have exceeded the number of votes allowed for this method.';
        $error[13] = 'Formatting error: You must specify an integer';
        $error[14] = 'parseVote() must take a string (raw or path) as argument';
        $error[15] = 'Input must be valid Json format';
        $error[16] = 'You have exceeded the maximum number of votes allowed per election ('.$this->_infos.').';
        $error[17] = 'Bad tags input format';
        $error[18] = 'New vote can\'t match Candidate of his elections';
        $error[19] = 'This name is not allowed in because of a namesake in the election in which the object participates.';
        $error[20] = 'You need to specify one or more candidates before voting';
        $error[21] = 'Bad vote timestamp format';
        $error[22] = 'This context is not valid';
        $error[23] = 'No Data Handler in use';
        $error[24] = 'A Data Handler is already in use';
        $error[25] = 'Algo class try to use existing alias';
        $error[26] = 'Weight can not be < 1';

        $error[30] = 'Candidate not in Ranking';


        // DataManager
        $error[30] = 'This entity does not exist.';

        // Algorithms
        if ($code === 101) :
            $error[101] = $this->_infos;
        endif;
        $error[102] = 'Marquis of Condorcet algortihm can\'t provide a full ranking. But only Winner and Loser.';


        if ( array_key_exists($code, $error) ) :
            return $error[$code];
        else :
            return (!is_null($this->_infos)) ? $this->_infos : 'Mysterious Error';
        endif;
    }
}


1			<?php
2			/*
3			Condorcet PHP Class, with Schulze Methods and others !
4
5			By Julien Boudry - MIT LICENSE (Please read LICENSE.txt)
6			https://github.com/julien-boudry/Condorcet
7			*/
8			declare(strict_types=1);
9
10			namespace Condorcet;
11
12			use Condorcet\Condorcet;
13			use Condorcet\CondorcetVersion;
14
15			// Custom Exeption
16			class CondorcetException extends \Exception
17			{
18			use CondorcetVersion;
19
20			protected $_infos;
21
22			public function __construct (int $code = 0, $infos = '')
23			{
24			$this->_infos = $infos;
25
26			parent::__construct($this->correspondence($code), $code);
27			}
28
29			public function __toString () : string
30			{
31			return __CLASS__ . ": [{$this->code}]: {$this->message} (line: {$this->file}:{$this->line})\n";
32			}
33
34			protected function correspondence (int $code) : string
35			{
36			// Common
37			$error[1] = 'Bad candidate format';
			0 ignored issues – show Coding Style Comprehensibility introduced 2018-01-08 14:18 UTC by Report Bug Copy Issue Report `$error` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$error = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
38			$error[2] = 'The voting process has already started';
39			$error[3] = 'This candidate ID is already registered';
40			$error[4] = 'This candidate ID do not exist';
41			$error[5] = 'Bad vote format \| '.$this->_infos;
42			$error[6] = 'You need to specify votes before results';
43			$error[7] = 'Your Candidate ID is too long > ' . Election::MAX_LENGTH_CANDIDATE_ID;
44			$error[8] = 'This method do not exist';
45			$error[9] = 'The algo class you want has not been defined';
46			$error[10] = 'The algo class you want is not correct';
47			$error[11] = 'You try to unserialize an object version older than your actual Class version. This is a problematic thing';
48			$error[12] = 'You have exceeded the number of votes allowed for this method.';
49			$error[13] = 'Formatting error: You must specify an integer';
50			$error[14] = 'parseVote() must take a string (raw or path) as argument';
51			$error[15] = 'Input must be valid Json format';
52			$error[16] = 'You have exceeded the maximum number of votes allowed per election ('.$this->_infos.').';
53			$error[17] = 'Bad tags input format';
54			$error[18] = 'New vote can\'t match Candidate of his elections';
55			$error[19] = 'This name is not allowed in because of a namesake in the election in which the object participates.';
56			$error[20] = 'You need to specify one or more candidates before voting';
57			$error[21] = 'Bad vote timestamp format';
58			$error[22] = 'This context is not valid';
59			$error[23] = 'No Data Handler in use';
60			$error[24] = 'A Data Handler is already in use';
61			$error[25] = 'Algo class try to use existing alias';
62			$error[26] = 'Weight can not be < 1';
63
64			$error[30] = 'Candidate not in Ranking';
65
66
67			// DataManager
68			$error[30] = 'This entity does not exist.';
69
70			// Algorithms
71			if ($code === 101) :
72			$error[101] = $this->_infos;
73			endif;
74			$error[102] = 'Marquis of Condorcet algortihm can\'t provide a full ranking. But only Winner and Loser.';
75
76
77			if ( array_key_exists($code, $error) ) :
78			return $error[$code];
79			else :
80			return (!is_null($this->_infos)) ? $this->_infos : 'Mysterious Error';
81			endif;
82			}
83			}
84

julien-boudry / Condorcet

Branch — master (73ca69)

CondorcetException::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like