Issues in DeviceControllerTest.php - Fixed Issues - Inspection of "test array count" - juliangut/tify_example - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e46808...b698dc )

by Julián

created 2016-05-21 18:21 UTC

tests/Pusher/Controller/DeviceControllerTest.php (8 issues)

Labels

Deprecated Code 8

Severity

Minor 8

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * Push notification server example (http://github.com/juliangut/tify_example)
 *
 * @link https://github.com/juliangut/tify_example for the canonical source repository
 *
 * @license https://github.com/juliangut/tify_example/blob/master/LICENSE
 */

namespace Jgut\Pusher\Tests\Entity;

use Jgut\Pusher\Controller\DeviceController;
use Jgut\Pusher\Entity\DeviceEntity;
use Jgut\Pusher\Repository\DeviceRepository;
use Psr\Http\Message\ServerRequestInterface;
use Ramsey\Uuid\Uuid;
use Slim\Http\Response;

/**
 * Class DeviceControllerTest
 */
class DeviceControllerTest extends \PHPUnit_Framework_TestCase
{
    public function testSave()
    {
        $repository = $this->getMock(DeviceRepository::class, [], [], '', false);

        $repository->expects(self::once())->method('findOneBy')->will(self::returnValue(null));
        $repository->expects(self::once())->method('saveDevice');

        $parameters = [
            'token' => 'aaaa',
            'platform' => 'android',
        ];

        $request = $this->getMock(ServerRequestInterface::class, [], [], '', false);

        $request->expects(self::once())->method('getParsedBody')->will(self::returnValue($parameters));

        $controller = new DeviceController($repository);

        /** @var Response $response */
        $response = $controller->save($request, new Response());

        self::assertEquals(
            json_encode(['uuid' => null, 'token' => 'aaaa', 'platform' => 'android']),
            (string) $response->getBody()
        );
    }

    public function testNotSave()
    {
        $uuid = Uuid::uuid4();
        $device = (new DeviceEntity())
            ->setUuid($uuid)
            ->setToken('bbbb')
            ->setPlatform('ios');

        $repository = $this->getMock(DeviceRepository::class, [], [], '', false);

        $repository->expects(self::once())->method('findOneBy')->will(self::returnValue($device));

        $parameters = [
            'token' => 'bbbb',
            'platform' => 'ios',
        ];

        $request = $this->getMock(ServerRequestInterface::class, [], [], '', false);

        $request->expects(self::once())->method('getParsedBody')->will(self::returnValue($parameters));

        $controller = new DeviceController($repository);

        /** @var Response $response */
        $response = $controller->save($request, new Response());

        self::assertEquals(
            json_encode(['uuid' => (string) $uuid, 'token' => 'bbbb', 'platform' => 'ios']),
            (string) $response->getBody()
        );
    }

    public function testUpdate()
    {
        $uuid = Uuid::uuid4();
        $device = (new DeviceEntity())
            ->setUuid($uuid)
            ->setToken('bbbb')
            ->setPlatform('ios');

        $repository = $this->getMock(DeviceRepository::class, [], [], '', false);

        $repository->expects(self::once())->method('findOneBy')->will(self::returnValue($device));
        $repository->expects(self::once())->method('saveDevice');

        $parameters = [
            'token' => 'cccc',
            'previous_token' => 'bbbb',
        ];

        $request = $this->getMock(ServerRequestInterface::class, [], [], '', false);

        $request->expects(self::once())->method('getParsedBody')->will(self::returnValue($parameters));

        $controller = new DeviceController($repository);

        /** @var Response $response */
        $response = $controller->update($request, new Response());

        self::assertEquals(
            json_encode(['uuid' => (string) $uuid, 'token' => 'cccc', 'platform' => 'ios']),
            (string) $response->getBody()
        );
    }

    /**
     * @expectedException \RuntimeException
     */
    public function testNoDeviceUpdate()
    {
        $repository = $this->getMock(DeviceRepository::class, [], [], '', false);

        $repository->expects(self::once())->method('findOneBy')->will(self::returnValue(null));

        $parameters = [
            'token' => 'cccc',
            'previous_token' => 'bbbb',
        ];

        $request = $this->getMock(ServerRequestInterface::class, [], [], '', false);

        $request->expects(self::once())->method('getParsedBody')->will(self::returnValue($parameters));

        $controller = new DeviceController($repository);

        $controller->update($request, new Response());
    }
}


1			<?php
2			/**
3			* Push notification server example (http://github.com/juliangut/tify_example)
4			*
5			* @link https://github.com/juliangut/tify_example for the canonical source repository
6			*
7			* @license https://github.com/juliangut/tify_example/blob/master/LICENSE
8			*/
9
10			namespace Jgut\Pusher\Tests\Entity;
11
12			use Jgut\Pusher\Controller\DeviceController;
13			use Jgut\Pusher\Entity\DeviceEntity;
14			use Jgut\Pusher\Repository\DeviceRepository;
15			use Psr\Http\Message\ServerRequestInterface;
16			use Ramsey\Uuid\Uuid;
17			use Slim\Http\Response;
18
19			/**
20			* Class DeviceControllerTest
21			*/
22			class DeviceControllerTest extends \PHPUnit_Framework_TestCase
23			{
24			public function testSave()
25			{
26			$repository = $this->getMock(DeviceRepository::class, [], [], '', false);
			0 ignored issues – show Deprecated Code introduced 2016-05-21 17:56 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `PHPUnit_Framework_TestCase::getMock()` has been deprecated with message: Method deprecated since Release 5.4.0 This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
27			$repository->expects(self::once())->method('findOneBy')->will(self::returnValue(null));
28			$repository->expects(self::once())->method('saveDevice');
29
30			$parameters = [
31			'token' => 'aaaa',
32			'platform' => 'android',
33			];
34
35			$request = $this->getMock(ServerRequestInterface::class, [], [], '', false);
			0 ignored issues – show Deprecated Code introduced 2016-05-21 17:56 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `PHPUnit_Framework_TestCase::getMock()` has been deprecated with message: Method deprecated since Release 5.4.0 This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
36			$request->expects(self::once())->method('getParsedBody')->will(self::returnValue($parameters));
37
38			$controller = new DeviceController($repository);
39
40			/** @var Response $response */
41			$response = $controller->save($request, new Response());
42
43			self::assertEquals(
44			json_encode(['uuid' => null, 'token' => 'aaaa', 'platform' => 'android']),
45			(string) $response->getBody()
46			);
47			}
48
49			public function testNotSave()
50			{
51			$uuid = Uuid::uuid4();
52			$device = (new DeviceEntity())
53			->setUuid($uuid)
54			->setToken('bbbb')
55			->setPlatform('ios');
56
57			$repository = $this->getMock(DeviceRepository::class, [], [], '', false);
			0 ignored issues – show Deprecated Code introduced 2016-05-21 18:16 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `PHPUnit_Framework_TestCase::getMock()` has been deprecated with message: Method deprecated since Release 5.4.0 This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
58			$repository->expects(self::once())->method('findOneBy')->will(self::returnValue($device));
59
60			$parameters = [
61			'token' => 'bbbb',
62			'platform' => 'ios',
63			];
64
65			$request = $this->getMock(ServerRequestInterface::class, [], [], '', false);
			0 ignored issues – show Deprecated Code introduced 2016-05-21 18:16 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `PHPUnit_Framework_TestCase::getMock()` has been deprecated with message: Method deprecated since Release 5.4.0 This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
66			$request->expects(self::once())->method('getParsedBody')->will(self::returnValue($parameters));
67
68			$controller = new DeviceController($repository);
69
70			/** @var Response $response */
71			$response = $controller->save($request, new Response());
72
73			self::assertEquals(
74			json_encode(['uuid' => (string) $uuid, 'token' => 'bbbb', 'platform' => 'ios']),
75			(string) $response->getBody()
76			);
77			}
78
79			public function testUpdate()
80			{
81			$uuid = Uuid::uuid4();
82			$device = (new DeviceEntity())
83			->setUuid($uuid)
84			->setToken('bbbb')
85			->setPlatform('ios');
86
87			$repository = $this->getMock(DeviceRepository::class, [], [], '', false);
			0 ignored issues – show Deprecated Code introduced 2016-05-21 17:56 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `PHPUnit_Framework_TestCase::getMock()` has been deprecated with message: Method deprecated since Release 5.4.0 This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
88			$repository->expects(self::once())->method('findOneBy')->will(self::returnValue($device));
89			$repository->expects(self::once())->method('saveDevice');
90
91			$parameters = [
92			'token' => 'cccc',
93			'previous_token' => 'bbbb',
94			];
95
96			$request = $this->getMock(ServerRequestInterface::class, [], [], '', false);
			0 ignored issues – show Deprecated Code introduced 2016-05-21 17:56 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `PHPUnit_Framework_TestCase::getMock()` has been deprecated with message: Method deprecated since Release 5.4.0 This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
97			$request->expects(self::once())->method('getParsedBody')->will(self::returnValue($parameters));
98
99			$controller = new DeviceController($repository);
100
101			/** @var Response $response */
102			$response = $controller->update($request, new Response());
103
104			self::assertEquals(
105			json_encode(['uuid' => (string) $uuid, 'token' => 'cccc', 'platform' => 'ios']),
106			(string) $response->getBody()
107			);
108			}
109
110			/**
111			* @expectedException \RuntimeException
112			*/
113			public function testNoDeviceUpdate()
114			{
115			$repository = $this->getMock(DeviceRepository::class, [], [], '', false);
			0 ignored issues – show Deprecated Code introduced 2016-05-21 17:56 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `PHPUnit_Framework_TestCase::getMock()` has been deprecated with message: Method deprecated since Release 5.4.0 This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
116			$repository->expects(self::once())->method('findOneBy')->will(self::returnValue(null));
117
118			$parameters = [
119			'token' => 'cccc',
120			'previous_token' => 'bbbb',
121			];
122
123			$request = $this->getMock(ServerRequestInterface::class, [], [], '', false);
			0 ignored issues – show Deprecated Code introduced 2016-05-21 17:56 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `PHPUnit_Framework_TestCase::getMock()` has been deprecated with message: Method deprecated since Release 5.4.0 This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
124			$request->expects(self::once())->method('getParsedBody')->will(self::returnValue($parameters));
125
126			$controller = new DeviceController($repository);
127
128			$controller->update($request, new Response());
129			}
130			}
131

juliangut / tify_example

Push — master ( e46808...b698dc )

tests/Pusher/Controller/DeviceControllerTest.php (8 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like