ShowProjectsCommand::execute() - Code Metrics - Inspection of "Test of ShowProjectsCommand" - juanber84/dep - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 3c95a1...ec9ebd )

by juan

created 2016-05-23 13:58 UTC

ShowProjectsCommand::execute() A

↳ Parent: ShowProjectsCommand

Complexity

Conditions	4
Paths	3

Size

Total Lines	20
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Importance

Changes	3
Bugs	0	Features	0

Metric	Value
cc	4
eloc	14
c	3
b	0
f	0
nc	3
nop	2
dl	0
loc	20
rs	9.2

<?php

namespace Juanber84\Console\Command;

use Juanber84\Services\DatabaseService;
use Juanber84\Texts\ShowProjectsCommandText;
use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Console\Helper\Table;

class ShowProjectsCommand extends Command
{
    const COMMAND_NAME = 'show-projects';
    const COMMAND_DESC = 'List Deploy Projects.';

    private $databaseService;

    public function __construct(DatabaseService $databaseService)
    {
        parent::__construct();

        $this->databaseService = $databaseService;
    }

    protected function configure()
    {
        $this
            ->setName(self::COMMAND_NAME)
            ->setDescription(self::COMMAND_DESC);
    }

    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $jsonDb = $this->databaseService->getProjects();
        if (is_null($jsonDb) || count($jsonDb) == 0) {
            $output->writeln('');
            $output->writeln('<info>'.ShowProjectsCommandText::OK_0_PROJECTS.'</info>');
        } else {
            $tableData = [];
            foreach ($jsonDb as $k =>$v) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
                $tableData[] = [$k,$v];
            }

            $table = new Table($output);
            $table
                ->setHeaders(array('Name', 'Path'))
                ->setRows($tableData)
            ;
            $table->render();
        }
    }
}

1			<?php
2
3			namespace Juanber84\Console\Command;
4
5			use Juanber84\Services\DatabaseService;
6			use Juanber84\Texts\ShowProjectsCommandText;
7			use Symfony\Component\Console\Command\Command;
8			use Symfony\Component\Console\Input\InputInterface;
9			use Symfony\Component\Console\Output\OutputInterface;
10			use Symfony\Component\Console\Helper\Table;
11
12			class ShowProjectsCommand extends Command
13			{
14			const COMMAND_NAME = 'show-projects';
15			const COMMAND_DESC = 'List Deploy Projects.';
16
17			private $databaseService;
18
19			public function __construct(DatabaseService $databaseService)
20			{
21			parent::__construct();
22
23			$this->databaseService = $databaseService;
24			}
25
26			protected function configure()
27			{
28			$this
29			->setName(self::COMMAND_NAME)
30			->setDescription(self::COMMAND_DESC);
31			}
32
33			protected function execute(InputInterface $input, OutputInterface $output)
34			{
35			$jsonDb = $this->databaseService->getProjects();
36			if (is_null($jsonDb) \|\| count($jsonDb) == 0) {
37			$output->writeln('');
38			$output->writeln('<info>'.ShowProjectsCommandText::OK_0_PROJECTS.'</info>');
39			} else {
40			$tableData = [];
41			foreach ($jsonDb as $k =>$v) {
			0 ignored issues – show Bug introduced 2016-05-23 11:15 UTC by Report Bug Copy Issue Report The expression `$jsonDb` of type `object\|integer\|double\|string\|array\|boolean` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
42			$tableData[] = [$k,$v];
43			}
44
45			$table = new Table($output);
46			$table
47			->setHeaders(array('Name', 'Path'))
48			->setRows($tableData)
49			;
50			$table->render();
51			}
52			}
53			}

juanber84 / dep

Push — master ( 3c95a1...ec9ebd )

ShowProjectsCommand::execute() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like