DeployProjectsCommand::execute() - Code Metrics - Inspection of "Table fix" - juanber84/dep - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 0aabb4...e32f5b )

by juan

created 2016-05-25 07:51 UTC

DeployProjectsCommand::execute() F

↳ Parent: DeployProjectsCommand

Complexity

Conditions	17
Paths	308

Size

Total Lines	109
Code Lines	79

Duplication

Lines	6
Ratio	5.5 %

Importance

Changes	5
Bugs	1	Features	0

Metric	Value
cc	17
eloc	79
c	5
b	1
f	0
nc	308
nop	2
dl	6
loc	109
rs	3.6909

How to fix Long Method Complexity

<?php

namespace Juanber84\Console\Command;

use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Console\Question\Question;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Helper\ProgressBar;
use Symfony\Component\Console\Helper\Table;

class DeployProjectsCommand extends Command
{

    const DEVELOP = 'develop';
    const STAGING = 'staging';
    const QUALITY = 'quality';
    const MASTER  = 'master';

    const DIRECTORY = '.dep';
    const DB = 'db.json';

    protected function configure()
    {
        $this
            ->setName('deploy-project')
            ->setDescription('Auto Deploy Project')
            ->addArgument(
                'project',
                InputArgument::OPTIONAL,
                'What\'s the name of project?'
            )
            ->addArgument(
                'branch',
                InputArgument::OPTIONAL,
                'What\'s the name of branch?'
            );
    }

    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $hieranchy = [self::DEVELOP, self::STAGING, self::QUALITY, self::MASTER];
        $validBranchs = [self::STAGING, self::QUALITY, self::MASTER];
        $nameOfProject = $input->getArgument('project');
        $branchOfProject = $input->getArgument('branch');
        $helper = $this->getHelper('question');

        if (!$nameOfProject) {

            $question = new Question('<question>What is the project key?</question>: ');
            do {
                $nameOfProject = trim($helper->ask($input, $output, $question));
            } while (empty($nameOfProject));
        }

        if (!$branchOfProject) {
            $question = new Question('<question>What is the branch to deploy?</question>: ');
            do {
                $branchOfProject = trim($helper->ask($input, $output, $question));
            } while (empty($branchOfProject) || !in_array($branchOfProject, $validBranchs));
        }

        $db = file_get_contents(getenv("HOME").'/'.self::DIRECTORY.'/'.self::DB);
        $jsonDb = json_decode($db,true);

        if (is_null($jsonDb)) {
            $output->writeln('');
            $output->writeln('<info>0 projects configurated</info>');
        } else {
            if (isset($jsonDb[$nameOfProject])) {
                $merge = self::DEVELOP;
                $final = self::STAGING;
                foreach ($hieranchy as $k => $v) {
                    if ($v == $branchOfProject) {
                        $merge = $hieranchy[$k-1];
                        $final = $v;
                    }
                }

                chdir($jsonDb[$nameOfProject]);

                $pipetask = [
                    'git checkout ' .$merge,
                    'git pull',
                    'git checkout ' .$final,
                    'git merge '.$merge,
                    'git push --progress 2>&1',
                    'git checkout develop',
                ];

                $progressBar = new ProgressBar($output, count($pipetask));
                $progressBar->setBarCharacter('<fg=magenta>=</>');
                $progressBar->setFormat("%message%\n %current%/%max% [%bar%] %percent:3s%%");
                //$progressBar->setFormat('verbose');

                $progressBar->setBarWidth(50);

                $table = new Table($output);
                $table->setHeaders(array('<fg=white>Command</>', '<fg=white>Result</>'));

                $exitCode = 0;
                foreach ($pipetask as $t){
                    if ($exitCode == 0){
                        $command = new \mikehaertl\shellcommand\Command($t);
                        if ($command->execute()) {
                            $message = $command->getOutput();
                            $message = trim(preg_replace('/\t+/', '', $message));
                            $message = trim(preg_replace('/Ma\n+/', '', $message));
                            $message = trim(preg_replace('/a\n+/', '', $message));
                            $exitCode = $command->getExitCode();
                        } else {
                            $message = $command->getError();
                            $message = trim(preg_replace('/\t+/', '', $message));
                            $message = trim(preg_replace('/Ma\n+/', '', $message));
                            $message = trim(preg_replace('/a\n+/', '', $message));
                            $exitCode = $command->getExitCode();
                        }
                    } else {
                        $message = '';
                        $exitCode = -1;
                    }

                    if ($exitCode == 0){
                        $exitCodeMessage = '<fg=green>SUCCESS</>';
                    } elseif ($exitCode == 1){
                        $exitCodeMessage = '<fg=red>FAILED</>';
                    } elseif ($exitCode == -1){
                        $exitCodeMessage = '<fg=blue>ABORTED</>';
                    }

                    $command = '<fg=magenta>'.$t.'</>';
                    if (strlen(trim($message))>0){
                        $command .= $command."\n".$message;
                    }
                    $table->addRow([$command, $exitCodeMessage]);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
                    usleep(300000);
                    $progressBar->setMessage($t);
                    $progressBar->advance();
                }
                $progressBar->setMessage("");

                $progressBar->finish();

                $output->writeln('');
                $table->render();
            }

        }

    }
}

1		<?php
2
3		namespace Juanber84\Console\Command;
4
5		use Symfony\Component\Console\Command\Command;
6		use Symfony\Component\Console\Input\InputInterface;
7		use Symfony\Component\Console\Output\OutputInterface;
8		use Symfony\Component\Console\Question\Question;
9		use Symfony\Component\Console\Input\InputArgument;
10		use Symfony\Component\Console\Helper\ProgressBar;
11		use Symfony\Component\Console\Helper\Table;
12
13		class DeployProjectsCommand extends Command
14		{
15
16		const DEVELOP = 'develop';
17		const STAGING = 'staging';
18		const QUALITY = 'quality';
19		const MASTER = 'master';
20
21		const DIRECTORY = '.dep';
22		const DB = 'db.json';
23
24		protected function configure()
25		{
26		$this
27		->setName('deploy-project')
28		->setDescription('Auto Deploy Project')
29		->addArgument(
30		'project',
31		InputArgument::OPTIONAL,
32		'What\'s the name of project?'
33		)
34		->addArgument(
35		'branch',
36		InputArgument::OPTIONAL,
37		'What\'s the name of branch?'
38		);
39		}
40
41		protected function execute(InputInterface $input, OutputInterface $output)
42		{
43		$hieranchy = [self::DEVELOP, self::STAGING, self::QUALITY, self::MASTER];
44		$validBranchs = [self::STAGING, self::QUALITY, self::MASTER];
45		$nameOfProject = $input->getArgument('project');
46		$branchOfProject = $input->getArgument('branch');
47		$helper = $this->getHelper('question');
48
49	View Code Duplication	if (!$nameOfProject) {
		0 ignored issues – show Duplication introduced 2016-05-23 17:16 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
50		$question = new Question('<question>What is the project key?</question>: ');
51		do {
52		$nameOfProject = trim($helper->ask($input, $output, $question));
53		} while (empty($nameOfProject));
54		}
55
56		if (!$branchOfProject) {
57		$question = new Question('<question>What is the branch to deploy?</question>: ');
58		do {
59		$branchOfProject = trim($helper->ask($input, $output, $question));
60		} while (empty($branchOfProject) \|\| !in_array($branchOfProject, $validBranchs));
61		}
62
63		$db = file_get_contents(getenv("HOME").'/'.self::DIRECTORY.'/'.self::DB);
64		$jsonDb = json_decode($db,true);
65
66		if (is_null($jsonDb)) {
67		$output->writeln('');
68		$output->writeln('<info>0 projects configurated</info>');
69		} else {
70		if (isset($jsonDb[$nameOfProject])) {
71		$merge = self::DEVELOP;
72		$final = self::STAGING;
73		foreach ($hieranchy as $k => $v) {
74		if ($v == $branchOfProject) {
75		$merge = $hieranchy[$k-1];
76		$final = $v;
77		}
78		}
79
80		chdir($jsonDb[$nameOfProject]);
81
82		$pipetask = [
83		'git checkout ' .$merge,
84		'git pull',
85		'git checkout ' .$final,
86		'git merge '.$merge,
87		'git push --progress 2>&1',
88		'git checkout develop',
89		];
90
91		$progressBar = new ProgressBar($output, count($pipetask));
92		$progressBar->setBarCharacter('<fg=magenta>=</>');
93		$progressBar->setFormat("%message%\n %current%/%max% [%bar%] %percent:3s%%");
94		//$progressBar->setFormat('verbose');
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-05-24 14:11 UTC by Report Bug Copy Issue Report `86%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
95		$progressBar->setBarWidth(50);
96
97		$table = new Table($output);
98		$table->setHeaders(array('<fg=white>Command</>', '<fg=white>Result</>'));
99
100		$exitCode = 0;
101		foreach ($pipetask as $t){
102		if ($exitCode == 0){
103		$command = new \mikehaertl\shellcommand\Command($t);
104		if ($command->execute()) {
105		$message = $command->getOutput();
106		$message = trim(preg_replace('/\t+/', '', $message));
107		$message = trim(preg_replace('/Ma\n+/', '', $message));
108		$message = trim(preg_replace('/a\n+/', '', $message));
109		$exitCode = $command->getExitCode();
110		} else {
111		$message = $command->getError();
112		$message = trim(preg_replace('/\t+/', '', $message));
113		$message = trim(preg_replace('/Ma\n+/', '', $message));
114		$message = trim(preg_replace('/a\n+/', '', $message));
115		$exitCode = $command->getExitCode();
116		}
117		} else {
118		$message = '';
119		$exitCode = -1;
120		}
121
122		if ($exitCode == 0){
123		$exitCodeMessage = '<fg=green>SUCCESS</>';
124		} elseif ($exitCode == 1){
125		$exitCodeMessage = '<fg=red>FAILED</>';
126		} elseif ($exitCode == -1){
127		$exitCodeMessage = '<fg=blue>ABORTED</>';
128		}
129
130		$command = '<fg=magenta>'.$t.'</>';
131		if (strlen(trim($message))>0){
132		$command .= $command."\n".$message;
133		}
134		$table->addRow([$command, $exitCodeMessage]);
		0 ignored issues – show Bug introduced 2016-05-25 07:50 UTC by Report Bug Copy Issue Report The variable `$exitCodeMessage` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
135		usleep(300000);
136		$progressBar->setMessage($t);
137		$progressBar->advance();
138		}
139		$progressBar->setMessage("");
140
141		$progressBar->finish();
142
143		$output->writeln('');
144		$table->render();
145		}
146
147		}
148
149		}
150		}

juanber84 / dep

Push — master ( 0aabb4...e32f5b )

DeployProjectsCommand::execute() F

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Available Fixes

Duplication Side-by-Side

Filter issues like