ZendSessionProcessor::__construct() - Code Metrics - Inspection of "More cleanup." - jschreuder/Middle - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( b3f945...fcf496 )

by Jelmer

created 2017-01-09 17:45 UTC

ZendSessionProcessor::__construct() A

↳ Parent: ZendSessionProcessor

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	4
ccs	3
cts	3
cp	1
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	1
crap	1

<?php declare(strict_types = 1);

namespace jschreuder\Middle\Session;

use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\ServerRequestInterface;
use Zend\Session\Config\ConfigInterface;
use Zend\Session\Container;
use Zend\Session\SessionManager;

class ZendSessionProcessor implements SessionProcessorInterface
{
    /** @var  int */
    private $zendSessionConfig;

    public function __construct(ConfigInterface $zendSessionConfig)
    {
        $this->zendSessionConfig = $zendSessionConfig;

    }

    public function processRequest(ServerRequestInterface $request): ServerRequestInterface
    {
        $sessionManager = new SessionManager($this->zendSessionConfig);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $container = new Container(str_replace('.', '_', $request->getUri()->getHost()), $sessionManager);

        $session = new ZendSession($sessionManager, $container);
        return $request->withAttribute('session', $session);
    }

    public function processResponse(ServerRequestInterface $request, ResponseInterface $response): ResponseInterface
    {
        return $response;
    }
}


1		<?php declare(strict_types = 1);
2
3		namespace jschreuder\Middle\Session;
4
5		use Psr\Http\Message\ResponseInterface;
6		use Psr\Http\Message\ServerRequestInterface;
7		use Zend\Session\Config\ConfigInterface;
8		use Zend\Session\Container;
9		use Zend\Session\SessionManager;
10
11		class ZendSessionProcessor implements SessionProcessorInterface
12		{
13		/** @var int */
14		private $zendSessionConfig;
15
16	3	public function __construct(ConfigInterface $zendSessionConfig)
17		{
18	3	$this->zendSessionConfig = $zendSessionConfig;
		0 ignored issues – show Documentation Bug introduced 2017-01-09 17:49 UTC by Report Bug Copy Issue Report It seems like `$zendSessionConfig` of type `object<Zend\Session\Config\ConfigInterface>` is incompatible with the declared type `integer` of property `$zendSessionConfig`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
19	3	}
20
21	1	public function processRequest(ServerRequestInterface $request): ServerRequestInterface
22		{
23	1	$sessionManager = new SessionManager($this->zendSessionConfig);
		0 ignored issues – show Documentation introduced 2017-01-09 17:49 UTC by Report Bug Copy Issue Report `$this->zendSessionConfig` is of type `integer`, but the function expects a `null\|object<Zend\Session\Config\ConfigInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
24	1	$container = new Container(str_replace('.', '_', $request->getUri()->getHost()), $sessionManager);
25
26	1	$session = new ZendSession($sessionManager, $container);
27	1	return $request->withAttribute('session', $session);
28		}
29
30	1	public function processResponse(ServerRequestInterface $request, ResponseInterface $response): ResponseInterface
31		{
32	1	return $response;
33		}
34		}
35

jschreuder / Middle

Push — master ( b3f945...fcf496 )

ZendSessionProcessor::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like