MySQL - Code Metrics - Inspection of "Fixing compatibility issues." - jrobinsonc/mysql - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c0b5fe...7658de )

by Jose

created 2017-06-29 02:21 UTC

MySQL C

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	315
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	1

Importance

Changes

Metric	Value
wmc	59
lcom	2
cbo	1
dl	0
loc	315
rs	6.1904
c	0
b	0
f	0

12 Methods

Rating	Name	Size	Complexity
B	__construct()	17	7
D	connect()	36	10
A	error()	12	3
B	query()	23	5
A	insert()	20	3
A	escape()	8	3
B	parseWhere()	26	4
B	update()	32	6
B	delete()	24	5
D	select()	36	9
A	table()	8	2
A	__destruct()	8	2

How to fix Complexity

<?php
namespace jrdev;

class MySQL extends \MySQLi
{
    private $dbConfig = array();

    private $connected = false;

    private $lastError = '';

    private $tables = [];

    public function __construct(
        $host = null,
        $username = null,
        $password = null,
        $dbname = null,
        $port = null,
        $socket = null
    ) {
        $this->dbConfig = [
            'host' => $host ?: ini_get("mysqli.default_host"),
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            'username' => $username ?: ini_get("mysqli.default_user"),
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            'password' => $password ?: ini_get("mysqli.default_pw"),
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            'dbname' => $dbname ?: '',
            'port' => $port ?: ini_get("mysqli.default_port"),
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            'socket' => $socket ?: ini_get("mysqli.default_socket")
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        ];
    }

    public function connect(
        $host = null,
        $username = null,
        $password = null,
        $dbname = null,
        $port = null,
        $socket = null
    ) {
        if (true === $this->connected) {
            return true;
        }

        parent::__construct(
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            $host ?: $this->dbConfig['host'],
            $username ?: $this->dbConfig['username'],
            $password ?: $this->dbConfig['password'],
            $dbname ?: $this->dbConfig['dbname'],
            $port ?: $this->dbConfig['port'],
            $socket ?: $this->dbConfig['socket']
        );

        if ($this->connect_error) {
            $this->error('MySQL Error: ' . $this->connect_errno . ' ' . $this->connect_error, true);

            return false;
        }

        // It's necessary for real_escape_string.
        if (false === $this->set_charset('utf8')) {
            $this->error('Error loading character set utf8: ' . $this->error);

            return false;
        }

        return $this->connected = true;
    }

    public function error($str = '', $fatal = false)
    {
        if ('' === $str) {
            return $this->lastError;
        } else {
            if (true === $fatal) {
                throw new \Exception($str);
            } else {
                $this->lastError = $str;
            }
        }
    }

    /**
     * Performs a generic query
     *
     * @param string $sql
     * @return MySQL\Result|false
     */
    public function query($sql, $resultMode = MYSQLI_STORE_RESULT)
    {
        if (false === $this->connect()) {
            return false;
        }

        switch ($resultMode) {
            case MYSQLI_USE_RESULT:
                $this->use_result();
                break;
            case MYSQLI_STORE_RESULT:
                $this->store_result();
                break;
        }

        if (false === $this->real_query($sql)) {
            $this->error('Error performing query ' . $sql . ' - Error message : ' . $this->error);

            return false;
        }

        return new MySQL\Result($this);
    }

    /**
     * Performs a INSERT statement
     *
     * @param string $tableName
     * @param array $fields
     * @return int Returns the ID of the inserted row, or false on error
     */
    public function insert($tableName, $fields)
    {
        $sql = "INSERT INTO `$tableName`"
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);
        . ' (`' . implode('`,`', array_keys($fields)) . '`)'
        . ' VALUES ';

        $preparedFields = array();

        foreach ($fields as $fieldValue) {
            $preparedFields[] = $this->escape($fieldValue, true);
        }

        $sql .= '(' .implode(',', $preparedFields) . ')';

        if (false === $this->query($sql)) {
            return false;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
        } else {
            return $this->insert_id;
        }
    }

    public function escape($str, $quoted = false)

    {
        $this->connect(); // It's necessary for real_escape_string.

        $result = $this->real_escape_string($str);

        return true === $quoted && preg_match('#^-?[0-9\.]+$#', $str) !== 1? "'{$result}'" : $result;
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);
    }

    private function parseWhere($where)
    {
        if (is_array($where)) {
            $fields = array();

            foreach ($where as $fieldName => $fieldValue) {
                $fields[] = "`{$fieldName}` = " . $this->escape($fieldValue, true);
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);
            }

            $whereSQL = implode(' AND ', $fields);

            $limit = null;
        } else {
            if (preg_match('#^-?[0-9]+$#', $where) === 1) {
                $whereSQL = "`id` = {$where}";
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);

                $limit = 1;
            } else {
                $whereSQL = $where;

                $limit = null;
            }
        }

        return array($whereSQL, $limit);
    }

    /**
     * Performs an UPDATE statement
     *
     * @param string $tableName The name of the table
     * @param array $fields The fields to update
     * @param mixed $where Accepts array, string and integer
     * @param int $limit (Optional) The limit of rows to update

     * @return int Returns the number of affected rows, or false on error
     */
    public function update($tableName, $fields, $where, $limit = null)
    {
        $sql = "UPDATE `{$tableName}` SET ";
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);

        $preparedFields = array();

        foreach ($fields as $fieldName => $fieldValue) {
            $preparedFields[] = "`$fieldName` = " . $this->escape($fieldValue, true);
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);
        }

        $sql .= implode(',', $preparedFields);

        list($pWhere, $pLimit) = $this->parseWhere($where);

        $where = $pWhere;

        $sql .= " WHERE {$where}";
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);

        if (null === $limit && null !== $pLimit) {
            $limit = $pLimit;
        }

        if (null !== $limit) {
            $sql .= " LIMIT {$limit}";
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);
        }

        if (false === $this->query($sql)) {
            return false;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
        } else {
            return $this->affected_rows;
        }
    }

    /**
     * Performs a DELETE statement
     *
     * @param string $tableName The name of the table
     * @param string $where The where
     * @param int $limit (Optional) The limit

     * @return int Returns the number of affected rows, or false on error
     */
    public function delete($tableName, $where, $limit = null)
    {
        $sql = "DELETE FROM `{$tableName}`";
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);

        list($pWhere, $pLimit) = $this->parseWhere($where);

        $where = $pWhere;

        $sql .= " WHERE {$where}";
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);

        if (null === $limit && null !== $pLimit) {
            $limit = $pLimit;
        }

        if (null !== $limit) {
            $sql .= " LIMIT {$limit}";
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);
        }

        if (false === $this->query($sql)) {
            return false;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
        } else {
            return $this->affected_rows;
        }
    }

    /**
     * Performs a SELECT statement
     *
     * @param string $tableName The name of the table
     * @param mixed $fields (Optional) The fields you want to obtain in the result. Accepts array or string
     * @param mixed $where (Optional) The where. Accepts array, string or intenger
     * @param string $orderBy (Optional) The order by

     * @param int $limit (Optional) The limit

     * @return MySQL_Result

     */
    public function select($tableName, $fields = null, $where = null, $orderBy = null, $limit = null)
    {
        if (is_array($fields)) {
            foreach ($fields as $key => $value) {
                $fields[$key] = "`{$value}`";
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);
            }

            $fields = implode(',', $fields);
        } elseif (is_null($fields)) {
            $fields = '*';
        }

        $sql = "SELECT {$fields} FROM `{$tableName}`";
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);

        if (!is_null($where)) {
            list($pWhere, $pLimit) = $this->parseWhere($where);

            $where = $pWhere;

            if (null === $limit && null !== $pLimit) {
                $limit = $pLimit;
            }

            $sql .= " WHERE {$where}";
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);
        }

        if (!is_null($orderBy)) {
            $sql .= " ORDER BY {$orderBy}";
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);
        }

        if (!is_null($limit)) {
            $sql .= " LIMIT {$limit}";
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);
        }

        return $this->query($sql);
    }

    public function table($tableName, $tableArgs = [])

    {
        if (! isset($this->tables[$tableName])) {
            $this->tables[$tableName] = new MySQL_Table($this, $tableName, $tableArgs);
        }

        return $this->tables[$tableName];
    }

    /**
     * Close the connection when instance is destroyed.
     */
    public function __destruct()
    {
        if (false === $this->connected) {
            return;
        }

        $this->close();
    }
}


Push — master ( c0b5fe...7658de )

MySQL C

Complexity

Size/Duplication

Coupling/Cohesion

Importance

12 Methods

How to fix Complexity

Complex Class

Available Fixes

1			<?php
2			namespace jrdev;
3
4			class MySQL extends \MySQLi
5			{
6			private $dbConfig = array();
7
8			private $connected = false;
9
10			private $lastError = '';
11
12			private $tables = [];
13
14			public function __construct(
15			$host = null,
16			$username = null,
17			$password = null,
18			$dbname = null,
19			$port = null,
20			$socket = null
21			) {
22			$this->dbConfig = [
23			'host' => $host ?: ini_get("mysqli.default_host"),
			0 ignored issues – show Coding Style Comprehensibility introduced 2017-06-07 04:11 UTC by Report Bug Copy Issue Report The string literal `mysqli.default_host` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
24			'username' => $username ?: ini_get("mysqli.default_user"),
			0 ignored issues – show Coding Style Comprehensibility introduced 2017-06-07 04:11 UTC by Report Bug Copy Issue Report The string literal `mysqli.default_user` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
25			'password' => $password ?: ini_get("mysqli.default_pw"),
			0 ignored issues – show Coding Style Comprehensibility introduced 2017-06-07 04:11 UTC by Report Bug Copy Issue Report The string literal `mysqli.default_pw` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
26			'dbname' => $dbname ?: '',
27			'port' => $port ?: ini_get("mysqli.default_port"),
			0 ignored issues – show Coding Style Comprehensibility introduced 2017-06-07 04:11 UTC by Report Bug Copy Issue Report The string literal `mysqli.default_port` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
28			'socket' => $socket ?: ini_get("mysqli.default_socket")
			0 ignored issues – show Coding Style Comprehensibility introduced 2017-06-07 04:11 UTC by Report Bug Copy Issue Report The string literal `mysqli.default_socket` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
29			];
30			}
31
32			public function connect(
33			$host = null,
34			$username = null,
35			$password = null,

jrobinsonc / mysql

Push — master ( c0b5fe...7658de )

MySQL C

Complexity

Size/Duplication

Coupling/Cohesion

Importance

12 Methods

How to fix Complexity

Complex Class

Available Fixes

Duplication Side-by-Side

Filter issues like