Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 25 | class PHPCompatibility_Sniffs_PHP_ForbiddenNamesSniff extends PHPCompatibility_Sniff |
||
|
|
|||
| 26 | { |
||
| 27 | |||
| 28 | /** |
||
| 29 | * A list of keywords that can not be used as function, class and namespace name or constant name. |
||
| 30 | * Mentions since which version it's not allowed. |
||
| 31 | * |
||
| 32 | * @var array(string => string) |
||
| 33 | */ |
||
| 34 | protected $invalidNames = array( |
||
| 35 | 'abstract' => '5.0', |
||
| 36 | 'and' => 'all', |
||
| 37 | 'array' => 'all', |
||
| 38 | 'as' => 'all', |
||
| 39 | 'break' => 'all', |
||
| 40 | 'callable' => '5.4', |
||
| 41 | 'case' => 'all', |
||
| 42 | 'catch' => '5.0', |
||
| 43 | 'class' => 'all', |
||
| 44 | 'clone' => '5.0', |
||
| 45 | 'const' => 'all', |
||
| 46 | 'continue' => 'all', |
||
| 47 | 'declare' => 'all', |
||
| 48 | 'default' => 'all', |
||
| 49 | 'do' => 'all', |
||
| 50 | 'else' => 'all', |
||
| 51 | 'elseif' => 'all', |
||
| 52 | 'enddeclare' => 'all', |
||
| 53 | 'endfor' => 'all', |
||
| 54 | 'endforeach' => 'all', |
||
| 55 | 'endif' => 'all', |
||
| 56 | 'endswitch' => 'all', |
||
| 57 | 'endwhile' => 'all', |
||
| 58 | 'extends' => 'all', |
||
| 59 | 'final' => '5.0', |
||
| 60 | 'finally' => '5.5', |
||
| 61 | 'for' => 'all', |
||
| 62 | 'foreach' => 'all', |
||
| 63 | 'function' => 'all', |
||
| 64 | 'global' => 'all', |
||
| 65 | 'goto' => '5.3', |
||
| 66 | 'if' => 'all', |
||
| 67 | 'implements' => '5.0', |
||
| 68 | 'interface' => '5.0', |
||
| 69 | 'instanceof' => '5.0', |
||
| 70 | 'insteadof' => '5.4', |
||
| 71 | 'namespace' => '5.3', |
||
| 72 | 'new' => 'all', |
||
| 73 | 'or' => 'all', |
||
| 74 | 'private' => '5.0', |
||
| 75 | 'protected' => '5.0', |
||
| 76 | 'public' => '5.0', |
||
| 77 | 'static' => 'all', |
||
| 78 | 'switch' => 'all', |
||
| 79 | 'throw' => '5.0', |
||
| 80 | 'trait' => '5.4', |
||
| 81 | 'try' => '5.0', |
||
| 82 | 'use' => 'all', |
||
| 83 | 'var' => 'all', |
||
| 84 | 'while' => 'all', |
||
| 85 | 'xor' => 'all', |
||
| 86 | '__class__' => 'all', |
||
| 87 | '__dir__' => '5.3', |
||
| 88 | '__file__' => 'all', |
||
| 89 | '__function__' => 'all', |
||
| 90 | '__method__' => 'all', |
||
| 91 | '__namespace__' => '5.3', |
||
| 92 | 'bool' => '7.0', |
||
| 93 | 'int' => '7.0', |
||
| 94 | 'float' => '7.0', |
||
| 95 | 'string' => '7.0', |
||
| 96 | 'null' => '7.0', |
||
| 97 | 'true' => '7.0', |
||
| 98 | 'false' => '7.0', |
||
| 99 | 'resource' => '7.0', |
||
| 100 | 'object' => '7.0', |
||
| 101 | 'mixed' => '7.0', |
||
| 102 | 'numeric' => '7.0' |
||
| 103 | ); |
||
| 104 | |||
| 105 | /** |
||
| 106 | * A list of keywords that can follow use statements. |
||
| 107 | * |
||
| 108 | * @var array(string => string) |
||
| 109 | */ |
||
| 110 | protected $validUseNames = array( |
||
| 111 | 'const' => true, |
||
| 112 | 'function' => true, |
||
| 113 | ); |
||
| 114 | |||
| 115 | /** |
||
| 116 | * targetedTokens |
||
| 117 | * |
||
| 118 | * @var array |
||
| 119 | */ |
||
| 120 | protected $targetedTokens = array( |
||
| 121 | T_CLASS, |
||
| 122 | T_FUNCTION, |
||
| 123 | T_NAMESPACE, |
||
| 124 | T_STRING, |
||
| 125 | T_CONST, |
||
| 126 | T_USE, |
||
| 127 | T_AS, |
||
| 128 | T_EXTENDS, |
||
| 129 | T_TRAIT, |
||
| 130 | T_INTERFACE, |
||
| 131 | ); |
||
| 132 | |||
| 133 | /** |
||
| 134 | * Returns an array of tokens this test wants to listen for. |
||
| 135 | * |
||
| 136 | * @return array |
||
| 137 | */ |
||
| 138 | public function register() |
||
| 146 | |||
| 147 | /** |
||
| 148 | * Processes this test, when one of its tokens is encountered. |
||
| 149 | * |
||
| 150 | * @param PHP_CodeSniffer_File $phpcsFile The file being scanned. |
||
| 151 | * @param int $stackPtr The position of the current token in the |
||
| 152 | * stack passed in $tokens. |
||
| 153 | * |
||
| 154 | * @return void |
||
| 155 | */ |
||
| 156 | public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr) |
||
| 169 | |||
| 170 | /** |
||
| 171 | * Processes this test, when one of its tokens is encountered. |
||
| 172 | * |
||
| 173 | * @param PHP_CodeSniffer_File $phpcsFile The file being scanned. |
||
| 174 | * @param int $stackPtr The position of the current token in the |
||
| 175 | * stack passed in $tokens. |
||
| 176 | * @param array $tokens The stack of tokens that make up |
||
| 177 | * the file. |
||
| 178 | * |
||
| 179 | * @return void |
||
| 180 | */ |
||
| 181 | public function processNonString(PHP_CodeSniffer_File $phpcsFile, $stackPtr, $tokens) |
||
| 220 | |||
| 221 | /** |
||
| 222 | * Processes this test, when one of its tokens is encountered. |
||
| 223 | * |
||
| 224 | * @param PHP_CodeSniffer_File $phpcsFile The file being scanned. |
||
| 225 | * @param int $stackPtr The position of the current token in the |
||
| 226 | * stack passed in $tokens. |
||
| 227 | * @param array $tokens The stack of tokens that make up |
||
| 228 | * the file. |
||
| 229 | * |
||
| 230 | * @return void |
||
| 231 | */ |
||
| 232 | public function processString(PHP_CodeSniffer_File $phpcsFile, $stackPtr, $tokens) |
||
| 266 | |||
| 267 | }//end class |
||
| 268 |
You can fix this by adding a namespace to your class:
When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries.