NewKeywordsSniffTest - Code Metrics - Inspection of "Merge pull request #189 from jrfnl/feature/refacto..." - wimg/PHPCompatibility - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c6357c...5bad31 )

by Juliette

created 2016-09-04 21:42 UTC

NewKeywordsSniffTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	249
Duplicated Lines	41.37 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	6
Bugs	2	Features	0

Metric	Value
wmc	15
c	6
b	2
f	0
lcom	1
cbo	1
dl	103
loc	249
rs	10

14 Methods

Rating	Name	Duplication	Size	Complexity
A	testDirMagicConstant()	8	8	1
A	testInsteadOf()	11	11	1
A	testNamespaceKeyword()	8	8	1
A	testNamespaceConstant()	8	8	1
A	testTraitKeyword()	8	8	1
A	testTraitConstant()	8	8	1
A	testUse()	8	8	1
A	testYield()	8	8	1
A	testFinally()	8	8	1
A	testNowdoc()	10	10	1
A	testConst()	10	10	1
A	testCallable()	0	7	1
A	testGoto()	8	8	1
A	testHaltCompiler()	0	18	2

How to fix Duplicated Code

<?php
/**
 * New keywords sniff test file
 *
 * @package PHPCompatibility
 */


/**
 * New keywords sniff tests
 *
 * @uses BaseSniffTest
 * @package PHPCompatibility
 * @author Jansen Price <[email protected]>
 */
class NewKeywordsSniffTest extends BaseSniffTest
namespace YourVendor;

class YourClass { }
{
    const TEST_FILE = 'sniff-examples/new_keywords.php';

    /**
     * Test allow_url_include
     *
     * @group newKeywords
     *
     * @return void
     */
    public function testDirMagicConstant()

    {
        $file = $this->sniffFile(self::TEST_FILE, '5.2');
        $this->assertError($file, 3, "__DIR__ magic constant is not present in PHP version 5.2 or earlier");

        $file = $this->sniffFile(self::TEST_FILE, '5.3');
        $this->assertNoViolation($file, 3);
    }

    /**
     * Test insteadof
     *
     * @group newKeywords
     *
     * @return void
     */
    public function testInsteadOf()

    {
        $file = $this->sniffFile(self::TEST_FILE, '5.3');
        $this->assertError($file, 15, "\"insteadof\" keyword (for traits) is not present in PHP version 5.3 or earlier");
        $this->assertError($file, 16, "\"insteadof\" keyword (for traits) is not present in PHP version 5.3 or earlier");


        $file = $this->sniffFile(self::TEST_FILE, '5.4');
        $this->assertNoViolation($file, 15);
        $this->assertNoViolation($file, 16);
    }

    /**
     * Test namespace keyword
     *
     * @group newKeywords
     *
     * @return void
     */
    public function testNamespaceKeyword()

    {
        $file = $this->sniffFile(self::TEST_FILE, '5.2');
        $this->assertError($file, 20, "\"namespace\" keyword is not present in PHP version 5.2 or earlier");

        $file = $this->sniffFile(self::TEST_FILE, '5.3');
        $this->assertNoViolation($file, 20);
    }

    /**
     * testNamespaceConstant
     *
     * @group newKeywords
     *
     * @return void
     */
    public function testNamespaceConstant()

    {
        $file = $this->sniffFile(self::TEST_FILE, '5.2');
        $this->assertError($file, 22, "__NAMESPACE__ magic constant is not present in PHP version 5.2 or earlier");

        $file = $this->sniffFile(self::TEST_FILE, '5.3');
        $this->assertNoViolation($file, 22);
    }

    /**
     * Test trait keyword
     *
     * @group newKeywords
     *
     * @return void
     */
    public function testTraitKeyword()

    {
        $file = $this->sniffFile(self::TEST_FILE, '5.3');
        $this->assertError($file, 24, "\"trait\" keyword is not present in PHP version 5.3 or earlier");

        $file = $this->sniffFile(self::TEST_FILE, '5.4');
        $this->assertNoViolation($file, 24);
    }

    /**
     * Test trait magic constant
     *
     * @group newKeywords
     *
     * @return void
     */
    public function testTraitConstant()

    {
        $file = $this->sniffFile(self::TEST_FILE, '5.3');
        $this->assertError($file, 26, "__TRAIT__ magic constant is not present in PHP version 5.3 or earlier");

        $file = $this->sniffFile(self::TEST_FILE, '5.4');
        $this->assertNoViolation($file, 26);
    }

    /**
     * Test the use keyword
     *
     * @group newKeywords
     *
     * @return void
     */
    public function testUse()

    {
        $file = $this->sniffFile(self::TEST_FILE, '5.2');
        $this->assertError($file, 14, "\"use\" keyword (for traits/namespaces/anonymous functions) is not present in PHP version 5.2 or earlier");

        $file = $this->sniffFile(self::TEST_FILE, '5.3');
        $this->assertNoViolation($file, 14);
    }

    /**
     * Test yield
     *
     * @group newKeywords
     *
     * @return void
     */
    public function testYield()

    {
        $file = $this->sniffFile(self::TEST_FILE, '5.4');
        $this->assertError($file, 33, "\"yield\" keyword (for generators) is not present in PHP version 5.4 or earlier");

        $file = $this->sniffFile(self::TEST_FILE, '5.5');
        $this->assertNoViolation($file, 33);
    }

    /**
     * testFinally
     *
     * @group newKeywords
     *
     * @return void
     */
    public function testFinally()

    {
        $file = $this->sniffFile(self::TEST_FILE, '5.4');
        $this->assertError($file, 9, "\"finally\" keyword (in exception handling) is not present in PHP version 5.4 or earlier");

        $file = $this->sniffFile(self::TEST_FILE, '5.5');
        $this->assertNoViolation($file, 9);
    }

    /**
     * testNowdoc
     *
     * @group newKeywords
     *
     * @requires PHP 5.3
     *
     * @return void
     */
    public function testNowdoc()

    {
        $file = $this->sniffFile(self::TEST_FILE, '5.2');
        $this->assertError($file, 37, "nowdoc functionality is not present in PHP version 5.2 or earlier");
        $this->assertError($file, 41, "nowdoc functionality is not present in PHP version 5.2 or earlier");

        $file = $this->sniffFile(self::TEST_FILE, '5.3');
        $this->assertNoViolation($file, 37);
        $this->assertNoViolation($file, 41);
    }

    /**
     * testConst
     *
     * @group newKeywords
     *
     * @return void
     */
    public function testConst()

    {
        $file = $this->sniffFile(self::TEST_FILE, '5.2');
        $this->assertError($file, 43, "\"const\" keyword is not present in PHP version 5.2 or earlier");
        $this->assertNoViolation($file, 46);
        $this->assertNoViolation($file, 47);

        $file = $this->sniffFile(self::TEST_FILE, '5.3');
        $this->assertNoViolation($file, 43);
    }

    /**
     * testCallable
     *
     * @group newKeywords
     *
     * @return void
     */
    public function testCallable()
    {
        $file = $this->sniffFile(self::TEST_FILE, '5.3');
        $this->assertError($file, 50, "\"callable\" keyword is not present in PHP version 5.3 or earlier");

        // Not testing no violations as the ForbiddenNames sniff will also kick in.
    }

    /**
     * testGoto
     *
     * @group newKeywords
     *
     * @return void
     */
    public function testGoto()

    {
        $file = $this->sniffFile(self::TEST_FILE, '5.2');
        $this->assertError($file, 52, "\"goto\" keyword is not present in PHP version 5.2 or earlier");

        $file = $this->sniffFile(self::TEST_FILE, '5.3');
        $this->assertNoViolation($file, 52);
    }

    /**
     * testHaltCompiler
     *
     * @group newKeywords
     *
     * @requires PHP 5.3
     *

     * @return void
     */
    public function testHaltCompiler()
    {
        if (version_compare(phpversion(), '5.3', '=')) {
            // PHP 5.3 actually shows the warning.
            $file = $this->sniffFile(self::TEST_FILE, '5.0');
            $this->assertError($file, 58, "\"__halt_compiler\" keyword is not present in PHP version 5.0 or earlier");
        }
        else {
            /*
             * Usage of `__halt_compiler()` cannot be tested on its own token as the compiler
             * will be halted...
             * So testing that any violations created *after* the compiler is halted will
             * not be reported.
             */
            $file = $this->sniffFile(self::TEST_FILE, '5.2');
            $this->assertNoViolation($file, 61);
        }
    }
}


1		<?php
2		/**
3		* New keywords sniff test file
4		*
5		* @package PHPCompatibility
6		*/
7
8
9		/**
10		* New keywords sniff tests
11		*
12		* @uses BaseSniffTest
13		* @package PHPCompatibility
14		* @author Jansen Price <[email protected]>
15		*/
16		class NewKeywordsSniffTest extends BaseSniffTest
		0 ignored issues – show Coding Style Compatibility introduced 2016-08-04 22:56 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
17		{
18		const TEST_FILE = 'sniff-examples/new_keywords.php';
19
20		/**
21		* Test allow_url_include
22		*
23		* @group newKeywords
24		*
25		* @return void
26		*/
27	View Code Duplication	public function testDirMagicConstant()
		0 ignored issues – show Duplication introduced 2016-08-20 13:52 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
28		{
29		$file = $this->sniffFile(self::TEST_FILE, '5.2');
30		$this->assertError($file, 3, "__DIR__ magic constant is not present in PHP version 5.2 or earlier");
31
32		$file = $this->sniffFile(self::TEST_FILE, '5.3');
33		$this->assertNoViolation($file, 3);
34		}
35
36		/**
37		* Test insteadof
38		*
39		* @group newKeywords
40		*
41		* @return void
42		*/
43	View Code Duplication	public function testInsteadOf()
		0 ignored issues – show Duplication introduced 2016-08-20 13:52 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
44		{
45		$file = $this->sniffFile(self::TEST_FILE, '5.3');
46		$this->assertError($file, 15, "\"insteadof\" keyword (for traits) is not present in PHP version 5.3 or earlier");
47		$this->assertError($file, 16, "\"insteadof\" keyword (for traits) is not present in PHP version 5.3 or earlier");
48
49
50		$file = $this->sniffFile(self::TEST_FILE, '5.4');
51		$this->assertNoViolation($file, 15);
52		$this->assertNoViolation($file, 16);
53		}
54
55		/**
56		* Test namespace keyword
57		*
58		* @group newKeywords
59		*
60		* @return void
61		*/
62	View Code Duplication	public function testNamespaceKeyword()
		0 ignored issues – show Duplication introduced 2016-08-20 13:52 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
63		{
64		$file = $this->sniffFile(self::TEST_FILE, '5.2');
65		$this->assertError($file, 20, "\"namespace\" keyword is not present in PHP version 5.2 or earlier");
66
67		$file = $this->sniffFile(self::TEST_FILE, '5.3');
68		$this->assertNoViolation($file, 20);
69		}
70
71		/**
72		* testNamespaceConstant
73		*
74		* @group newKeywords
75		*
76		* @return void
77		*/
78	View Code Duplication	public function testNamespaceConstant()
		0 ignored issues – show Duplication introduced 2016-08-20 13:52 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
79		{
80		$file = $this->sniffFile(self::TEST_FILE, '5.2');
81		$this->assertError($file, 22, "__NAMESPACE__ magic constant is not present in PHP version 5.2 or earlier");
82
83		$file = $this->sniffFile(self::TEST_FILE, '5.3');
84		$this->assertNoViolation($file, 22);
85		}
86
87		/**
88		* Test trait keyword
89		*
90		* @group newKeywords
91		*
92		* @return void
93		*/
94	View Code Duplication	public function testTraitKeyword()
		0 ignored issues – show Duplication introduced 2016-08-20 13:52 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
95		{
96		$file = $this->sniffFile(self::TEST_FILE, '5.3');
97		$this->assertError($file, 24, "\"trait\" keyword is not present in PHP version 5.3 or earlier");
98
99		$file = $this->sniffFile(self::TEST_FILE, '5.4');
100		$this->assertNoViolation($file, 24);
101		}
102
103		/**
104		* Test trait magic constant
105		*
106		* @group newKeywords
107		*
108		* @return void
109		*/
110	View Code Duplication	public function testTraitConstant()
		0 ignored issues – show Duplication introduced 2016-08-20 13:52 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
111		{
112		$file = $this->sniffFile(self::TEST_FILE, '5.3');
113		$this->assertError($file, 26, "__TRAIT__ magic constant is not present in PHP version 5.3 or earlier");
114
115		$file = $this->sniffFile(self::TEST_FILE, '5.4');
116		$this->assertNoViolation($file, 26);
117		}
118
119		/**
120		* Test the use keyword
121		*
122		* @group newKeywords
123		*
124		* @return void
125		*/
126	View Code Duplication	public function testUse()
		0 ignored issues – show Duplication introduced 2016-08-20 13:52 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
127		{
128		$file = $this->sniffFile(self::TEST_FILE, '5.2');
129		$this->assertError($file, 14, "\"use\" keyword (for traits/namespaces/anonymous functions) is not present in PHP version 5.2 or earlier");
130
131		$file = $this->sniffFile(self::TEST_FILE, '5.3');
132		$this->assertNoViolation($file, 14);
133		}
134
135		/**
136		* Test yield
137		*
138		* @group newKeywords
139		*
140		* @return void
141		*/
142	View Code Duplication	public function testYield()
		0 ignored issues – show Duplication introduced 2016-08-20 13:52 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
143		{
144		$file = $this->sniffFile(self::TEST_FILE, '5.4');
145		$this->assertError($file, 33, "\"yield\" keyword (for generators) is not present in PHP version 5.4 or earlier");
146
147		$file = $this->sniffFile(self::TEST_FILE, '5.5');
148		$this->assertNoViolation($file, 33);
149		}
150
151		/**
152		* testFinally
153		*
154		* @group newKeywords
155		*
156		* @return void
157		*/
158	View Code Duplication	public function testFinally()
		0 ignored issues – show Duplication introduced 2016-08-20 13:52 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
159		{
160		$file = $this->sniffFile(self::TEST_FILE, '5.4');
161		$this->assertError($file, 9, "\"finally\" keyword (in exception handling) is not present in PHP version 5.4 or earlier");
162
163		$file = $this->sniffFile(self::TEST_FILE, '5.5');
164		$this->assertNoViolation($file, 9);
165		}
166
167		/**
168		* testNowdoc
169		*
170		* @group newKeywords
171		*
172		* @requires PHP 5.3
173		*
174		* @return void
175		*/
176	View Code Duplication	public function testNowdoc()
		0 ignored issues – show Duplication introduced 2016-08-20 13:52 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
177		{
178		$file = $this->sniffFile(self::TEST_FILE, '5.2');
179		$this->assertError($file, 37, "nowdoc functionality is not present in PHP version 5.2 or earlier");
180		$this->assertError($file, 41, "nowdoc functionality is not present in PHP version 5.2 or earlier");
181
182		$file = $this->sniffFile(self::TEST_FILE, '5.3');
183		$this->assertNoViolation($file, 37);
184		$this->assertNoViolation($file, 41);
185		}
186
187		/**
188		* testConst
189		*
190		* @group newKeywords
191		*
192		* @return void
193		*/
194	View Code Duplication	public function testConst()
		0 ignored issues – show Duplication introduced 2016-08-15 02:50 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
195		{
196		$file = $this->sniffFile(self::TEST_FILE, '5.2');
197		$this->assertError($file, 43, "\"const\" keyword is not present in PHP version 5.2 or earlier");
198		$this->assertNoViolation($file, 46);
199		$this->assertNoViolation($file, 47);
200
201		$file = $this->sniffFile(self::TEST_FILE, '5.3');
202		$this->assertNoViolation($file, 43);
203		}
204
205		/**
206		* testCallable
207		*
208		* @group newKeywords
209		*
210		* @return void
211		*/
212		public function testCallable()
213		{
214		$file = $this->sniffFile(self::TEST_FILE, '5.3');
215		$this->assertError($file, 50, "\"callable\" keyword is not present in PHP version 5.3 or earlier");
216
217		// Not testing no violations as the ForbiddenNames sniff will also kick in.
218		}
219
220		/**
221		* testGoto
222		*
223		* @group newKeywords
224		*
225		* @return void
226		*/
227	View Code Duplication	public function testGoto()
		0 ignored issues – show Duplication introduced 2016-08-20 13:52 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
228		{
229		$file = $this->sniffFile(self::TEST_FILE, '5.2');
230		$this->assertError($file, 52, "\"goto\" keyword is not present in PHP version 5.2 or earlier");
231
232		$file = $this->sniffFile(self::TEST_FILE, '5.3');
233		$this->assertNoViolation($file, 52);
234		}
235
236		/**
237		* testHaltCompiler
238		*
239		* @group newKeywords
240		*
241		* @requires PHP 5.3
242		*
243
244		* @return void
245		*/
246		public function testHaltCompiler()
247		{
248		if (version_compare(phpversion(), '5.3', '=')) {
249		// PHP 5.3 actually shows the warning.
250		$file = $this->sniffFile(self::TEST_FILE, '5.0');
251		$this->assertError($file, 58, "\"__halt_compiler\" keyword is not present in PHP version 5.0 or earlier");
252		}
253		else {
254		/*
255		* Usage of `__halt_compiler()` cannot be tested on its own token as the compiler
256		* will be halted...
257		* So testing that any violations created after the compiler is halted will
258		* not be reported.
259		*/
260		$file = $this->sniffFile(self::TEST_FILE, '5.2');
261		$this->assertNoViolation($file, 61);
262		}
263		}
264		}
265

wimg / PHPCompatibility

Push — master ( c6357c...5bad31 )

NewKeywordsSniffTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

14 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like