Conditions | 1 |
Paths | 1 |
Total Lines | 104 |
Code Lines | 71 |
Lines | 0 |
Ratio | 0 % |
Changes | 4 | ||
Bugs | 1 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
44 | public function dataGetFunctionCallParameters() |
||
45 | { |
||
46 | return array( |
||
47 | array(88, array( |
||
48 | 1 => array( |
||
49 | 'start' => 90, |
||
50 | 'end' => 91, |
||
51 | 'raw' => '1', |
||
52 | ), |
||
53 | 2 => array( |
||
54 | 'start' => 93, |
||
55 | 'end' => 94, |
||
56 | 'raw' => '2', |
||
57 | ), |
||
58 | 3 => array( |
||
59 | 'start' => 96, |
||
60 | 'end' => 97, |
||
61 | 'raw' => '3', |
||
62 | ), |
||
63 | 4 => array( |
||
64 | 'start' => 99, |
||
65 | 'end' => 100, |
||
66 | 'raw' => '4', |
||
67 | ), |
||
68 | 5 => array( |
||
69 | 'start' => 102, |
||
70 | 'end' => 103, |
||
71 | 'raw' => '5', |
||
72 | ), |
||
73 | 6 => array( |
||
74 | 'start' => 105, |
||
75 | 'end' => 106, |
||
76 | 'raw' => '6', |
||
77 | ), |
||
78 | 7 => array( |
||
79 | 'start' => 108, |
||
80 | 'end' => 110, |
||
81 | 'raw' => 'true', |
||
82 | ), |
||
83 | ), |
||
84 | |||
85 | ), |
||
86 | array(120, array( |
||
87 | 1 => array( |
||
88 | 'start' => 122, |
||
89 | 'end' => 129, |
||
90 | 'raw' => 'dirname( __FILE__ )', |
||
91 | ), |
||
92 | ), |
||
93 | ), |
||
94 | array(250, array( |
||
95 | 1 => array( |
||
96 | 'start' => 252, |
||
97 | 'end' => 252, |
||
98 | 'raw' => '$stHour', |
||
99 | ), |
||
100 | 2 => array( |
||
101 | 'start' => 254, |
||
102 | 'end' => 255, |
||
103 | 'raw' => '0', |
||
104 | ), |
||
105 | 3 => array( |
||
106 | 'start' => 257, |
||
107 | 'end' => 258, |
||
108 | 'raw' => '0', |
||
109 | ), |
||
110 | 4 => array( |
||
111 | 'start' => 260, |
||
112 | 'end' => 264, |
||
113 | 'raw' => '$arrStDt[0]', |
||
114 | ), |
||
115 | 5 => array( |
||
116 | 'start' => 266, |
||
117 | 'end' => 270, |
||
118 | 'raw' => '$arrStDt[1]', |
||
119 | ), |
||
120 | 6 => array( |
||
121 | 'start' => 272, |
||
122 | 'end' => 276, |
||
123 | 'raw' => '$arrStDt[2]', |
||
124 | ), |
||
125 | ), |
||
126 | |||
127 | ), |
||
128 | array(535, array( |
||
129 | 1 => array( |
||
130 | 'start' => 537, |
||
131 | 'end' => 540, |
||
132 | 'raw' => 'array()', |
||
133 | ), |
||
134 | ), |
||
135 | |||
136 | ), |
||
137 | array(577, array( |
||
138 | 1 => array( |
||
139 | 'start' => 579, |
||
140 | 'end' => 611, |
||
141 | 'raw' => '[\'a\' => $a,] + (isset($b) ? [\'b\' => $b,] : [])', |
||
142 | ), |
||
143 | ), |
||
144 | |||
145 | ), |
||
146 | ); |
||
147 | } |
||
148 | |||
283 |