PHPCompatibility /
PHPCompatibility
| Conditions | 36 |
| Paths | 13 |
| Total Lines | 116 |
| Lines | 33 |
| Ratio | 28.45 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 83 | public function process(File $phpcsFile, $stackPtr) |
||
| 84 | { |
||
| 85 | if ($this->supportsAbove('7.4') === false) { |
||
| 86 | return; |
||
| 87 | } |
||
| 88 | |||
| 89 | if ($this->isUnaryPlusMinus($phpcsFile, $stackPtr) === true) { |
||
| 90 | return; |
||
| 91 | } |
||
| 92 | |||
| 93 | $tokens = $phpcsFile->getTokens(); |
||
| 94 | |||
| 95 | for ($i = ($stackPtr - 1); $stackPtr >= 0; $i--) { |
||
| 96 | if ($tokens[$i]['code'] === \T_STRING_CONCAT) { |
||
| 97 | // Found one. |
||
| 98 | break; |
||
| 99 | } |
||
| 100 | |||
| 101 | if ($tokens[$i]['code'] === \T_SEMICOLON |
||
| 102 | || $tokens[$i]['code'] === \T_OPEN_CURLY_BRACKET |
||
| 103 | || $tokens[$i]['code'] === \T_OPEN_TAG |
||
| 104 | || $tokens[$i]['code'] === \T_OPEN_TAG_WITH_ECHO |
||
| 105 | || $tokens[$i]['code'] === \T_COMMA |
||
| 106 | || $tokens[$i]['code'] === \T_COLON |
||
| 107 | || $tokens[$i]['code'] === \T_CASE |
||
| 108 | ) { |
||
| 109 | // If we reached any of the above tokens, we've reached the end of |
||
| 110 | // the statement without encountering a concatenation operator. |
||
| 111 | return; |
||
| 112 | } |
||
| 113 | |||
| 114 | View Code Duplication | if ($tokens[$i]['code'] === \T_OPEN_CURLY_BRACKET |
|
|
|
|||
| 115 | && isset($tokens[$i]['bracket_closer']) |
||
| 116 | && $tokens[$i]['bracket_closer'] > $stackPtr |
||
| 117 | ) { |
||
| 118 | // No need to look any further, this is plus/minus within curly braces |
||
| 119 | // and we've reached the open curly. |
||
| 120 | return; |
||
| 121 | } |
||
| 122 | |||
| 123 | View Code Duplication | if ($tokens[$i]['code'] === \T_OPEN_PARENTHESIS |
|
| 124 | && isset($tokens[$i]['parenthesis_closer']) |
||
| 125 | && $tokens[$i]['parenthesis_closer'] > $stackPtr |
||
| 126 | ) { |
||
| 127 | // No need to look any further, this is plus/minus within parenthesis |
||
| 128 | // and we've reached the open parenthesis. |
||
| 129 | return; |
||
| 130 | } |
||
| 131 | |||
| 132 | View Code Duplication | if (($tokens[$i]['code'] === \T_OPEN_SHORT_ARRAY |
|
| 133 | || $tokens[$i]['code'] === \T_OPEN_SQUARE_BRACKET) |
||
| 134 | && isset($tokens[$i]['bracket_closer']) |
||
| 135 | && $tokens[$i]['bracket_closer'] > $stackPtr |
||
| 136 | ) { |
||
| 137 | // No need to look any further, this is plus/minus within a short array |
||
| 138 | // or array key square brackets and we've reached the opener. |
||
| 139 | return; |
||
| 140 | } |
||
| 141 | |||
| 142 | if ($tokens[$i]['code'] === \T_CLOSE_CURLY_BRACKET) { |
||
| 143 | if (isset($tokens[$i]['scope_owner'])) { |
||
| 144 | // Different scope, we've passed the start of the statement. |
||
| 145 | return; |
||
| 146 | } |
||
| 147 | |||
| 148 | if (isset($tokens[$i]['bracket_opener'])) { |
||
| 149 | $i = $tokens[$i]['bracket_opener']; |
||
| 150 | } |
||
| 151 | |||
| 152 | continue; |
||
| 153 | } |
||
| 154 | |||
| 155 | if ($tokens[$i]['code'] === \T_CLOSE_PARENTHESIS |
||
| 156 | && isset($tokens[$i]['parenthesis_opener']) |
||
| 157 | ) { |
||
| 158 | // Skip over statements in parenthesis, including long arrays. |
||
| 159 | $i = $tokens[$i]['parenthesis_opener']; |
||
| 160 | continue; |
||
| 161 | } |
||
| 162 | |||
| 163 | View Code Duplication | if (($tokens[$i]['code'] === \T_CLOSE_SQUARE_BRACKET |
|
| 164 | || $tokens[$i]['code'] === \T_CLOSE_SHORT_ARRAY) |
||
| 165 | && isset($tokens[$i]['bracket_opener']) |
||
| 166 | ) { |
||
| 167 | // Skip over array keys and short arrays. |
||
| 168 | $i = $tokens[$i]['bracket_opener']; |
||
| 169 | continue; |
||
| 170 | } |
||
| 171 | |||
| 172 | // Check for chain being broken by a token with a lower precedence. |
||
| 173 | if (isset(Tokens::$booleanOperators[$tokens[$i]['code']]) === true |
||
| 174 | || isset(Tokens::$assignmentTokens[$tokens[$i]['code']]) === true |
||
| 175 | ) { |
||
| 176 | return; |
||
| 177 | } |
||
| 178 | |||
| 179 | if (isset($this->tokensWithLowerPrecedence[$tokens[$i]['type']]) === true) { |
||
| 180 | if ($tokens[$i]['code'] === \T_BITWISE_AND |
||
| 181 | && $phpcsFile->isReference($i) === true |
||
| 182 | ) { |
||
| 183 | continue; |
||
| 184 | } |
||
| 185 | |||
| 186 | return; |
||
| 187 | } |
||
| 188 | } |
||
| 189 | |||
| 190 | $message = 'Using an unparenthesized expression containing a "." before a "+" or "-" has been deprecated in PHP 7.4'; |
||
| 191 | $isError = false; |
||
| 192 | if ($this->supportsAbove('8.0') === true) { |
||
| 193 | $message .= ' and removed in PHP 8.0'; |
||
| 194 | $isError = true; |
||
| 195 | } |
||
| 196 | |||
| 197 | $this->addMessage($phpcsFile, $message, $i, $isError); |
||
| 198 | } |
||
| 199 | } |
||
| 200 |
Loading history...
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.