Conditions | 29 |
Paths | 4609 |
Total Lines | 173 |
Code Lines | 127 |
Lines | 0 |
Ratio | 0 % |
Changes | 9 | ||
Bugs | 0 | Features | 1 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
97 | function do_handle_errors( $error_no, $error_str, $error_file, $error_line ) { |
||
98 | if ( ! ( error_reporting() & $error_no ) ) { |
||
99 | return; |
||
100 | } |
||
101 | |||
102 | if ( ! defined( 'E_STRICT' ) ) { |
||
103 | define( 'E_STRICT', 2048 ); |
||
104 | } |
||
105 | if ( ! defined( 'E_RECOVERABLE_ERROR' ) ) { |
||
106 | define( 'E_RECOVERABLE_ERROR', 4096 ); |
||
107 | } |
||
108 | if ( ! defined( 'E_DEPRECATED' ) ) { |
||
109 | define( 'E_DEPRECATED', 8192 ); |
||
110 | } |
||
111 | if ( ! defined( 'E_USER_DEPRECATED' ) ) { |
||
112 | define( 'E_USER_DEPRECATED', 16384 ); |
||
113 | } |
||
114 | |||
115 | switch ( $error_no ) { |
||
116 | case E_ERROR: // 1 // |
||
117 | case E_CORE_ERROR: // 16 // |
||
118 | case E_COMPILE_ERROR: // 64 // |
||
119 | $type = 'Fatal error'; |
||
120 | $class = 'error'; |
||
121 | break; |
||
122 | |||
123 | case E_USER_ERROR: // 256 // |
||
124 | $type = 'Fatal error'; |
||
125 | $class = 'error'; |
||
126 | break; |
||
127 | |||
128 | case E_WARNING: // 2 // |
||
129 | case E_CORE_WARNING: // 32 // |
||
130 | case E_COMPILE_WARNING: // 128 // |
||
131 | $type = 'Warning'; |
||
132 | $class = 'warning'; |
||
133 | break; |
||
134 | |||
135 | case E_USER_WARNING: // 512 // |
||
136 | $type = 'Warning'; |
||
137 | $class = 'warning'; |
||
138 | break; |
||
139 | |||
140 | case E_PARSE: // 4 // |
||
141 | $type = 'Parse error'; |
||
142 | $class = 'error'; |
||
143 | break; |
||
144 | |||
145 | case E_NOTICE: // 8 // |
||
146 | case E_USER_NOTICE: // 1024 // |
||
147 | $type = 'Notice'; |
||
148 | $class = 'notice'; |
||
149 | break; |
||
150 | |||
151 | case E_STRICT: // 2048 // |
||
152 | $type = 'Strict warning'; |
||
153 | $class = 'warning'; |
||
154 | break; |
||
155 | |||
156 | case E_RECOVERABLE_ERROR: // 4096 // |
||
157 | $type = '(Catchable) Fatal error'; |
||
158 | $class = 'error'; |
||
159 | break; |
||
160 | |||
161 | case E_DEPRECATED: // 8192 // |
||
162 | case E_USER_DEPRECATED: // 16384 // |
||
163 | $type = 'Deprecated'; |
||
164 | $class = 'notice'; |
||
165 | break; |
||
166 | |||
167 | default: |
||
168 | $type = 'Unknown error ( ' . $error_no . ' )'; |
||
169 | $class = 'error'; |
||
170 | break; |
||
171 | } |
||
172 | |||
173 | |||
174 | // Group some messages. |
||
175 | $search = array( |
||
176 | 'array_key_exists() expects parameter 2 to be array', |
||
177 | 'key() expects parameter 1 to be array', |
||
178 | 'current() expects parameter 1 to be array', |
||
179 | 'array_filter() expects parameter 1 to be array', |
||
180 | 'preg_match() expects parameter 2 to be string', |
||
181 | 'strlen() expects parameter 1 to be string', |
||
182 | 'count_chars() expects parameter 1 to be string', |
||
183 | 'mb_strlen() expects parameter 1 to be string', |
||
184 | 'trim() expects parameter 1 to be string', |
||
185 | 'get_class() expects parameter 1 to be object', |
||
186 | 'get_resource_type() expects parameter 1 to be resource', |
||
187 | 'intdiv() expects parameter 1 to be integer', |
||
188 | 'intdiv() expects parameter 2 to be integer', |
||
189 | ); |
||
190 | |||
191 | $replace = array( |
||
192 | 'array_key_exists() expects parameter 2 to be array, <em>null/boolean/integer/double/string/object/resource</em> given', |
||
193 | 'key() expects parameter 1 to be array, <em>null/boolean/integer/double/string/object/resource</em> given', |
||
194 | 'current() expects parameter 1 to be array, <em>null/boolean/integer/double/string/object/resource</em> given', |
||
195 | 'array_filter() expects parameter 1 to be array, <em>null/boolean/integer/double/string/object/resource</em> given', |
||
196 | 'preg_match() expects parameter 2 to be string, <em>array/object/resource</em> given', |
||
197 | 'strlen() expects parameter 1 to be string, <em>array/object/resource</em> given', |
||
198 | 'count_chars() expects parameter 1 to be string, <em>array/object/resource</em> given', |
||
199 | 'mb_strlen() expects parameter 1 to be string, <em>array/object/resource</em> given', |
||
200 | 'trim() expects parameter 1 to be string, <em>array/object/resource</em> given', |
||
201 | 'get_class() expects parameter 1 to be object, <em>boolean/integer/double/string/array/resource</em> given', |
||
202 | 'get_resource_type() expects parameter 1 to be resource, <em>null/boolean/integer/double/string/array/object</em> given', |
||
203 | 'intdiv() expects parameter 1 to be integer, <em>float/string/array/object/resource</em> given', |
||
204 | 'intdiv() expects parameter 2 to be integer, <em>float/string/array/object/resource</em> given', |
||
205 | ); |
||
206 | |||
207 | // Group some more messages and make error message links work. |
||
208 | $preg_search = array( |
||
209 | '`^(bc(?:add|sub|mul|div|mod|comp)|str(?:case|natcase|nat)?cmp|strcoll|similar_text|levenshtein)\(\) expects parameter ([12]) to be string, (?:array|object|resource) given$`', |
||
210 | '`^fmod\(\) expects parameter ([12]) to be (double|float), (?:string|array|object|resource) given$`', |
||
211 | '`^(is_(?:nan|(?:in)?finite))\(\) expects parameter ([12]) to be (double|float), (?:string|array|object|resource) given$`', |
||
212 | '`^Object of class [A-Za-z]+ could not be converted to (int|double|float|string)$`', |
||
213 | '`^Object of class [A-Za-z]+ to string conversion$`', |
||
214 | '`^Cannot use object of type [A-Za-z]+ as array$`', |
||
215 | '`<a href=(["\'])function\.`', |
||
216 | ); |
||
217 | $preg_replace = array( |
||
218 | '$1() expects parameter $2 to be string, <em>array/object/resource</em> given', |
||
219 | 'fmod() expects parameter $1 to be $2, <em>string/array/object/resource</em> given', |
||
220 | '$1() expects parameter $2 to be $3, <em>string/array/object/resource</em> given', |
||
221 | 'Object of class <em>stdClass/TestObject/TestObjectToString</em> could not be converted to $1', |
||
222 | 'Object of class <em>stdClass/TestObject/TestObjectToString</em> to string conversion', |
||
223 | 'Cannot use object of type <em>stdClass/TestObject/TestObjectToString</em> as array', |
||
224 | '<a href=$1http://php.net/function.', |
||
225 | ); |
||
226 | |||
227 | foreach ( $search as $k => $s ) { |
||
228 | if ( strpos( $error_str, $s ) === 0 ) { |
||
229 | $error_str = $replace[ $k ]; |
||
230 | break; |
||
231 | } |
||
232 | } |
||
233 | $error_str = preg_replace( $preg_search, $preg_replace, $error_str ); |
||
234 | |||
235 | |||
236 | $message = '<span class="' . $class . '">' . $type . '</span>: ' . $error_str; |
||
237 | |||
238 | if ( isset( $GLOBALS['encountered_errors'] ) ) { |
||
239 | // Ignore strict warnings (can't avoid having them if I want to keep this sheet working with PHP4). |
||
240 | if ( $error_no !== E_STRICT ) { |
||
241 | $key = get_error_key( $message ); |
||
242 | |||
243 | if ( $class === 'notice' || $class === 'warning' ) { |
||
244 | $GLOBALS['has_error'][]['msg'] = ' ( <span class="' . $class . '"><a href="#' . $GLOBALS['test'] . '-errors">#' . ( $key + 1 ) . '</a></span> )'; |
||
245 | return; |
||
246 | } |
||
247 | else if ( $class === 'error' ) { |
||
248 | $GLOBALS['has_error'][]['msg'] = ' <span class="error">' . $type . ' ( <a href="#' . $GLOBALS['test'] . '-errors">#' . ( $key + 1 ) . '</a> )</span>'; |
||
249 | return; |
||
250 | } |
||
251 | else { |
||
252 | echo $message, ' in ', $error_file, ' on line ', $error_line, "<br />\n"; |
||
253 | } |
||
254 | } |
||
255 | else { |
||
256 | return; |
||
257 | } |
||
258 | } |
||
259 | else { |
||
260 | if ( $error_no !== E_STRICT ) { |
||
261 | echo $message, ' in ', $error_file, ' on line ', $error_line, "<br />\n"; |
||
262 | } |
||
263 | else { |
||
264 | return; |
||
265 | } |
||
266 | } |
||
267 | |||
268 | return false; // Make sure it plays nice with other error handlers (remove if no other error handlers are set). |
||
269 | } |
||
270 | |||
422 |