Conditions | 35 |
Paths | 92 |
Total Lines | 128 |
Lines | 9 |
Ratio | 7.03 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
95 | function pr_var( $var, $title = '', $escape = true, $short = false, $space = '', $in_array = false ) { |
||
96 | |||
97 | if ( is_string( $title ) && $title !== '' ) { |
||
98 | echo '<h4 style="clear: both;">', ( ( $escape === true ) ? htmlentities( $title, ENT_QUOTES ) : $title ), "</h4>\n"; |
||
99 | } |
||
100 | |||
101 | if ( is_array( $var ) ) { |
||
102 | if ( $var !== array() ) { |
||
103 | echo 'Array: ', $space, "(<br />\n"; |
||
104 | $spacing = ( ( $short !== true ) ? $space . XVARDUMP_SPACE_LONG : $space . XVARDUMP_SPACE_SHORT ); |
||
105 | foreach ( $var as $key => $value ) { |
||
106 | echo $spacing, '[', ( ( $escape === true ) ? htmlentities( $key, ENT_QUOTES ) : $key ); |
||
107 | if ( $short !== true ) { |
||
108 | echo ' '; |
||
109 | switch ( true ) { |
||
110 | case ( is_string( $key ) ): |
||
111 | echo '<b class="', XVARDUMP_CLASS_STRING, '"><i>(string)</i></b>'; |
||
112 | break; |
||
113 | |||
114 | case ( is_int( $key ) ): |
||
115 | echo '<b class="', XVARDUMP_CLASS_INT, '"><i>(int)</i></b>'; |
||
116 | break; |
||
117 | |||
118 | case ( is_float( $key ) ): |
||
119 | echo '<b class="', XVARDUMP_CLASS_FLOAT, '"><i>(float)</i></b>'; |
||
120 | break; |
||
121 | |||
122 | default: |
||
123 | echo '(unknown)'; |
||
124 | break; |
||
125 | } |
||
126 | } |
||
127 | echo '] => '; |
||
128 | pr_var( $value, '', $escape, $short, $spacing, true ); |
||
129 | } |
||
130 | echo $space, ")<br />\n\n"; |
||
131 | } |
||
132 | else { |
||
133 | echo 'array()<br />'; |
||
134 | } |
||
135 | } |
||
136 | else if ( is_string( $var ) ) { |
||
137 | echo '<span class="', XVARDUMP_CLASS_STRING, '">'; |
||
138 | if ( $short !== true ) { |
||
139 | echo '<b><i>string[', strlen( $var ), ']</i></b> : '; |
||
140 | } |
||
141 | echo '‘', |
||
142 | ( ( $escape === true ) ? str_replace( ' ', ' ', htmlentities( $var, ENT_QUOTES, 'UTF-8' ) ) : str_replace( ' ', ' ', $var ) ), |
||
143 | "’</span><br />\n"; |
||
144 | } |
||
145 | else if ( is_bool( $var ) ) { |
||
146 | if ( $short !== true ) { |
||
147 | echo '<span class="', XVARDUMP_CLASS_BOOL, '"><b><i>bool</i></b> : ', $var, ' ( = '; |
||
148 | } |
||
149 | else { |
||
150 | echo '<b class="', XVARDUMP_CLASS_BOOL, '"><i>b</i></b> '; |
||
151 | } |
||
152 | View Code Duplication | if ( $var === false ) { |
|
153 | echo '<i class="', XVARDUMP_CLASS_B_FALSE, '">false</i>'; |
||
154 | } |
||
155 | else if ( $var === true ) { |
||
156 | echo '<i class="', XVARDUMP_CLASS_B_TRUE, '">true</i>'; |
||
157 | } |
||
158 | else { |
||
159 | echo '<i>undetermined</i>'; |
||
160 | } |
||
161 | if ( $short !== true ) { |
||
162 | echo ' )</span>'; |
||
163 | } |
||
164 | echo "<br />\n"; |
||
165 | } |
||
166 | else if ( is_int( $var ) ) { |
||
167 | echo '<span class="', XVARDUMP_CLASS_INT, '">'; |
||
168 | if ( $short !== true ) { |
||
169 | echo '<b><i>int</i></b> : '; |
||
170 | } |
||
171 | if ( $var === 0 ) { |
||
172 | echo '<span class="', XVARDUMP_CLASS_INT_0, '">', $var, '</span>'; |
||
173 | } |
||
174 | else { |
||
175 | echo $var; |
||
176 | } |
||
177 | echo "</span><br />\n"; |
||
178 | } |
||
179 | else if ( is_float( $var ) ) { |
||
180 | echo '<span class="', XVARDUMP_CLASS_FLOAT, '">'; |
||
181 | if ( $short !== true ) { |
||
182 | echo '<b><i>float</i></b> : '; |
||
183 | } |
||
184 | echo $var, "</span><br />\n"; |
||
185 | } |
||
186 | else if ( is_null( $var ) ) { |
||
187 | echo '<span class="', XVARDUMP_CLASS_NULL, '">'; |
||
188 | if ( $short !== true ) { |
||
189 | echo '<b><i>'; |
||
190 | } |
||
191 | echo 'null'; |
||
192 | if ( $short !== true ) { |
||
193 | echo '</i></b> : ', $var, ' ( = <i>NULL</i> )', "</span><br />\n"; |
||
194 | } |
||
195 | else if ( $in_array === true ) { |
||
196 | echo "</span><br />\n"; |
||
197 | } |
||
198 | else { |
||
199 | echo "</span>\n"; |
||
200 | } |
||
201 | } |
||
202 | else if ( is_resource( $var ) ) { |
||
203 | echo '<span class="', XVARDUMP_CLASS_RESOURCE, '">'; |
||
204 | if ( $short !== true ) { |
||
205 | echo '<b><i>resource</i></b> : '; |
||
206 | } |
||
207 | echo $var; |
||
208 | if ( $short !== true ) { |
||
209 | echo ' ( = <i>RESOURCE</i> )'; |
||
210 | } |
||
211 | echo "</span><br />\n"; |
||
212 | } |
||
213 | else if ( is_object( $var ) ) { |
||
214 | echo "Object: \n", $space, "(<br />\n"; |
||
215 | $spacing = ( ( $short !== true ) ? $space . XVARDUMP_SPACE_LONG : $space . XVARDUMP_SPACE_SHORT ); |
||
216 | object_info( $var, $escape, $short, $spacing ); |
||
217 | echo $space, ")<br />\n\n"; |
||
218 | } |
||
219 | else { |
||
220 | echo 'I haven't got a clue what this is: ', gettype( $var ), "<br />\n"; |
||
221 | } |
||
222 | } |
||
223 | |||
391 |