| Conditions | 29 |
| Paths | 4609 |
| Total Lines | 171 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 102 | function do_handle_errors( $error_no, $error_str, $error_file, $error_line ) { |
||
| 103 | if ( ! ( error_reporting() & $error_no ) ) { |
||
| 104 | return; |
||
| 105 | } |
||
| 106 | |||
| 107 | if ( ! defined( 'E_STRICT' ) ) { |
||
| 108 | define( 'E_STRICT', 2048 ); |
||
| 109 | } |
||
| 110 | if ( ! defined( 'E_RECOVERABLE_ERROR' ) ) { |
||
| 111 | define( 'E_RECOVERABLE_ERROR', 4096 ); |
||
| 112 | } |
||
| 113 | if ( ! defined( 'E_DEPRECATED' ) ) { |
||
| 114 | define( 'E_DEPRECATED', 8192 ); |
||
| 115 | } |
||
| 116 | if ( ! defined( 'E_USER_DEPRECATED' ) ) { |
||
| 117 | define( 'E_USER_DEPRECATED', 16384 ); |
||
| 118 | } |
||
| 119 | |||
| 120 | switch ( $error_no ) { |
||
| 121 | case E_ERROR: // 1 // |
||
| 122 | case E_CORE_ERROR: // 16 // |
||
| 123 | case E_COMPILE_ERROR: // 64 // |
||
| 124 | $type = 'Fatal error'; |
||
| 125 | $class = 'error'; |
||
| 126 | break; |
||
| 127 | |||
| 128 | case E_USER_ERROR: // 256 // |
||
| 129 | $type = 'Fatal error'; |
||
| 130 | $class = 'error'; |
||
| 131 | break; |
||
| 132 | |||
| 133 | case E_WARNING: // 2 // |
||
| 134 | case E_CORE_WARNING: // 32 // |
||
| 135 | case E_COMPILE_WARNING: // 128 // |
||
| 136 | $type = 'Warning'; |
||
| 137 | $class = 'warning'; |
||
| 138 | break; |
||
| 139 | |||
| 140 | case E_USER_WARNING: // 512 // |
||
| 141 | $type = 'Warning'; |
||
| 142 | $class = 'warning'; |
||
| 143 | break; |
||
| 144 | |||
| 145 | case E_PARSE: // 4 // |
||
| 146 | $type = 'Parse error'; |
||
| 147 | $class = 'error'; |
||
| 148 | break; |
||
| 149 | |||
| 150 | case E_NOTICE: // 8 // |
||
| 151 | case E_USER_NOTICE: // 1024 // |
||
| 152 | $type = 'Notice'; |
||
| 153 | $class = 'notice'; |
||
| 154 | break; |
||
| 155 | |||
| 156 | case E_STRICT: // 2048 // |
||
| 157 | $type = 'Strict warning'; |
||
| 158 | $class = 'warning'; |
||
| 159 | break; |
||
| 160 | |||
| 161 | case E_RECOVERABLE_ERROR: // 4096 // |
||
| 162 | $type = '(Catchable) Fatal error'; |
||
| 163 | $class = 'error'; |
||
| 164 | break; |
||
| 165 | |||
| 166 | case E_DEPRECATED: // 8192 // |
||
| 167 | case E_USER_DEPRECATED: // 16384 // |
||
| 168 | $type = 'Deprecated'; |
||
| 169 | $class = 'notice'; |
||
| 170 | break; |
||
| 171 | |||
| 172 | default: |
||
| 173 | $type = 'Unknown error ( ' . $error_no . ' )'; |
||
| 174 | $class = 'error'; |
||
| 175 | break; |
||
| 176 | } |
||
| 177 | |||
| 178 | |||
| 179 | // Group some messages. |
||
| 180 | $search = array( |
||
| 181 | 'array_key_exists() expects parameter 2 to be array', |
||
| 182 | 'key() expects parameter 1 to be array', |
||
| 183 | 'current() expects parameter 1 to be array', |
||
| 184 | 'array_filter() expects parameter 1 to be array', |
||
| 185 | 'preg_match() expects parameter 2 to be string', |
||
| 186 | 'strlen() expects parameter 1 to be string', |
||
| 187 | 'count_chars() expects parameter 1 to be string', |
||
| 188 | 'mb_strlen() expects parameter 1 to be string', |
||
| 189 | 'trim() expects parameter 1 to be string', |
||
| 190 | 'get_class() expects parameter 1 to be object', |
||
| 191 | 'get_resource_type() expects parameter 1 to be resource', |
||
| 192 | ); |
||
| 193 | |||
| 194 | $replace = array( |
||
| 195 | 'array_key_exists() expects parameter 2 to be array, <em>null/boolean/integer/double/string/object/resource</em> given', |
||
| 196 | 'key() expects parameter 1 to be array, <em>null/boolean/integer/double/string/object/resource</em> given', |
||
| 197 | 'current() expects parameter 1 to be array, <em>null/boolean/integer/double/string/object/resource</em> given', |
||
| 198 | 'array_filter() expects parameter 1 to be array, <em>null/boolean/integer/double/string/object/resource</em> given', |
||
| 199 | 'preg_match() expects parameter 2 to be string, <em>array/object/resource</em> given', |
||
| 200 | 'strlen() expects parameter 1 to be string, <em>array/object/resource</em> given', |
||
| 201 | 'count_chars() expects parameter 1 to be string, <em>array/object/resource</em> given', |
||
| 202 | 'mb_strlen() expects parameter 1 to be string, <em>array/object/resource</em> given', |
||
| 203 | 'trim() expects parameter 1 to be string, <em>array/object/resource</em> given', |
||
| 204 | 'get_class() expects parameter 1 to be object, <em>boolean/integer/double/string/array/resource</em> given', |
||
| 205 | 'get_resource_type() expects parameter 1 to be resource, <em>null/boolean/integer/double/string/array/object</em> given', |
||
| 206 | ); |
||
| 207 | |||
| 208 | // Group some more messages and make error message links work. |
||
| 209 | $preg_search = array( |
||
| 210 | '`^(bc(?:add|sub|mul|div|mod|comp)|str(?:case|natcase|nat)?cmp|strcoll|similar_text|levenshtein)\(\) expects parameter ([12]) to be string, (?:array|object|resource) given$`', |
||
| 211 | '`^fmod\(\) expects parameter ([12]) to be (double|float), (?:string|array|object|resource) given$`', |
||
| 212 | '`^(is_(?:nan|(?:in)?finite))\(\) expects parameter ([12]) to be (double|float), (?:string|array|object|resource) given$`', |
||
| 213 | '`^Object of class [A-Za-z]+ could not be converted to (int|double|float|string|number)$`', |
||
| 214 | '`^Object of class [A-Za-z]+ to string conversion$`', |
||
| 215 | '`^Cannot use object of type [A-Za-z]+ as array$`', |
||
| 216 | '`<a href=(["\'])function\.`', |
||
| 217 | '`^intdiv\(\) expects parameter ([12]) to be int(eger)?, (?:float|string|array|object|resource) given$`', |
||
| 218 | ); |
||
| 219 | $preg_replace = array( |
||
| 220 | '$1() expects parameter $2 to be string, <em>array/object/resource</em> given', |
||
| 221 | 'fmod() expects parameter $1 to be $2, <em>string/array/object/resource</em> given', |
||
| 222 | '$1() expects parameter $2 to be $3, <em>string/array/object/resource</em> given', |
||
| 223 | 'Object of class <em>stdClass/TestObject/TestObjectToString</em> could not be converted to $1', |
||
| 224 | 'Object of class <em>stdClass/TestObject/TestObjectToString</em> to string conversion', |
||
| 225 | 'Cannot use object of type <em>stdClass/TestObject/TestObjectToString</em> as array', |
||
| 226 | '<a href=$1https://php.net/function.', |
||
| 227 | 'intdiv() expects parameter $1 to be int$2, <em>float/string/array/object/resource</em> given', |
||
| 228 | ); |
||
| 229 | |||
| 230 | foreach ( $search as $k => $s ) { |
||
| 231 | if ( strpos( $error_str, $s ) === 0 ) { |
||
| 232 | $error_str = $replace[ $k ]; |
||
| 233 | break; |
||
| 234 | } |
||
| 235 | } |
||
| 236 | $error_str = preg_replace( $preg_search, $preg_replace, $error_str ); |
||
| 237 | |||
| 238 | |||
| 239 | $message = '<span class="' . $class . '">' . $type . '</span>: ' . $error_str; |
||
| 240 | |||
| 241 | if ( isset( $GLOBALS['encountered_errors'] ) ) { |
||
| 242 | // Ignore strict warnings (can't avoid having them if I want to keep this sheet working with PHP4). |
||
| 243 | if ( $error_no !== E_STRICT ) { |
||
| 244 | $key = get_error_key( $message ); |
||
| 245 | |||
| 246 | if ( $class === 'notice' || $class === 'warning' ) { |
||
| 247 | $GLOBALS['has_error'][]['msg'] = ' ( <span class="' . $class . '"><a href="#' . $GLOBALS['test'] . '-errors">#' . ( $key + 1 ) . '</a></span> )'; |
||
| 248 | return; |
||
| 249 | } |
||
| 250 | else if ( $class === 'error' ) { |
||
| 251 | $GLOBALS['has_error'][]['msg'] = ' <span class="error">' . $type . ' ( <a href="#' . $GLOBALS['test'] . '-errors">#' . ( $key + 1 ) . '</a> )</span>'; |
||
| 252 | return; |
||
| 253 | } |
||
| 254 | else { |
||
| 255 | echo $message, ' in ', $error_file, ' on line ', $error_line, "<br />\n"; |
||
| 256 | } |
||
| 257 | } |
||
| 258 | else { |
||
| 259 | return; |
||
| 260 | } |
||
| 261 | } |
||
| 262 | else { |
||
| 263 | if ( $error_no !== E_STRICT ) { |
||
| 264 | echo $message, ' in ', $error_file, ' on line ', $error_line, "<br />\n"; |
||
| 265 | } |
||
| 266 | else { |
||
| 267 | return; |
||
| 268 | } |
||
| 269 | } |
||
| 270 | |||
| 271 | return false; // Make sure it plays nice with other error handlers (remove if no other error handlers are set). |
||
| 272 | } |
||
| 273 | |||
| 428 |