JPBernius\FMeat\Entities\Day

Complexity

Total Complexity

10

Size/Duplication

Total Lines	70
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	2

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	addDish()	0	6	2
A	getDish()	0	8	2
A	getDate()	0	4	1
A	fromJson()	0	12	2
A	getDayOfWeek()	0	4	1
A	getIterator()	0	4	1

<?php

namespace JPBernius\FMeat\Entities;

use ArrayIterator;
use DateTime;
use DateTimeInterface;
use IteratorAggregate;
use JPBernius\FMeat\Exeptions\DishNotFoundException;

class Day implements Entity, IteratorAggregate
{

    /** @var DateTimeInterface */
    private $date;

    /** @var array */
    private $dishes = [];

    public function __construct(DateTimeInterface $date)
    {
        $this->date = $date;
    }

    /**
     * @param Dish $dish
     */
    public function addDish(Dish $dish): void
    {
        if (!in_array($dish, $this->dishes)) {
            $this->dishes[] = $dish;
        }
    }

    /**
     * @param int $index
     * @return Dish
     * @throws DishNotFoundException
     */
    public function getDish(int $index): Dish
    {
        if (empty($this->dishes[$index])) {
            throw new DishNotFoundException();
        }

        return $this->dishes[$index];
    }

    public function getDate(): DateTimeInterface
    {
        return $this->date;
    }

    /**
     * @param \stdClass $jsonObject
     * @return Day
     */
    public static function fromJson(\stdClass $jsonObject): self
    {
        $date = DateTime::createFromFormat('Y-m-d', $jsonObject->date);
        $day = new Day($date);

It seems like $date defined by \DateTime::createFromFormat('Y-m-d', $jsonObject->date) on line 60 can also be of type false; however, JPBernius\FMeat\Entities\Day::__construct() does only seem to accept object<DateTimeInterface>, did you maybe forget to handle an error condition?

        foreach ($jsonObject->dishes as $jsonDishObject) {
            $dish = Dish::fromJson($jsonDishObject);
            $day->addDish($dish);
        }

        return $day;
    }

    public function getDayOfWeek(): int
    {
        return intval($this->date->format('N'));
    }

    public function getIterator()
    {
        return new ArrayIterator($this->dishes);
    }
}