Resolver::resolve() - Code Metrics - Inspection of "ConnectionExceptions now return false" - journeygroup/vssl-render - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 0d4b0a...562840 )

by Justin

created 2017-02-10 16:24 UTC

Resolver::resolve() A

↳ Parent: Resolver

Complexity

Conditions	3
Paths	3

Size

Total Lines	12
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	3

Importance

Changes

Metric	Value
dl	0
loc	12
ccs	9
cts	9
cp	1
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	8
nc	3
nop	0
crap	3

<?php

namespace Vessel\Render;

use GuzzleHttp\Client;
use Journey\Cache\Adapters\LocalAdapter;
use Journey\Cache\CacheAdapterInterface;
use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\ServerRequestInterface;

class Resolver
{
    /**
     * The request object.
     *
     * @var \Psr\Http\Message\ServerRequestInterface
     */
    protected $request;

    /**
     * Configuration array.
     *
     * @var array
     */
    protected $config;

    /**
     * The page api object.
     *
     * @var \Vessel\Render\PageApi
     */
    protected $api;

    /**
     * Initialize a new Resolver
     */
    public function __construct(ServerRequestInterface $request, $config = false)
    {
        $this->request = $request;
        $this->config = is_array($config) ? static::config($config) : static::config();
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        if (!$this->config['cache'] instanceof CacheAdapterInterface) {
            throw new ResolverException('Cache must implement \Journey\Cache\CacheAdapterInterface.');
        }
        $this->api = new PageApi($this->config);
    }

    /**
     * Get a modified request message.
     *
     * @return \Psr\Http\Message\ServerRequestInterface
     */
    public function getRequest()
    {
        return $this->request->withAttribute('ws-page', $this->resolve());
    }

    /**
     * Resolve the current page from WebStories.
     *
     * @return array
     */
    public function resolve()
    {
        if ($response = $this->api->getPage($this->request->getUri()->getPath())) {
            $data = $this->decodeBody($response);
            return [
                'status' => $response->getStatusCode(),
                'data' => $data,
                'page' => is_array($data) ? new Renderer($this->config, $data) : $data,
            ];
        }
        return false;
    }

    /**
     * Decode the body of a particular request.
     *
     * @return mixed
     */
    public function decodeBody(ResponseInterface $response)
    {
        $body = (string) $response->getBody();
        if ($response->getHeaderLine('Content-Type') == "application/json") {
            return json_decode($body, true);
        }
        return $body;
    }

    /**
     * Configure the resolver.
     *
     * @return void
     */
    public static function config($assign = false)
    {
        static $config;

        if (is_array($assign) || !$config) {
            $config = array_merge([
                'cache' => null,
                'base_uri' => 'https://www.webstories.com/',
                'required_fields' => [
                    'id',
                    'title',
                    'stripes'
                ],
                // 'templates' => 'your-directory'

            ], $assign);
        }
        return $config ?: [];
    }
}


1		<?php
2
3		namespace Vessel\Render;
4
5		use GuzzleHttp\Client;
6		use Journey\Cache\Adapters\LocalAdapter;
7		use Journey\Cache\CacheAdapterInterface;
8		use Psr\Http\Message\ResponseInterface;
9		use Psr\Http\Message\ServerRequestInterface;
10
11		class Resolver
12		{
13		/**
14		* The request object.
15		*
16		* @var \Psr\Http\Message\ServerRequestInterface
17		*/
18		protected $request;
19
20		/**
21		* Configuration array.
22		*
23		* @var array
24		*/
25		protected $config;
26
27		/**
28		* The page api object.
29		*
30		* @var \Vessel\Render\PageApi
31		*/
32		protected $api;
33
34		/**
35		* Initialize a new Resolver
36		*/
37	3	public function __construct(ServerRequestInterface $request, $config = false)
38		{
39	3	$this->request = $request;
40	3	$this->config = is_array($config) ? static::config($config) : static::config();
		0 ignored issues – show Documentation introduced 2017-02-10 04:34 UTC by Report Bug Copy Issue Report `$config` is of type `array`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
41	3	if (!$this->config['cache'] instanceof CacheAdapterInterface) {
42		throw new ResolverException('Cache must implement \Journey\Cache\CacheAdapterInterface.');
43		}
44	3	$this->api = new PageApi($this->config);
45	3	}
46
47		/**
48		* Get a modified request message.
49		*
50		* @return \Psr\Http\Message\ServerRequestInterface
51		*/
52	3	public function getRequest()
53		{
54	3	return $this->request->withAttribute('ws-page', $this->resolve());
55		}
56
57		/**
58		* Resolve the current page from WebStories.
59		*
60		* @return array
61		*/
62	3	public function resolve()
63		{
64	3	if ($response = $this->api->getPage($this->request->getUri()->getPath())) {
65	2	$data = $this->decodeBody($response);
66	1	return [
67	2	'status' => $response->getStatusCode(),
68	2	'data' => $data,
69	2	'page' => is_array($data) ? new Renderer($this->config, $data) : $data,
70	2	];
71		}
72	1	return false;
73		}
74
75		/**
76		* Decode the body of a particular request.
77		*
78		* @return mixed
79		*/
80	2	public function decodeBody(ResponseInterface $response)
81		{
82	2	$body = (string) $response->getBody();
83	2	if ($response->getHeaderLine('Content-Type') == "application/json") {
84	2	return json_decode($body, true);
85		}
86		return $body;
87		}
88
89		/**
90		* Configure the resolver.
91		*
92		* @return void
93		*/
94	9	public static function config($assign = false)
95		{
96	9	static $config;
97
98	9	if (is_array($assign) \|\| !$config) {
99	4	$config = array_merge([
100	4	'cache' => null,
101	4	'base_uri' => 'https://www.webstories.com/',
102		'required_fields' => [
103	4	'id',
104	4	'title',
105		'stripes'
106	4	],
107		// 'templates' => 'your-directory'
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-02-10 04:34 UTC by Report Bug Copy Issue Report `50%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
108	4	], $assign);
109	4	}
110	9	return $config ?: [];
111		}
112		}
113

journeygroup / vssl-render

Push — master ( 0d4b0a...562840 )

Resolver::resolve() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like