Issues in MemcachedAdapter.php (master) - Issues in master - journeygroup/cache - Measure and Improve Code Quality continuously with Scrutinizer

Issues (4)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Adapters/MemcachedAdapter.php (2 issues)

Labels

Bug 2

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Journey\Cache\Adapters;

use Journey\Cache\CacheAdapterInterface;
use Memcached;

class MemcachedAdapter implements CacheAdapterInterface
{
    /**
     * Instance of memcached.
     *
     * @var \Memcached
     */
    protected $instance;

    /**
     * Initialize a new localcache.
     *
     * @param string $filepath
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     */
    public function __construct(array $config)
    {
        $this->config = $config;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->instance = new Memcached();
        if ($config['servers']) {
            foreach ($config['servers'] as $server) {
                $this->instance->addServer($server['host'], $server['port']);
            }
        }
    }

    /**
     * Must implement a set method.
     *
     * @param  string $key   key to set as the cache value.
     * @param  mixed  $value returns the value of the cached item.
     * @param  integer  $expiration when the cache should expire (unix timestamp)
     * @return $this
     */
    public function set($key, $value, $expiration = 0)
    {
        $key = $this->createKey($key);
        $this->instance->set($key, $value, $expiration);
        return $this;
    }

    /**
     * Must implement a get method.
     *
     * @param  string $key   Get a cached item by key.
     * @return mixed         Returns cached item or false.
     */
    public function get($key)
    {
        $key = $this->createKey($key);
        return $this->instance->get($key);
    }

    /**
     * Must implement a delete method.
     *
     * @param  string $key delete a specific cached item by key.
     * @return $this
     */
    public function delete($key)
    {
        $this->instance->delete($this->createKey($key));
        return $this;
    }

    /**
     * Clear all of the values set by this cache instance.
     *
     * @return $this
     */
    public function clear()
    {
        $this->instance->delete('memcached_adapter_namespace');
        $this->key(true);
        return $this;
    }

    /**
     * Return the Memcached instance.
     *
     * @return \Memcached
     */
    public function getInstance()
    {
        return $this->instance;
    }

    /**
     * Get the value of a namespace key.
     *
     * @return string
     */
    public function key($reset = false)
    {
        static $key;
        $key = $reset ? false : $key;
        if (!$key) {
            $key = $this->instance->get('memcached_adapter_namespace', function ($memc, $key, &$value) {
                $value = bin2hex(openssl_random_pseudo_bytes(8));
                return true;
            });
        }
        return $key;
    }

    /**
     * Given a user provided key, return a namespaced key.
     *
     * @return string
     */
    public function createKey($key)
    {
        return $this->key() . "-" . $key;
    }
}


1		<?php
2
3		namespace Journey\Cache\Adapters;
4
5		use Journey\Cache\CacheAdapterInterface;
6		use Memcached;
7
8		class MemcachedAdapter implements CacheAdapterInterface
9		{
10		/**
11		* Instance of memcached.
12		*
13		* @var \Memcached
14		*/
15		protected $instance;
16
17		/**
18		* Initialize a new localcache.
19		*
20		* @param string $filepath
		0 ignored issues – show Bug introduced 2017-02-09 03:49 UTC by Report Bug Copy Issue Report Show Similar Issues like this There is no parameter named `$filepath`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
21		*/
22	6	public function __construct(array $config)
23		{
24	6	$this->config = $config;
		0 ignored issues – show Bug introduced 2017-02-09 03:49 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `config` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
25	6	$this->instance = new Memcached();
26	6	if ($config['servers']) {
27	6	foreach ($config['servers'] as $server) {
28	6	$this->instance->addServer($server['host'], $server['port']);
29	6	}
30	6	}
31	6	}
32
33		/**
34		* Must implement a set method.
35		*
36		* @param string $key key to set as the cache value.
37		* @param mixed $value returns the value of the cached item.
38		* @param integer $expiration when the cache should expire (unix timestamp)
39		* @return $this
40		*/
41	4	public function set($key, $value, $expiration = 0)
42		{
43	4	$key = $this->createKey($key);
44	4	$this->instance->set($key, $value, $expiration);
45	4	return $this;
46		}
47
48		/**
49		* Must implement a get method.
50		*
51		* @param string $key Get a cached item by key.
52		* @return mixed Returns cached item or false.
53		*/
54	4	public function get($key)
55		{
56	4	$key = $this->createKey($key);
57	4	return $this->instance->get($key);
58		}
59
60		/**
61		* Must implement a delete method.
62		*
63		* @param string $key delete a specific cached item by key.
64		* @return $this
65		*/
66	1	public function delete($key)
67		{
68	1	$this->instance->delete($this->createKey($key));
69	1	return $this;
70		}
71
72		/**
73		* Clear all of the values set by this cache instance.
74		*
75		* @return $this
76		*/
77	6	public function clear()
78		{
79	6	$this->instance->delete('memcached_adapter_namespace');
80	6	$this->key(true);
81	6	return $this;
82		}
83
84		/**
85		* Return the Memcached instance.
86		*
87		* @return \Memcached
88		*/
89	1	public function getInstance()
90		{
91	1	return $this->instance;
92		}
93
94		/**
95		* Get the value of a namespace key.
96		*
97		* @return string
98		*/
99	6	public function key($reset = false)
100		{
101	6	static $key;
102	6	$key = $reset ? false : $key;
103	6	if (!$key) {
104	6	$key = $this->instance->get('memcached_adapter_namespace', function ($memc, $key, &$value) {
105	6	$value = bin2hex(openssl_random_pseudo_bytes(8));
106	6	return true;
107	6	});
108	6	}
109	6	return $key;
110		}
111
112		/**
113		* Given a user provided key, return a namespaced key.
114		*
115		* @return string
116		*/
117	4	public function createKey($key)
118		{
119	4	return $this->key() . "-" . $key;
120		}
121		}
122

journeygroup / cache

Issues (4)

Security Analysis no request data

src/Adapters/MemcachedAdapter.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like