Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
7 | class RootPackage extends AbstractPackage |
||
8 | { |
||
9 | private $packages; |
||
10 | private $installedPackagesFile; |
||
11 | |||
12 | public function __construct(string $dirPath, JsonObject $config) |
||
16 | |||
17 | public static function createFromPath(string $dirPath) : self |
||
21 | |||
22 | /** |
||
23 | * Returns all packages in the project, including the root one |
||
24 | */ |
||
25 | public function getPackages() : PackageCollection |
||
40 | |||
41 | public function getLockFile() : LockFile |
||
49 | |||
50 | View Code Duplication | public function getInstalledPackagesFile() : InstalledPackagesFile |
|
61 | |||
62 | public function getVendorDir() : string |
||
66 | |||
67 | public function getVendorPath(string $relativePath = '') : string |
||
71 | } |
||
72 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.