Package::create() - Code Metrics - joshdifabio/composed - Measure and Improve Code Quality continuously with Scrutinizer

Package::create() A
last analyzed 2016-11-14 12:22 UTC

↳ Parent: Package

Complexity

Conditions	2
Paths	2

Size

Total Lines	9
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	5
nc	2
nop	2
dl	0
loc	9
rs	9.6666
c	0
b	0
f	0

<?php
namespace Composed;

/**
 * @author Josh Di Fabio <[email protected]>
 */
class Package extends AbstractPackage
{
    public static function create(RootPackage $root, JsonObject $packageConfig) : self
    {
        if (null === $packageName = $packageConfig->get('name')) {
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            throw new \InvalidArgumentException('Package data must include package name');
        }
        $dirPath = $root->getVendorPath(str_replace('/', DIRECTORY_SEPARATOR, $packageConfig->get('name')));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        return new static($root, $dirPath, $packageConfig);
    }

    public static function fromArray(RootPackage $root, array $packageConfig) : self
    {
        return self::create($root, JsonObject::fromArray($packageConfig));
    }
}


1			<?php
2			namespace Composed;
3
4			/**
5			* @author Josh Di Fabio <[email protected]>
6			*/
7			class Package extends AbstractPackage
8			{
9			public static function create(RootPackage $root, JsonObject $packageConfig) : self
10			{
11			if (null === $packageName = $packageConfig->get('name')) {
			0 ignored issues – show Documentation introduced 2016-05-11 14:43 UTC by Report Bug Copy Issue Report `'name'` is of type `string`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
12			throw new \InvalidArgumentException('Package data must include package name');
13			}
14			$dirPath = $root->getVendorPath(str_replace('/', DIRECTORY_SEPARATOR, $packageConfig->get('name')));
			0 ignored issues – show Documentation introduced 2016-05-11 14:43 UTC by Report Bug Copy Issue Report `'name'` is of type `string`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
15
16			return new static($root, $dirPath, $packageConfig);
17			}
18
19			public static function fromArray(RootPackage $root, array $packageConfig) : self
20			{
21			return self::create($root, JsonObject::fromArray($packageConfig));
22			}
23			}
24

joshdifabio / composed

Package::create() A last analyzed 2016-11-14 12:22 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

Package::create() A
last analyzed 2016-11-14 12:22 UTC