ApplicationServiceProvider - Code Metrics - Inspection of "Add the CLI input object to our CLI app constructo..." - joomla/statistics-server - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ffa9dc...74dfa6 )

by Michael

created 2016-09-02 14:42 UTC

ApplicationServiceProvider C

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	326
Duplicated Lines	29.14 %

Coupling/Cohesion

Components	0
Dependencies	26

Test Coverage

Coverage

49.73%

Importance

Changes	21
Bugs	2	Features	12

Metric	Value
wmc	2
c	21
b	2
f	12
lcom	0
cbo	26
dl	95
loc	326
ccs	93
cts	187
cp	0.4973
rs	5

1 Method

Rating	Name	Duplication	Size	Complexity
B	register()	95	314	2

How to fix Duplicated Code

<?php

namespace Stats\Providers;

use Doctrine\Common\Cache\Cache;
use Joomla\Application as JoomlaApplication;
use Joomla\Database\DatabaseDriver;
use Joomla\DI\Container;
use Joomla\DI\ServiceProviderInterface;
use Joomla\Input\Cli;
use Joomla\Input\Input;
use Psr\Log\LoggerInterface;
use Stats\CliApplication;
use Stats\Commands\Cache\ClearCommand;
use Stats\Commands\Database\MigrateCommand;
use Stats\Commands\Database\StatusCommand;
use Stats\Commands\Tags\JoomlaCommand;
use Stats\Commands\HelpCommand;
use Stats\Commands\InstallCommand;
use Stats\Commands\SnapshotCommand;
use Stats\Commands\UpdateCommand;
use Stats\Console;
use Stats\Controllers\DisplayControllerGet;
use Stats\Controllers\SubmitControllerCreate;
use Stats\Controllers\SubmitControllerGet;
use Stats\Database\Migrations;
use Stats\GitHub\GitHub;
use Stats\Models\StatsModel;
use Stats\Router;
use Stats\Views\Stats\StatsJsonView;
use Stats\WebApplication;
use TheIconic\Tracking\GoogleAnalytics\Analytics;

/**
 * Application service provider
 *
 * @since  1.0
 */
class ApplicationServiceProvider implements ServiceProviderInterface
{
	/**
	 * Registers the service provider with a DI container.
	 *
	 * @param   Container  $container  The DI container.
	 *
	 * @return  void
	 *
	 * @since   1.0
	 */
	public function register(Container $container)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
	{
		$container->alias(CliApplication::class, JoomlaApplication\AbstractCliApplication::class)
			->share(
				JoomlaApplication\AbstractCliApplication::class,
				function (Container $container)
				{
					$application = new CliApplication(
						$container->get(Cli::class),
						$container->get('config'),
						$container->get(JoomlaApplication\Cli\CliOutput::class),
						$container->get(JoomlaApplication\Cli\CliInput::class),
						$container->get(Console::class)
					);

					// Inject extra services
					$application->setContainer($container);
					$application->setLogger($container->get('monolog.logger.cli'));

					return $application;
				},
				true
			);

		$container->alias(WebApplication::class, JoomlaApplication\AbstractWebApplication::class)
			->share(
				JoomlaApplication\AbstractWebApplication::class,
				function (Container $container)
				{
					$application = new WebApplication($container->get(Input::class), $container->get('config'));

					// Inject extra services
					$application->setAnalytics($container->get(Analytics::class));
					$application->setLogger($container->get('monolog.logger.application'));
					$application->setRouter($container->get(Router::class));

					return $application;
				},
				true
			);

		$container->share(
			Input::class,
			function ()
			{
				return new Input($_REQUEST);
			},
			true
		);

		$container->share(
			Cli::class,
			function ()
			{
				return new Cli;
			},
			true
		);

		$container->share(
			Console::class,
			function (Container $container)
			{
				$console = new Console;
				$console->setContainer($container);

				return $console;
			}
		);

		$container->share(
			JoomlaApplication\Cli\Output\Processor\ColorProcessor::class,
			function (Container $container)
			{
				$processor = new JoomlaApplication\Cli\Output\Processor\ColorProcessor;

				/** @var Input $input */
				$input = $container->get(Cli::class);

				if ($input->get('nocolors'))
				{
					$processor->noColors = true;
				}

				// Setup app colors (also required in "nocolors" mode - to strip them).
				$processor->addStyle('title', new JoomlaApplication\Cli\ColorStyle('yellow', '', ['bold']));

				return $processor;
			}
		);

		$container->share(
			JoomlaApplication\Cli\CliInput::class,
			function (Container $container)

			{
				return new JoomlaApplication\Cli\CliInput;
			}
		);

		$container->alias(JoomlaApplication\Cli\CliOutput::class, JoomlaApplication\Cli\Output\Stdout::class)
			->share(
				JoomlaApplication\Cli\Output\Stdout::class,
				function (Container $container)
				{
					return new JoomlaApplication\Cli\Output\Stdout($container->get(JoomlaApplication\Cli\Output\Processor\ColorProcessor::class));
				}
			);

		$container->share(
			Analytics::class,
			function ()
			{
				return new Analytics(true);
			}
		);

		$container->share(
			Router::class,
			function (Container $container)
			{
				$router = (new Router($container->get(Input::class)))
					->setContainer($container)
					->setControllerPrefix('Stats\\Controllers\\')
					->setDefaultController('DisplayController')
					->addMap('/submit', 'SubmitController')
					->addMap('/:source', 'DisplayController');

				return $router;
			},
			true
		);

		$container->share(
			HelpCommand::class,
			function (Container $container)

			{
				$command = new HelpCommand;

				$command->setApplication($container->get(JoomlaApplication\AbstractApplication::class));
				$command->setInput($container->get(Input::class));

				return $command;
			},
			true
		);

		$container->share(
			InstallCommand::class,
			function (Container $container)

			{
				$command = new InstallCommand($container->get(DatabaseDriver::class));

				$command->setApplication($container->get(JoomlaApplication\AbstractApplication::class));
				$command->setInput($container->get(Input::class));

				return $command;
			},
			true
		);

		$container->share(
			SnapshotCommand::class,
			function (Container $container)

			{
				$command = new SnapshotCommand($container->get(StatsJsonView::class));

				$command->setApplication($container->get(JoomlaApplication\AbstractApplication::class));
				$command->setInput($container->get(Input::class));

				return $command;
			},
			true
		);

		$container->share(
			UpdateCommand::class,
			function (Container $container)

			{
				$command = new UpdateCommand;

				$command->setApplication($container->get(JoomlaApplication\AbstractApplication::class));
				$command->setInput($container->get(Input::class));

				return $command;
			},
			true
		);

		$container->share(
			ClearCommand::class,
			function (Container $container)

			{
				$command = new ClearCommand($container->get(Cache::class));

				$command->setApplication($container->get(JoomlaApplication\AbstractApplication::class));
				$command->setInput($container->get(Input::class));

				return $command;
			},
			true
		);

		$container->share(
			MigrateCommand::class,
			function (Container $container)
			{
				$command = new MigrateCommand($container->get(Migrations::class));

				$command->setApplication($container->get(JoomlaApplication\AbstractApplication::class));
				$command->setInput($container->get(Input::class));
				$command->setLogger($container->get(LoggerInterface::class));

				return $command;
			},
			true
		);

		$container->share(
			StatusCommand::class,
			function (Container $container)

			{
				$command = new StatusCommand($container->get(Migrations::class));

				$command->setApplication($container->get(JoomlaApplication\AbstractApplication::class));
				$command->setInput($container->get(Input::class));

				return $command;
			},
			true
		);

		$container->share(
			JoomlaCommand::class,
			function (Container $container)

			{
				$command = new JoomlaCommand($container->get(GitHub::class));

				$command->setApplication($container->get(JoomlaApplication\AbstractApplication::class));
				$command->setInput($container->get(Input::class));

				return $command;
			},
			true
		);

		$container->share(
			DisplayControllerGet::class,
			function (Container $container)

			{
				$controller = new DisplayControllerGet(
					$container->get(StatsJsonView::class),
					$container->get(Cache::class)
				);

				$controller->setApplication($container->get(JoomlaApplication\AbstractApplication::class));
				$controller->setInput($container->get(Input::class));

				return $controller;
			},
			true
		);

		$container->share(
			SubmitControllerCreate::class,
			function (Container $container)

			{
				$controller = new SubmitControllerCreate(
					$container->get(StatsModel::class)
				);

				$controller->setApplication($container->get(JoomlaApplication\AbstractApplication::class));
				$controller->setInput($container->get(Input::class));

				return $controller;
			},
			true
		);

		$container->share(
			SubmitControllerGet::class,
			function (Container $container)

			{
				$controller = new SubmitControllerGet;

				$controller->setApplication($container->get(JoomlaApplication\AbstractApplication::class));
				$controller->setInput($container->get(Input::class));

				return $controller;
			},
			true
		);

		$container->share(
			StatsModel::class,
			function (Container $container)
			{
				return new StatsModel(
					$container->get(DatabaseDriver::class)
				);
			},
			true
		);

		$container->share(
			StatsJsonView::class,
			function (Container $container)
			{
				return new StatsJsonView(
					$container->get(StatsModel::class)
				);
			},
			true
		);
	}
}


1			<?php
2
3			namespace Stats\Providers;
4
5			use Doctrine\Common\Cache\Cache;
6			use Joomla\Application as JoomlaApplication;
7			use Joomla\Database\DatabaseDriver;
8			use Joomla\DI\Container;
9			use Joomla\DI\ServiceProviderInterface;
10			use Joomla\Input\Cli;
11			use Joomla\Input\Input;
12			use Psr\Log\LoggerInterface;
13			use Stats\CliApplication;
14			use Stats\Commands\Cache\ClearCommand;
15			use Stats\Commands\Database\MigrateCommand;
16			use Stats\Commands\Database\StatusCommand;
17			use Stats\Commands\Tags\JoomlaCommand;
18			use Stats\Commands\HelpCommand;
19			use Stats\Commands\InstallCommand;
20			use Stats\Commands\SnapshotCommand;
21			use Stats\Commands\UpdateCommand;
22			use Stats\Console;
23			use Stats\Controllers\DisplayControllerGet;
24			use Stats\Controllers\SubmitControllerCreate;
25			use Stats\Controllers\SubmitControllerGet;
26			use Stats\Database\Migrations;
27			use Stats\GitHub\GitHub;
28			use Stats\Models\StatsModel;
29			use Stats\Router;
30			use Stats\Views\Stats\StatsJsonView;
31			use Stats\WebApplication;
32			use TheIconic\Tracking\GoogleAnalytics\Analytics;
33
34			/**
35			* Application service provider
36			*
37			* @since 1.0
38			*/
39			class ApplicationServiceProvider implements ServiceProviderInterface
40			{
41			/**
42			* Registers the service provider with a DI container.
43			*
44			* @param Container $container The DI container.
45			*
46			* @return void
47			*
48			* @since 1.0
49			*/
50	1		public function register(Container $container)
			0 ignored issues – show Coding Style introduced 2016-01-02 17:06 UTC by Report Bug Copy Issue Report `register` uses the super-global variable `$_REQUEST` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
51			{
52	1		$container->alias(CliApplication::class, JoomlaApplication\AbstractCliApplication::class)
53	1		->share(
54	1		JoomlaApplication\AbstractCliApplication::class,
55			function (Container $container)
56			{
57			$application = new CliApplication(
58			$container->get(Cli::class),
59			$container->get('config'),
60			$container->get(JoomlaApplication\Cli\CliOutput::class),
61			$container->get(JoomlaApplication\Cli\CliInput::class),
62			$container->get(Console::class)
63			);
64
65			// Inject extra services
66			$application->setContainer($container);
67			$application->setLogger($container->get('monolog.logger.cli'));
68
69			return $application;
70	1		},
71			true
72	1		);
73
74	1		$container->alias(WebApplication::class, JoomlaApplication\AbstractWebApplication::class)
75	1		->share(
76	1		JoomlaApplication\AbstractWebApplication::class,
77			function (Container $container)
78			{
79			$application = new WebApplication($container->get(Input::class), $container->get('config'));
80
81			// Inject extra services
82			$application->setAnalytics($container->get(Analytics::class));
83			$application->setLogger($container->get('monolog.logger.application'));
84			$application->setRouter($container->get(Router::class));
85
86			return $application;
87	1		},
88			true
89	1		);
90
91	1		$container->share(
92	1		Input::class,
93			function ()
94			{
95			return new Input($_REQUEST);
96	1		},
97			true
98	1		);
99
100	1		$container->share(
101	1		Cli::class,
102			function ()
103			{
104			return new Cli;
105	1		},
106			true
107	1		);
108
109	1		$container->share(
110	1		Console::class,
111			function (Container $container)
112			{
113			$console = new Console;
114			$console->setContainer($container);
115
116			return $console;
117			}
118	1		);
119
120	1		$container->share(
121	1		JoomlaApplication\Cli\Output\Processor\ColorProcessor::class,
122			function (Container $container)
123			{
124			$processor = new JoomlaApplication\Cli\Output\Processor\ColorProcessor;
125
126			/** @var Input $input */
127			$input = $container->get(Cli::class);
128
129			if ($input->get('nocolors'))
130			{
131			$processor->noColors = true;
132			}
133
134			// Setup app colors (also required in "nocolors" mode - to strip them).
135			$processor->addStyle('title', new JoomlaApplication\Cli\ColorStyle('yellow', '', ['bold']));
136
137			return $processor;
138			}
139	1		);
140
141	1		$container->share(
142	1		JoomlaApplication\Cli\CliInput::class,
143			function (Container $container)
			0 ignored issues – show Unused Code introduced 2016-09-02 14:45 UTC by Report Bug Copy Issue Report The parameter `$container` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
144			{
145			return new JoomlaApplication\Cli\CliInput;
146			}
147	1		);
148
149	1		$container->alias(JoomlaApplication\Cli\CliOutput::class, JoomlaApplication\Cli\Output\Stdout::class)
150	1		->share(
151	1		JoomlaApplication\Cli\Output\Stdout::class,
152			function (Container $container)
153			{
154			return new JoomlaApplication\Cli\Output\Stdout($container->get(JoomlaApplication\Cli\Output\Processor\ColorProcessor::class));
155			}
156	1		);
157
158	1		$container->share(
159	1		Analytics::class,
160			function ()
161			{
162			return new Analytics(true);
163			}
164	1		);
165
166	1		$container->share(
167	1		Router::class,
168			function (Container $container)
169			{
170			$router = (new Router($container->get(Input::class)))
171			->setContainer($container)
172			->setControllerPrefix('Stats\\Controllers\\')
173			->setDefaultController('DisplayController')
174			->addMap('/submit', 'SubmitController')
175			->addMap('/:source', 'DisplayController');
176
177			return $router;
178	1		},
179			true
180	1		);
181
182	1		$container->share(
183	1		HelpCommand::class,
184		View Code Duplication	function (Container $container)
			0 ignored issues – show Duplication introduced 2016-03-15 00:41 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
185			{
186			$command = new HelpCommand;
187
188			$command->setApplication($container->get(JoomlaApplication\AbstractApplication::class));
189			$command->setInput($container->get(Input::class));
190
191			return $command;
192	1		},
193			true
194	1		);
195
196	1		$container->share(
197	1		InstallCommand::class,
198		View Code Duplication	function (Container $container)
			0 ignored issues – show Duplication introduced 2016-06-18 14:46 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
199			{
200			$command = new InstallCommand($container->get(DatabaseDriver::class));
201
202			$command->setApplication($container->get(JoomlaApplication\AbstractApplication::class));
203			$command->setInput($container->get(Input::class));
204
205			return $command;
206	1		},
207			true
208	1		);
209
210	1		$container->share(
211	1		SnapshotCommand::class,
212		View Code Duplication	function (Container $container)
			0 ignored issues – show Duplication introduced 2016-05-07 22:21 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
213			{
214			$command = new SnapshotCommand($container->get(StatsJsonView::class));
215
216			$command->setApplication($container->get(JoomlaApplication\AbstractApplication::class));
217			$command->setInput($container->get(Input::class));
218
219			return $command;
220	1		},
221			true
222	1		);
223
224	1		$container->share(
225	1		UpdateCommand::class,
226		View Code Duplication	function (Container $container)
			0 ignored issues – show Duplication introduced 2016-09-02 14:45 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
227			{
228			$command = new UpdateCommand;
229
230			$command->setApplication($container->get(JoomlaApplication\AbstractApplication::class));
231			$command->setInput($container->get(Input::class));
232
233			return $command;
234	1		},
235			true
236	1		);
237
238	1		$container->share(
239	1		ClearCommand::class,
240		View Code Duplication	function (Container $container)
			0 ignored issues – show Duplication introduced 2016-07-23 18:06 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
241			{
242			$command = new ClearCommand($container->get(Cache::class));
243
244			$command->setApplication($container->get(JoomlaApplication\AbstractApplication::class));
245			$command->setInput($container->get(Input::class));
246
247			return $command;
248	1		},
249			true
250	1		);
251
252	1		$container->share(
253	1		MigrateCommand::class,
254			function (Container $container)
255			{
256			$command = new MigrateCommand($container->get(Migrations::class));
257
258			$command->setApplication($container->get(JoomlaApplication\AbstractApplication::class));
259			$command->setInput($container->get(Input::class));
260			$command->setLogger($container->get(LoggerInterface::class));
261
262			return $command;
263	1		},
264			true
265	1		);
266
267	1		$container->share(
268	1		StatusCommand::class,
269		View Code Duplication	function (Container $container)
			0 ignored issues – show Duplication introduced 2016-06-18 14:17 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
270			{
271			$command = new StatusCommand($container->get(Migrations::class));
272
273			$command->setApplication($container->get(JoomlaApplication\AbstractApplication::class));
274			$command->setInput($container->get(Input::class));
275
276			return $command;
277	1		},
278			true
279	1		);
280
281	1		$container->share(
282	1		JoomlaCommand::class,
283		View Code Duplication	function (Container $container)
			0 ignored issues – show Duplication introduced 2016-09-02 14:45 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
284			{
285			$command = new JoomlaCommand($container->get(GitHub::class));
286
287			$command->setApplication($container->get(JoomlaApplication\AbstractApplication::class));
288			$command->setInput($container->get(Input::class));
289
290			return $command;
291	1		},
292			true
293	1		);
294
295	1		$container->share(
296	1		DisplayControllerGet::class,
297		View Code Duplication	function (Container $container)
			0 ignored issues – show Duplication introduced 2016-09-02 14:45 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
298			{
299			$controller = new DisplayControllerGet(
300			$container->get(StatsJsonView::class),
301			$container->get(Cache::class)
302			);
303
304			$controller->setApplication($container->get(JoomlaApplication\AbstractApplication::class));
305			$controller->setInput($container->get(Input::class));
306
307			return $controller;
308	1		},
309			true
310	1		);
311
312	1		$container->share(
313	1		SubmitControllerCreate::class,
314		View Code Duplication	function (Container $container)
			0 ignored issues – show Duplication introduced 2016-07-23 18:06 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
315			{
316			$controller = new SubmitControllerCreate(
317			$container->get(StatsModel::class)
318			);
319
320			$controller->setApplication($container->get(JoomlaApplication\AbstractApplication::class));
321			$controller->setInput($container->get(Input::class));
322
323			return $controller;
324	1		},
325			true
326	1		);
327
328	1		$container->share(
329	1		SubmitControllerGet::class,
330		View Code Duplication	function (Container $container)
			0 ignored issues – show Duplication introduced 2016-05-07 22:21 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
331			{
332			$controller = new SubmitControllerGet;
333
334			$controller->setApplication($container->get(JoomlaApplication\AbstractApplication::class));
335			$controller->setInput($container->get(Input::class));
336
337			return $controller;
338	1		},
339			true
340	1		);
341
342	1		$container->share(
343	1		StatsModel::class,
344			function (Container $container)
345			{
346			return new StatsModel(
347			$container->get(DatabaseDriver::class)
348			);
349	1		},
350			true
351	1		);
352
353	1		$container->share(
354	1		StatsJsonView::class,
355	1		function (Container $container)
356			{
357			return new StatsJsonView(
358			$container->get(StatsModel::class)
359			);
360	1		},
361			true
362	1		);
363	1		}
364			}
365

joomla / statistics-server

Push — master ( ffa9dc...74dfa6 )

ApplicationServiceProvider C

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

1 Method

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like