Inspection of "Add support for timeframe parameter" - joomla/statistics-server - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — timeframe ( a42a55 )

unknown

created 2022-04-12 12:08 UTC

Status

Spacing +9 added lines, -9 removed lines patch added patch discarded remove patch

@@ -64,7 +64,7 @@  discard block
 block discarded – undo
 			return $this->db->setQuery(
 				$this->db->getQuery(true)
 					->select('*')
-					->from($this->db->quoteName('#__jstats_counter_' . $column))
+					->from($this->db->quoteName('#__jstats_counter_'.$column))
 			)->loadAssocList();
 		}
 
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
 			$return[$column] = $this->db->setQuery(
 				$this->db->getQuery(true)
 					->select('*')
-					->from($this->db->quoteName('#__jstats_counter_' . $column))
+					->from($this->db->quoteName('#__jstats_counter_'.$column))
 			)->loadAssocList();
 		}
 
@@ -101,7 +101,7 @@  discard block
 block discarded – undo
 				$return[$column] = $this->db->setQuery(
 					$this->db->getQuery(true)
 						->select($column)
-						->select('COUNT(' . $column . ') AS count')
+						->select('COUNT('.$column.') AS count')
 						->from($this->db->quoteName('#__jstats'))
 						->where('modified BETWEEN DATE_SUB(NOW(), INTERVAL 90 DAY) AND NOW()')
 						->group($column)
@@ -113,11 +113,11 @@  discard block
 block discarded – undo
 			{
 				$return['cms_php_version'] = $this->db->setQuery(
 					$this->db->getQuery(true)
-						->select('CONCAT(' . $db->qn('cms_version') . ', ' . $db->q(' - ') . ', ' . $db->qn('php_version') . ') AS cms_php_version')
+						->select('CONCAT('.$db->qn('cms_version').', '.$db->q(' - ').', '.$db->qn('php_version').') AS cms_php_version')
 						->select('COUNT(*) AS count')
 						->from($this->db->quoteName('#__jstats'))
 						->where('modified BETWEEN DATE_SUB(NOW(), INTERVAL 90 DAY) AND NOW()')
-						->group('CONCAT(' . $db->qn('cms_version') . ', ' . $db->q(' - ') . ', ' . $db->qn('php_version') . ')')
+						->group('CONCAT('.$db->qn('cms_version').', '.$db->q(' - ').', '.$db->qn('php_version').')')
 				)->loadAssocList();
 				continue;
 			}
@@ -126,11 +126,11 @@  discard block
 block discarded – undo
 			{
 				$return['db_type_version'] = $this->db->setQuery(
 					$this->db->getQuery(true)
-						->select('CONCAT(' . $db->qn('db_type') . ', ' . $db->q(' - ') . ', ' . $db->qn('db_version') . ') AS db_type_version')
+						->select('CONCAT('.$db->qn('db_type').', '.$db->q(' - ').', '.$db->qn('db_version').') AS db_type_version')
 						->select('COUNT(*) AS count')
 						->from($this->db->quoteName('#__jstats'))
 						->where('modified BETWEEN DATE_SUB(NOW(), INTERVAL 90 DAY) AND NOW()')
-						->group('CONCAT(' . $db->qn('db_type') . ', ' . $db->q(' - ') . ', ' . $db->qn('db_version') . ')')
+						->group('CONCAT('.$db->qn('db_type').', '.$db->q(' - ').', '.$db->qn('db_version').')')
 				)->loadAssocList();
 				continue;
 			}
@@ -167,8 +167,8 @@  discard block
 block discarded – undo
             $return[$column] = $this->db->setQuery(
               $this->db->getQuery(true)
                        ->select($column)
-                       ->select('COUNT(' . $column . ') AS count')
-                       ->from('(SELECT * FROM ' . $this->db->quoteName('#__jstats') . ' WHERE modified > DATE_SUB(NOW(), INTERVAL ' . $this->db->quote($timeframe) .' DAY)) AS tmptable')
+                       ->select('COUNT('.$column.') AS count')
+                       ->from('(SELECT * FROM '.$this->db->quoteName('#__jstats').' WHERE modified > DATE_SUB(NOW(), INTERVAL '.$this->db->quote($timeframe).' DAY)) AS tmptable')
                        ->group($column)
             )->loadAssocList();
         }

Please login to merge, or discard this patch.

		@@ -64,7 +64,7 @@ discard block
		block discarded – undo
64	64	return $this->db->setQuery(
65	65	$this->db->getQuery(true)
66	66	->select('*')
67		- ->from($this->db->quoteName('#__jstats_counter_' . $column))
	67	+ ->from($this->db->quoteName('#__jstats_counter_'.$column))
68	68	)->loadAssocList();
69	69	}
70	70
		@@ -75,7 +75,7 @@ discard block
		block discarded – undo
75	75	$return[$column] = $this->db->setQuery(
76	76	$this->db->getQuery(true)
77	77	->select('*')
78		- ->from($this->db->quoteName('#__jstats_counter_' . $column))
	78	+ ->from($this->db->quoteName('#__jstats_counter_'.$column))
79	79	)->loadAssocList();
80	80	}
81	81
		@@ -101,7 +101,7 @@ discard block
		block discarded – undo
101	101	$return[$column] = $this->db->setQuery(
102	102	$this->db->getQuery(true)
103	103	->select($column)
104		- ->select('COUNT(' . $column . ') AS count')
	104	+ ->select('COUNT('.$column.') AS count')
105	105	->from($this->db->quoteName('#__jstats'))
106	106	->where('modified BETWEEN DATE_SUB(NOW(), INTERVAL 90 DAY) AND NOW()')
107	107	->group($column)
		@@ -113,11 +113,11 @@ discard block
		block discarded – undo
113	113	{
114	114	$return['cms_php_version'] = $this->db->setQuery(
115	115	$this->db->getQuery(true)
116		- ->select('CONCAT(' . $db->qn('cms_version') . ', ' . $db->q(' - ') . ', ' . $db->qn('php_version') . ') AS cms_php_version')
	116	+ ->select('CONCAT('.$db->qn('cms_version').', '.$db->q(' - ').', '.$db->qn('php_version').') AS cms_php_version')
117	117	->select('COUNT(*) AS count')
118	118	->from($this->db->quoteName('#__jstats'))
119	119	->where('modified BETWEEN DATE_SUB(NOW(), INTERVAL 90 DAY) AND NOW()')
120		- ->group('CONCAT(' . $db->qn('cms_version') . ', ' . $db->q(' - ') . ', ' . $db->qn('php_version') . ')')
	120	+ ->group('CONCAT('.$db->qn('cms_version').', '.$db->q(' - ').', '.$db->qn('php_version').')')
121	121	)->loadAssocList();
122	122	continue;
123	123	}
		@@ -126,11 +126,11 @@ discard block
		block discarded – undo
126	126	{
127	127	$return['db_type_version'] = $this->db->setQuery(
128	128	$this->db->getQuery(true)
129		- ->select('CONCAT(' . $db->qn('db_type') . ', ' . $db->q(' - ') . ', ' . $db->qn('db_version') . ') AS db_type_version')
	129	+ ->select('CONCAT('.$db->qn('db_type').', '.$db->q(' - ').', '.$db->qn('db_version').') AS db_type_version')
130	130	->select('COUNT(*) AS count')
131	131	->from($this->db->quoteName('#__jstats'))
132	132	->where('modified BETWEEN DATE_SUB(NOW(), INTERVAL 90 DAY) AND NOW()')
133		- ->group('CONCAT(' . $db->qn('db_type') . ', ' . $db->q(' - ') . ', ' . $db->qn('db_version') . ')')
	133	+ ->group('CONCAT('.$db->qn('db_type').', '.$db->q(' - ').', '.$db->qn('db_version').')')
134	134	)->loadAssocList();
135	135	continue;
136	136	}
		@@ -167,8 +167,8 @@ discard block
		block discarded – undo
167	167	$return[$column] = $this->db->setQuery(
168	168	$this->db->getQuery(true)
169	169	->select($column)
170		- ->select('COUNT(' . $column . ') AS count')
171		- ->from('(SELECT * FROM ' . $this->db->quoteName('#__jstats') . ' WHERE modified > DATE_SUB(NOW(), INTERVAL ' . $this->db->quote($timeframe) .' DAY)) AS tmptable')
	170	+ ->select('COUNT('.$column.') AS count')
	171	+ ->from('(SELECT * FROM '.$this->db->quoteName('#__jstats').' WHERE modified > DATE_SUB(NOW(), INTERVAL '.$this->db->quote($timeframe).' DAY)) AS tmptable')
172	172	->group($column)
173	173	)->loadAssocList();
174	174	}

joomla / statistics-server

Push — timeframe ( a42a55 )

Status

Category

Spacing +9 added lines, -9 removed lines patch added patch discarded remove patch