ApplicationServiceProvider - Code Metrics - Inspection of "Cover the private method" - joomla/statistics-server - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 8961be...e7d2ec )

by Michael

created 2016-11-06 18:49 UTC

ApplicationServiceProvider C

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	517
Duplicated Lines	20.12 %

Coupling/Cohesion

Components	0
Dependencies	27

Test Coverage

Coverage

98.68%

Importance

Changes	7
Bugs	0	Features	0

Metric	Value
wmc	26
lcom	0
cbo	27
dl	104
loc	517
ccs	149
cts	151
cp	0.9868
rs	5
c	7
b	0
f	0

25 Methods

Rating	Name	Duplication	Size	Complexity
A	register()	0	56	1
A	getAnalyticsService()	0	4	1
A	getCacheClearCommandService()	9	9	1
A	getCliApplicationService()	0	16	1
A	getCliInputService()	0	4	1
A	getCliOutputService()	0	4	1
A	getColorProcessorService()	0	17	2
A	getConsoleService()	0	7	1
A	getDatabaseMigrateCommandService()	0	10	1
A	getDatabaseStatusCommandService()	9	9	1
A	getDisplayControllerGetService()	12	12	1
A	getHelpCommandService()	9	9	1
A	getInputCliService()	0	4	1
A	getInputService()	0	4	1
A	getInstallCommandService()	9	9	1
A	getRouterService()	0	12	1
A	getSnapshotCommandService()	9	9	1
A	getStatsJsonViewService()	0	6	1
A	getStatsModelService()	0	6	1
A	getSubmitControllerCreateService()	11	11	1
A	getSubmitControllerGetService()	9	9	1
A	getTagsJoomlaCommandService()	9	9	1
A	getTagsPhpCommandService()	9	9	1
A	getUpdateCommandService()	9	9	1
A	getWebApplicationService()	0	11	1

How to fix Duplicated Code

<?php

namespace Stats\Providers;

use Joomla\Application as JoomlaApplication;
use Joomla\Database\DatabaseDriver;
use Joomla\DI\Container;
use Joomla\DI\ServiceProviderInterface;
use Joomla\Input\Cli;
use Joomla\Input\Input;
use Psr\Cache\CacheItemPoolInterface;
use Psr\Log\LoggerInterface;
use Stats\CliApplication;
use Stats\Commands as AppCommands;
use Stats\Console;
use Stats\Controllers\DisplayControllerGet;
use Stats\Controllers\SubmitControllerCreate;
use Stats\Controllers\SubmitControllerGet;
use Stats\Database\Migrations;
use Stats\GitHub\GitHub;
use Stats\Models\StatsModel;
use Stats\Router;
use Stats\Views\Stats\StatsJsonView;
use Stats\WebApplication;
use TheIconic\Tracking\GoogleAnalytics\Analytics;

/**
 * Application service provider
 *
 * @since  1.0
 */
class ApplicationServiceProvider implements ServiceProviderInterface
{
	/**
	 * Registers the service provider with a DI container.
	 *
	 * @param   Container  $container  The DI container.
	 *
	 * @return  void
	 *
	 * @since   1.0
	 */
	public function register(Container $container)
	{
		/*
		 * Application Classes
		 */

		$container->alias(CliApplication::class, JoomlaApplication\AbstractCliApplication::class)
			->share(JoomlaApplication\AbstractCliApplication::class, [$this, 'getCliApplicationService'], true);

		$container->alias(WebApplication::class, JoomlaApplication\AbstractWebApplication::class)
			->share(JoomlaApplication\AbstractWebApplication::class, [$this, 'getWebApplicationService'], true);

		/*
		 * Application Class Dependencies
		 */

		$container->share(Analytics::class, [$this, 'getAnalyticsService'], true);
		$container->share(Cli::class, [$this, 'getInputCliService'], true);
		$container->share(Console::class, [$this, 'getConsoleService'], true);
		$container->share(Input::class, [$this, 'getInputService'], true);
		$container->share(JoomlaApplication\Cli\Output\Processor\ColorProcessor::class, [$this, 'getColorProcessorService'], true);
		$container->share(JoomlaApplication\Cli\CliInput::class, [$this, 'getCliInputService'], true);
		$container->share(Router::class, [$this, 'getRouterService'], true);

		$container->alias(JoomlaApplication\Cli\CliOutput::class, JoomlaApplication\Cli\Output\Stdout::class)
			->share(JoomlaApplication\Cli\Output\Stdout::class, [$this, 'getCliOutputService'], true);

		/*
		 * Console Commands
		 */

		$container->share(AppCommands\Cache\ClearCommand::class, [$this, 'getCacheClearCommandService'], true);
		$container->share(AppCommands\HelpCommand::class, [$this, 'getHelpCommandService'], true);
		$container->share(AppCommands\InstallCommand::class, [$this, 'getInstallCommandService'], true);
		$container->share(AppCommands\Database\MigrateCommand::class, [$this, 'getDatabaseMigrateCommandService'], true);
		$container->share(AppCommands\Database\StatusCommand::class, [$this, 'getDatabaseStatusCommandService'], true);
		$container->share(AppCommands\SnapshotCommand::class, [$this, 'getSnapshotCommandService'], true);
		$container->share(AppCommands\Tags\JoomlaCommand::class, [$this, 'getTagsJoomlaCommandService'], true);
		$container->share(AppCommands\Tags\PhpCommand::class, [$this, 'getTagsPhpCommandService'], true);
		$container->share(AppCommands\UpdateCommand::class, [$this, 'getUpdateCommandService'], true);

		/*
		 * MVC Layer
		 */

		// Controllers
		$container->share(DisplayControllerGet::class, [$this, 'getDisplayControllerGetService'], true);
		$container->share(SubmitControllerCreate::class, [$this, 'getSubmitControllerCreateService'], true);
		$container->share(SubmitControllerGet::class, [$this, 'getSubmitControllerGetService'], true);

		// Models
		$container->share(StatsModel::class, [$this, 'getStatsModelService'], true);

		// Views
		$container->share(StatsJsonView::class, [$this, 'getStatsJsonViewService'], true);
	}

	/**
	 * Get the Analytics class service
	 *
	 * @param   Container  $container  The DI container.
	 *
	 * @return  Analytics
	 *
	 * @since   1.0
	 */
	public function getAnalyticsService(Container $container)

	{
		return new Analytics(true);
	}

	/**
	 * Get the Cache\ClearCommand class service
	 *
	 * @param   Container  $container  The DI container.
	 *
	 * @return  AppCommands\Cache\ClearCommand
	 *
	 * @since   1.0
	 */
	public function getCacheClearCommandService(Container $container)

	{
		$command = new AppCommands\Cache\ClearCommand($container->get(CacheItemPoolInterface::class));

		$command->setApplication($container->get(JoomlaApplication\AbstractApplication::class));
		$command->setInput($container->get(Input::class));

		return $command;
	}

	/**
	 * Get the CLI application service
	 *
	 * @param   Container  $container  The DI container.
	 *
	 * @return  CliApplication
	 *
	 * @since   1.0
	 */
	public function getCliApplicationService(Container $container)
	{
		$application = new CliApplication(
			$container->get(Cli::class),
			$container->get('config'),
			$container->get(JoomlaApplication\Cli\CliOutput::class),
			$container->get(JoomlaApplication\Cli\CliInput::class),
			$container->get(Console::class)
		);

		// Inject extra services
		$application->setContainer($container);
		$application->setLogger($container->get('monolog.logger.cli'));

		return $application;
	}

	/**
	 * Get the CliInput class service
	 *
	 * @param   Container  $container  The DI container.
	 *
	 * @return  JoomlaApplication\Cli\CliInput
	 *
	 * @since   1.0
	 */
	public function getCliInputService(Container $container)

	{
		return new JoomlaApplication\Cli\CliInput;
	}

	/**
	 * Get the CliOutput class service
	 *
	 * @param   Container  $container  The DI container.
	 *
	 * @return  JoomlaApplication\Cli\CliOutput
	 *
	 * @since   1.0
	 */
	public function getCliOutputService(Container $container)
	{
		return new JoomlaApplication\Cli\Output\Stdout($container->get(JoomlaApplication\Cli\Output\Processor\ColorProcessor::class));
	}

	/**
	 * Get the ColorProcessor class service
	 *
	 * @param   Container  $container  The DI container.
	 *
	 * @return  JoomlaApplication\Cli\Output\Processor\ColorProcessor
	 *
	 * @since   1.0
	 */
	public function getColorProcessorService(Container $container)
	{
		$processor = new JoomlaApplication\Cli\Output\Processor\ColorProcessor;

		/** @var Input $input */
		$input = $container->get(Cli::class);

		if ($input->getBool('nocolors', false))
		{
			$processor->noColors = true;
		}

		// Setup app colors (also required in "nocolors" mode - to strip them).
		$processor->addStyle('title', new JoomlaApplication\Cli\ColorStyle('yellow', '', ['bold']));

		return $processor;
	}

	/**
	 * Get the console service
	 *
	 * @param   Container  $container  The DI container.
	 *
	 * @return  Console
	 *
	 * @since   1.0
	 */
	public function getConsoleService(Container $container)
	{
		$console = new Console;
		$console->setContainer($container);

		return $console;
	}

	/**
	 * Get the Database\MigrateCommand class service
	 *
	 * @param   Container  $container  The DI container.
	 *
	 * @return  AppCommands\Database\MigrateCommand
	 *
	 * @since   1.0
	 */
	public function getDatabaseMigrateCommandService(Container $container)
	{
		$command = new AppCommands\Database\MigrateCommand($container->get(Migrations::class));

		$command->setApplication($container->get(JoomlaApplication\AbstractApplication::class));
		$command->setInput($container->get(Input::class));
		$command->setLogger($container->get(LoggerInterface::class));

		return $command;
	}

	/**
	 * Get the Database\StatusCommand class service
	 *
	 * @param   Container  $container  The DI container.
	 *
	 * @return  AppCommands\Database\StatusCommand
	 *
	 * @since   1.0
	 */
	public function getDatabaseStatusCommandService(Container $container)

	{
		$command = new AppCommands\Database\StatusCommand($container->get(Migrations::class));

		$command->setApplication($container->get(JoomlaApplication\AbstractApplication::class));
		$command->setInput($container->get(Input::class));

		return $command;
	}

	/**
	 * Get the DisplayControllerGet class service
	 *
	 * @param   Container  $container  The DI container.
	 *
	 * @return  DisplayControllerGet
	 *
	 * @since   1.0
	 */
	public function getDisplayControllerGetService(Container $container)

	{
		$controller = new DisplayControllerGet(
			$container->get(StatsJsonView::class),
			$container->get(CacheItemPoolInterface::class)
		);

		$controller->setApplication($container->get(JoomlaApplication\AbstractApplication::class));
		$controller->setInput($container->get(Input::class));

		return $controller;
	}

	/**
	 * Get the HelpCommand class service
	 *
	 * @param   Container  $container  The DI container.
	 *
	 * @return  AppCommands\HelpCommand
	 *
	 * @since   1.0
	 */
	public function getHelpCommandService(Container $container)

	{
		$command = new AppCommands\HelpCommand;

		$command->setApplication($container->get(JoomlaApplication\AbstractApplication::class));
		$command->setInput($container->get(Input::class));

		return $command;
	}

	/**
	 * Get the Input\Cli class service
	 *
	 * @param   Container  $container  The DI container.
	 *
	 * @return  Cli
	 *
	 * @since   1.0
	 */
	public function getInputCliService(Container $container)

	{
		return new Cli;
	}

	/**
	 * Get the Input class service
	 *
	 * @param   Container  $container  The DI container.
	 *
	 * @return  Input
	 *
	 * @since   1.0
	 */
	public function getInputService(Container $container)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
	{
		return new Input($_REQUEST);
	}

	/**
	 * Get the InstallCommand class service
	 *
	 * @param   Container  $container  The DI container.
	 *
	 * @return  AppCommands\InstallCommand
	 *
	 * @since   1.0
	 */
	public function getInstallCommandService(Container $container)

	{
		$command = new AppCommands\InstallCommand($container->get(DatabaseDriver::class));

		$command->setApplication($container->get(JoomlaApplication\AbstractApplication::class));
		$command->setInput($container->get(Input::class));

		return $command;
	}

	/**
	 * Get the router service
	 *
	 * @param   Container  $container  The DI container.
	 *
	 * @return  Router
	 *
	 * @since   1.0
	 */
	public function getRouterService(Container $container)
	{
		$router = (new Router($container->get(Input::class)))
			->setControllerPrefix('Stats\\Controllers\\')
			->setDefaultController('DisplayController')
			->addMap('/submit', 'SubmitController')
			->addMap('/:source', 'DisplayController');

		$router->setContainer($container);

		return $router;
	}

	/**
	 * Get the SnapshotCommand class service
	 *
	 * @param   Container  $container  The DI container.
	 *
	 * @return  AppCommands\SnapshotCommand
	 *
	 * @since   1.0
	 */
	public function getSnapshotCommandService(Container $container)

	{
		$command = new AppCommands\SnapshotCommand($container->get(StatsJsonView::class));

		$command->setApplication($container->get(JoomlaApplication\AbstractApplication::class));
		$command->setInput($container->get(Input::class));

		return $command;
	}

	/**
	 * Get the StatsJsonView class service
	 *
	 * @param   Container  $container  The DI container.
	 *
	 * @return  StatsJsonView
	 *
	 * @since   1.0
	 */
	public function getStatsJsonViewService(Container $container)
	{
		return new StatsJsonView(
			$container->get(StatsModel::class)
		);
	}

	/**
	 * Get the StatsModel class service
	 *
	 * @param   Container  $container  The DI container.
	 *
	 * @return  StatsModel
	 *
	 * @since   1.0
	 */
	public function getStatsModelService(Container $container)
	{
		return new StatsModel(
			$container->get(DatabaseDriver::class)
		);
	}

	/**
	 * Get the SubmitControllerCreate class service
	 *
	 * @param   Container  $container  The DI container.
	 *
	 * @return  SubmitControllerCreate
	 *
	 * @since   1.0
	 */
	public function getSubmitControllerCreateService(Container $container)

	{
		$controller = new SubmitControllerCreate(
			$container->get(StatsModel::class)
		);

		$controller->setApplication($container->get(JoomlaApplication\AbstractApplication::class));
		$controller->setInput($container->get(Input::class));

		return $controller;
	}

	/**
	 * Get the SubmitControllerGet class service
	 *
	 * @param   Container  $container  The DI container.
	 *
	 * @return  SubmitControllerGet
	 *
	 * @since   1.0
	 */
	public function getSubmitControllerGetService(Container $container)

	{
		$controller = new SubmitControllerGet;

		$controller->setApplication($container->get(JoomlaApplication\AbstractApplication::class));
		$controller->setInput($container->get(Input::class));

		return $controller;
	}

	/**
	 * Get the Tags\JoomlaCommand class service
	 *
	 * @param   Container  $container  The DI container.
	 *
	 * @return  AppCommands\Tags\JoomlaCommand
	 *
	 * @since   1.0
	 */
	public function getTagsJoomlaCommandService(Container $container)

	{
		$command = new AppCommands\Tags\JoomlaCommand($container->get(GitHub::class));

		$command->setApplication($container->get(JoomlaApplication\AbstractApplication::class));
		$command->setInput($container->get(Input::class));

		return $command;
	}

	/**
	 * Get the Tags\PhpCommand class service
	 *
	 * @param   Container  $container  The DI container.
	 *
	 * @return  AppCommands\Tags\PhpCommand
	 *
	 * @since   1.0
	 */
	public function getTagsPhpCommandService(Container $container)

	{
		$command = new AppCommands\Tags\PhpCommand($container->get(GitHub::class));

		$command->setApplication($container->get(JoomlaApplication\AbstractApplication::class));
		$command->setInput($container->get(Input::class));

		return $command;
	}

	/**
	 * Get the UpdateCommand class service
	 *
	 * @param   Container  $container  The DI container.
	 *
	 * @return  AppCommands\UpdateCommand
	 *
	 * @since   1.0
	 */
	public function getUpdateCommandService(Container $container)

	{
		$command = new AppCommands\UpdateCommand;

		$command->setApplication($container->get(JoomlaApplication\AbstractApplication::class));
		$command->setInput($container->get(Input::class));

		return $command;
	}

	/**
	 * Get the web application service
	 *
	 * @param   Container  $container  The DI container.
	 *
	 * @return  WebApplication
	 *
	 * @since   1.0
	 */
	public function getWebApplicationService(Container $container)
	{
		$application = new WebApplication($container->get(Input::class), $container->get('config'));

		// Inject extra services
		$application->setAnalytics($container->get(Analytics::class));
		$application->setLogger($container->get('monolog.logger.application'));
		$application->setRouter($container->get(Router::class));

		return $application;
	}
}


1			<?php
2
3			namespace Stats\Providers;
4
5			use Joomla\Application as JoomlaApplication;
6			use Joomla\Database\DatabaseDriver;
7			use Joomla\DI\Container;
8			use Joomla\DI\ServiceProviderInterface;
9			use Joomla\Input\Cli;
10			use Joomla\Input\Input;
11			use Psr\Cache\CacheItemPoolInterface;
12			use Psr\Log\LoggerInterface;
13			use Stats\CliApplication;
14			use Stats\Commands as AppCommands;
15			use Stats\Console;
16			use Stats\Controllers\DisplayControllerGet;
17			use Stats\Controllers\SubmitControllerCreate;
18			use Stats\Controllers\SubmitControllerGet;
19			use Stats\Database\Migrations;
20			use Stats\GitHub\GitHub;
21			use Stats\Models\StatsModel;
22			use Stats\Router;
23			use Stats\Views\Stats\StatsJsonView;
24			use Stats\WebApplication;
25			use TheIconic\Tracking\GoogleAnalytics\Analytics;
26
27			/**
28			* Application service provider
29			*
30			* @since 1.0
31			*/
32			class ApplicationServiceProvider implements ServiceProviderInterface
33			{
34			/**
35			* Registers the service provider with a DI container.
36			*
37			* @param Container $container The DI container.
38			*
39			* @return void
40			*

joomla / statistics-server

Push — master ( 8961be...e7d2ec )

ApplicationServiceProvider C

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

25 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like