Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
19 | View Code Duplication | class RepositoryServiceProvider implements ServiceProviderInterface |
|
|
|||
20 | { |
||
21 | /** |
||
22 | * Registers the service provider with a DI container. |
||
23 | * |
||
24 | * @param Container $container The DI container. |
||
25 | * |
||
26 | * @return void |
||
27 | */ |
||
28 | 11 | public function register(Container $container): void |
|
32 | |||
33 | /** |
||
34 | * Get the StatisticsRepository service |
||
35 | * |
||
36 | * @param Container $container The DI container. |
||
37 | * |
||
38 | * @return StatisticsRepository |
||
39 | */ |
||
40 | 7 | public function getStatisticsRepositoryService(Container $container): StatisticsRepository |
|
46 | } |
||
47 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.