ApplicationServiceProvider::register() - Code Metrics - Inspection of "Use version data from our console command for vali..." - joomla/statistics-server - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — Parse-Tags ( be9c93 )

by Michael

created 2016-05-07 22:17 UTC

ApplicationServiceProvider::register() B

↳ Parent: ApplicationServiceProvider

Complexity

Conditions	2
Paths	1

Size

Total Lines	225
Code Lines	127

Duplication

Lines	57
Ratio	25.33 %

Code Coverage

Tests	67
CRAP Score	2.5225

Importance

Changes	13
Bugs	2	Features	6

Metric	Value
c	13
b	2
f	6
dl	57
loc	225
ccs	67
cts	136
cp	0.4926
rs	8.2857
cc	2
eloc	127
nc	1
nop	1
crap	2.5225

How to fix Long Method

<?php

namespace Stats\Providers;

use Doctrine\Common\Cache\Cache;
use Joomla\Application as JoomlaApplication;
use Joomla\Database\DatabaseDriver;
use Joomla\DI\Container;
use Joomla\DI\ServiceProviderInterface;
use Joomla\Input\Cli;
use Joomla\Input\Input;
use Stats\CliApplication;
use Stats\Commands\HelpCommand;
use Stats\Commands\JoomlaTagsCommand;
use Stats\Commands\SnapshotCommand;
use Stats\Console;
use Stats\Controllers\DisplayControllerGet;
use Stats\Controllers\SubmitControllerCreate;
use Stats\Controllers\SubmitControllerGet;
use Stats\GitHub\GitHub;
use Stats\Models\StatsModel;
use Stats\Router;
use Stats\Views\Stats\StatsJsonView;
use Stats\WebApplication;

/**
 * Application service provider
 *
 * @since  1.0
 */
class ApplicationServiceProvider implements ServiceProviderInterface
{
	/**
	 * Registers the service provider with a DI container.
	 *
	 * @param   Container  $container  The DI container.
	 *
	 * @return  void
	 *
	 * @since   1.0
	 */
	public function register(Container $container)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
	{
		$container->alias(CliApplication::class, JoomlaApplication\AbstractCliApplication::class)
			->share(
				JoomlaApplication\AbstractCliApplication::class,
				function (Container $container)
				{
					$application = new CliApplication(
						$container->get(Cli::class),
						$container->get('config'),
						$container->get(JoomlaApplication\Cli\CliOutput::class),
						$container->get(Console::class)
					);

					// Inject extra services
					$application->setContainer($container);
					$application->setLogger($container->get('monolog.logger.cli'));

					return $application;
				},
				true
			);

		$container->alias(WebApplication::class, JoomlaApplication\AbstractWebApplication::class)
			->share(
				JoomlaApplication\AbstractWebApplication::class,
				function (Container $container)
				{
					$application = new WebApplication($container->get(Input::class), $container->get('config'));

					// Inject extra services
					$application->setLogger($container->get('monolog.logger.application'));
					$application->setRouter($container->get(Router::class));

					return $application;
				},
				true
			);

		$container->share(
			Input::class,
			function ()
			{
				return new Input($_REQUEST);
			},
			true
		);

		$container->share(
			Cli::class,
			function ()
			{
				return new Cli;
			},
			true
		);

		$container->share(
			Console::class,
			function (Container $container)
			{
				$console = new Console;
				$console->setContainer($container);

				return $console;
			}
		);

		$container->share(
			JoomlaApplication\Cli\Output\Processor\ColorProcessor::class,
			function (Container $container)
			{
				$processor = new JoomlaApplication\Cli\Output\Processor\ColorProcessor;

				/** @var Input $input */
				$input = $container->get(Cli::class);

				if ($input->get('nocolors'))
				{
					$processor->noColors = true;
				}

				// Setup app colors (also required in "nocolors" mode - to strip them).
				$processor->addStyle('title', new JoomlaApplication\Cli\ColorStyle('yellow', '', ['bold']));

				return $processor;
			}
		);

		$container->alias(JoomlaApplication\Cli\CliOutput::class, JoomlaApplication\Cli\Output\Stdout::class)
			->share(
				JoomlaApplication\Cli\Output\Stdout::class,
				function (Container $container)
				{
					return new JoomlaApplication\Cli\Output\Stdout($container->get(JoomlaApplication\Cli\Output\Processor\ColorProcessor::class));
				}
			);

		$container->share(
			Router::class,
			function (Container $container)
			{
				$router = (new Router($container->get(Input::class)))
					->setContainer($container)
					->setControllerPrefix('Stats\\Controllers\\')
					->setDefaultController('DisplayController')
					->addMap('/submit', 'SubmitController')
					->addMap('/:source', 'DisplayController');

				return $router;
			},
			true
		);

		$container->share(
			HelpCommand::class,
			function (Container $container)

			{
				$command = new HelpCommand;

				$command->setApplication($container->get(JoomlaApplication\AbstractApplication::class));
				$command->setInput($container->get(Input::class));

				return $command;
			},
			true
		);

		$container->share(
			JoomlaTagsCommand::class,
			function (Container $container)

			{
				$command = new JoomlaTagsCommand($container->get(GitHub::class));

				$command->setApplication($container->get(JoomlaApplication\AbstractApplication::class));
				$command->setInput($container->get(Input::class));

				return $command;
			},
			true
		);

		$container->share(
			SnapshotCommand::class,
			function (Container $container)

			{
				$command = new SnapshotCommand($container->get(StatsJsonView::class));

				$command->setApplication($container->get(JoomlaApplication\AbstractApplication::class));
				$command->setInput($container->get(Input::class));

				return $command;
			},
			true
		);

		$container->share(
			DisplayControllerGet::class,
			function (Container $container)

			{
				$controller = new DisplayControllerGet(
					$container->get(StatsJsonView::class),
					$container->get(Cache::class)
				);

				$controller->setApplication($container->get(JoomlaApplication\AbstractApplication::class));
				$controller->setInput($container->get(Input::class));

				return $controller;
			},
			true
		);

		$container->share(
			SubmitControllerCreate::class,
			function (Container $container)

			{
				$controller = new SubmitControllerCreate(
					$container->get(StatsModel::class)
				);

				$controller->setApplication($container->get(JoomlaApplication\AbstractApplication::class));
				$controller->setInput($container->get(Input::class));

				return $controller;
			},
			true
		);

		$container->share(
			SubmitControllerGet::class,
			function (Container $container)

			{
				$controller = new SubmitControllerGet;

				$controller->setApplication($container->get(JoomlaApplication\AbstractApplication::class));
				$controller->setInput($container->get(Input::class));

				return $controller;
			},
			true
		);

		$container->share(
			StatsModel::class,
			function (Container $container)
			{
				return new StatsModel(
					$container->get(DatabaseDriver::class)
				);
			},
			true
		);

		$container->share(
			StatsJsonView::class,
			function (Container $container)
			{
				return new StatsJsonView(
					$container->get(StatsModel::class)
				);
			},
			true
		);
	}
}


1			<?php
2
3			namespace Stats\Providers;
4
5			use Doctrine\Common\Cache\Cache;
6			use Joomla\Application as JoomlaApplication;
7			use Joomla\Database\DatabaseDriver;
8			use Joomla\DI\Container;
9			use Joomla\DI\ServiceProviderInterface;
10			use Joomla\Input\Cli;
11			use Joomla\Input\Input;
12			use Stats\CliApplication;
13			use Stats\Commands\HelpCommand;
14			use Stats\Commands\JoomlaTagsCommand;
15			use Stats\Commands\SnapshotCommand;
16			use Stats\Console;
17			use Stats\Controllers\DisplayControllerGet;
18			use Stats\Controllers\SubmitControllerCreate;
19			use Stats\Controllers\SubmitControllerGet;
20			use Stats\GitHub\GitHub;
21			use Stats\Models\StatsModel;
22			use Stats\Router;
23			use Stats\Views\Stats\StatsJsonView;
24			use Stats\WebApplication;
25
26			/**
27			* Application service provider
28			*
29			* @since 1.0
30			*/
31			class ApplicationServiceProvider implements ServiceProviderInterface
32			{
33			/**
34			* Registers the service provider with a DI container.
35			*
36			* @param Container $container The DI container.
37			*
38			* @return void
39			*
40			* @since 1.0
41			*/
42	1		public function register(Container $container)
			0 ignored issues – show Coding Style introduced 2016-01-02 17:06 UTC by Report Bug Copy Issue Report `register` uses the super-global variable `$_REQUEST` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
43			{
44	1		$container->alias(CliApplication::class, JoomlaApplication\AbstractCliApplication::class)
45	1		->share(
46	1		JoomlaApplication\AbstractCliApplication::class,
47			function (Container $container)
48			{
49			$application = new CliApplication(
50			$container->get(Cli::class),
51			$container->get('config'),
52			$container->get(JoomlaApplication\Cli\CliOutput::class),
53			$container->get(Console::class)
54			);
55
56			// Inject extra services
57			$application->setContainer($container);
58			$application->setLogger($container->get('monolog.logger.cli'));
59
60			return $application;
61	1		},
62			true
63	1		);
64
65	1		$container->alias(WebApplication::class, JoomlaApplication\AbstractWebApplication::class)
66	1		->share(
67	1		JoomlaApplication\AbstractWebApplication::class,
68			function (Container $container)
69			{
70			$application = new WebApplication($container->get(Input::class), $container->get('config'));
71
72			// Inject extra services
73			$application->setLogger($container->get('monolog.logger.application'));
74			$application->setRouter($container->get(Router::class));
75
76			return $application;
77	1		},
78			true
79	1		);
80
81	1		$container->share(
82	1		Input::class,
83			function ()
84			{
85			return new Input($_REQUEST);
86	1		},
87			true
88	1		);
89
90	1		$container->share(
91	1		Cli::class,
92			function ()
93			{
94			return new Cli;
95	1		},
96			true
97	1		);
98
99	1		$container->share(
100	1		Console::class,
101			function (Container $container)
102			{
103			$console = new Console;
104			$console->setContainer($container);
105
106			return $console;
107			}
108	1		);
109
110	1		$container->share(
111	1		JoomlaApplication\Cli\Output\Processor\ColorProcessor::class,
112			function (Container $container)
113			{
114			$processor = new JoomlaApplication\Cli\Output\Processor\ColorProcessor;
115
116			/** @var Input $input */
117			$input = $container->get(Cli::class);
118
119			if ($input->get('nocolors'))
120			{
121			$processor->noColors = true;
122			}
123
124			// Setup app colors (also required in "nocolors" mode - to strip them).
125			$processor->addStyle('title', new JoomlaApplication\Cli\ColorStyle('yellow', '', ['bold']));
126
127			return $processor;
128			}
129	1		);
130
131	1		$container->alias(JoomlaApplication\Cli\CliOutput::class, JoomlaApplication\Cli\Output\Stdout::class)
132	1		->share(
133	1		JoomlaApplication\Cli\Output\Stdout::class,
134			function (Container $container)
135			{
136			return new JoomlaApplication\Cli\Output\Stdout($container->get(JoomlaApplication\Cli\Output\Processor\ColorProcessor::class));
137			}
138	1		);
139
140	1		$container->share(
141	1		Router::class,
142			function (Container $container)
143			{
144			$router = (new Router($container->get(Input::class)))
145			->setContainer($container)
146			->setControllerPrefix('Stats\\Controllers\\')
147			->setDefaultController('DisplayController')
148			->addMap('/submit', 'SubmitController')
149			->addMap('/:source', 'DisplayController');
150
151			return $router;
152	1		},
153			true
154	1		);
155
156	1		$container->share(
157	1		HelpCommand::class,
158		View Code Duplication	function (Container $container)
			0 ignored issues – show Duplication introduced 2016-03-26 20:03 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
159			{
160			$command = new HelpCommand;
161
162			$command->setApplication($container->get(JoomlaApplication\AbstractApplication::class));
163			$command->setInput($container->get(Input::class));
164
165			return $command;
166	1		},
167			true
168	1		);
169
170	1		$container->share(
171	1		JoomlaTagsCommand::class,
172		View Code Duplication	function (Container $container)
			0 ignored issues – show Duplication introduced 2016-05-07 22:21 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
173			{
174			$command = new JoomlaTagsCommand($container->get(GitHub::class));
175
176			$command->setApplication($container->get(JoomlaApplication\AbstractApplication::class));
177			$command->setInput($container->get(Input::class));
178
179			return $command;
180	1		},
181			true
182	1		);
183
184	1		$container->share(
185	1		SnapshotCommand::class,
186		View Code Duplication	function (Container $container)
			0 ignored issues – show Duplication introduced 2016-03-26 20:03 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
187			{
188			$command = new SnapshotCommand($container->get(StatsJsonView::class));
189
190			$command->setApplication($container->get(JoomlaApplication\AbstractApplication::class));
191			$command->setInput($container->get(Input::class));
192
193			return $command;
194	1		},
195			true
196	1		);
197
198	1		$container->share(
199	1		DisplayControllerGet::class,
200		View Code Duplication	function (Container $container)
			0 ignored issues – show Duplication introduced 2016-03-15 00:41 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
201			{
202			$controller = new DisplayControllerGet(
203			$container->get(StatsJsonView::class),
204			$container->get(Cache::class)
205			);
206
207			$controller->setApplication($container->get(JoomlaApplication\AbstractApplication::class));
208			$controller->setInput($container->get(Input::class));
209
210			return $controller;
211	1		},
212			true
213	1		);
214
215	1		$container->share(
216	1		SubmitControllerCreate::class,
217		View Code Duplication	function (Container $container)
			0 ignored issues – show Duplication introduced 2016-01-02 17:06 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
218			{
219			$controller = new SubmitControllerCreate(
220			$container->get(StatsModel::class)
221			);
222
223			$controller->setApplication($container->get(JoomlaApplication\AbstractApplication::class));
224			$controller->setInput($container->get(Input::class));
225
226			return $controller;
227	1		},
228			true
229	1		);
230
231	1		$container->share(
232	1		SubmitControllerGet::class,
233		View Code Duplication	function (Container $container)
			0 ignored issues – show Duplication introduced 2016-05-07 22:21 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
234			{
235			$controller = new SubmitControllerGet;
236
237			$controller->setApplication($container->get(JoomlaApplication\AbstractApplication::class));
238			$controller->setInput($container->get(Input::class));
239
240			return $controller;
241	1		},
242			true
243	1		);
244
245	1		$container->share(
246	1		StatsModel::class,
247			function (Container $container)
248			{
249			return new StatsModel(
250			$container->get(DatabaseDriver::class)
251			);
252	1		},
253			true
254	1		);
255
256	1		$container->share(
257	1		StatsJsonView::class,
258	1		function (Container $container)
259			{
260			return new StatsJsonView(
261			$container->get(StatsModel::class)
262			);
263	1		},
264			true
265	1		);
266	1		}
267			}
268

joomla / statistics-server

Push — Parse-Tags ( be9c93 )

ApplicationServiceProvider::register() B

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like