Console::loadCommands() - Code Metrics - Inspection of "Add a command to take a snapshot" - joomla/statistics-server - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( cd1493...0fdab2 )

by Michael

created 2016-03-26 20:00 UTC

Console::loadCommands() B

↳ Parent: Console

Complexity

Conditions	5
Paths	4

Size

Total Lines	25
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	30

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	25
ccs	0
cts	19
cp	0
rs	8.439
cc	5
eloc	11
nc	4
nop	0
crap	30

<?php

namespace Stats;

use Joomla\Application\Cli\ColorStyle;
use Joomla\Application\Cli\Output\Processor\ColorProcessor;
use Joomla\Controller\AbstractController;
use Joomla\DI\ContainerAwareInterface;
use Joomla\DI\ContainerAwareTrait;

/**
 * CLI Console
 *
 * @since  1.0
 */
class Console implements ContainerAwareInterface
{
	use ContainerAwareTrait;

	/**
	 * Array of available command objects
	 *
	 * @var    CommandInterface[]
	 * @since  1.0
	 */
	private $commands = [];

	/**
	 * Get the available commands.
	 *
	 * @return  CommandInterface[]
	 *
	 * @since   1.0
	 * @throws  \RuntimeException
	 */
	public function getCommands()
	{
		if (empty($this->commands))
		{
			$this->commands = $this->loadCommands();
		}

		return $this->commands;
	}

	/**
	 * Load the application's commands
	 *
	 * @return  CommandInterface[]
	 *
	 * @since   1.0
	 */
	private function loadCommands()
	{
		$commands = [];

		/** @var \DirectoryIterator $fileInfo */
		foreach (new \DirectoryIterator(__DIR__ . '/Commands') as $fileInfo)
		{
			if ($fileInfo->isDot() || !$fileInfo->isFile())
			{
				continue;
			}

			$command   = $fileInfo->getBasename('.php');
			$className = __NAMESPACE__ . "\\Commands\\$command";

			if (false == class_exists($className))

			{
				throw new \RuntimeException(sprintf('Required class "%s" not found.', $className));
			}

			$commands[strtolower(str_replace('Command', '', $command))] = $this->getContainer()->get($className);
		}

		return $commands;
	}
}


1			<?php
2
3			namespace Stats;
4
5			use Joomla\Application\Cli\ColorStyle;
6			use Joomla\Application\Cli\Output\Processor\ColorProcessor;
7			use Joomla\Controller\AbstractController;
8			use Joomla\DI\ContainerAwareInterface;
9			use Joomla\DI\ContainerAwareTrait;
10
11			/**
12			* CLI Console
13			*
14			* @since 1.0
15			*/
16			class Console implements ContainerAwareInterface
17			{
18			use ContainerAwareTrait;
19
20			/**
21			* Array of available command objects
22			*
23			* @var CommandInterface[]
24			* @since 1.0
25			*/
26			private $commands = [];
27
28			/**
29			* Get the available commands.
30			*
31			* @return CommandInterface[]
32			*
33			* @since 1.0
34			* @throws \RuntimeException
35			*/
36			public function getCommands()
37			{
38			if (empty($this->commands))
39			{
40			$this->commands = $this->loadCommands();
41			}
42
43			return $this->commands;
44			}
45
46			/**
47			* Load the application's commands
48			*
49			* @return CommandInterface[]
50			*
51			* @since 1.0
52			*/
53			private function loadCommands()
54			{
55			$commands = [];
56
57			/** @var \DirectoryIterator $fileInfo */
58			foreach (new \DirectoryIterator(__DIR__ . '/Commands') as $fileInfo)
59			{
60			if ($fileInfo->isDot() \|\| !$fileInfo->isFile())
61			{
62			continue;
63			}
64
65			$command = $fileInfo->getBasename('.php');
66			$className = __NAMESPACE__ . "\\Commands\\$command";
67
68			if (false == class_exists($className))
			0 ignored issues – show Coding Style Best Practice introduced 2016-03-26 20:03 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing two booleans. Considering using the strict comparison `===` instead. When comparing two booleans, it is generally considered safer to use the strict comparison operator. Loading history...
69			{
70			throw new \RuntimeException(sprintf('Required class "%s" not found.', $className));
71			}
72
73			$commands[strtolower(str_replace('Command', '', $command))] = $this->getContainer()->get($className);
74			}
75
76			return $commands;
77			}
78			}
79

joomla / statistics-server

Push — master ( cd1493...0fdab2 )

Console::loadCommands() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like