Issues in controller.php (develop) - Issues in develop - joomla-projects/com_localise - Measure and Improve Code Quality continuously with Scrutinizer

Issues (492)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

component/admin/controller.php (5 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * @package     Com_Localise
 * @subpackage  Controller
 *
 * @copyright   Copyright (C) 2005 - 2015 Open Source Matters, Inc. All rights reserved.
 * @license     GNU General Public License version 2 or later; see LICENSE.txt
 */

defined('_JEXEC') or die;

/**
 * Controller class for the localise component
 *
 * @package     Extensions.Components
 * @subpackage  Localise
 * @since       1.0
 */
class LocaliseController extends JControllerLegacy
{
	/**
	 * Method to display a view.
	 *
	 * @param   boolean  $cachable   If true, the view output will be cached
	 * @param   array    $urlparams  An array of safe url parameters and their variable types, for valid values see {@link JFilterInput::clean()}.
	 *
	 * @return  JController  This object to support chaining.
	 *
	 * @since   1.5
	 */
	public function display($cachable = false, $urlparams = false)
	{
		require_once JPATH_COMPONENT . '/helpers/localise.php';
		$app = JFactory::getApplication('administrator');
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

		$vName = $this->input->get('view', 'languages');
		$layout = $this->input->get('layout', 'default');
		$id     = $this->input->getInt('id');

		if ($vName == 'translations')
		{
			$view     = $this->getView('translations', 'html');
			$packages = $this->getModel('Packages', 'LocaliseModel', array('ignore_request' => true));
			$view->setModel($packages);
		}
		// Check for edit form.
		elseif ($vName == 'language' && $layout == 'edit'

			&& !$this->checkEditId('com_localise.edit.language', $id))
		{
			// Somehow the person just went to the form - we don't allow that.
			$this->setError(JText::sprintf('JLIB_APPLICATION_ERROR_UNHELD_ID', $id));
			$this->setMessage($this->getError(), 'error');
			$this->setRedirect(JRoute::_('index.php?option=com_localise&view=languages', false));

			return false;
		}
		elseif ($vName == 'translation' && ($layout == 'edit' || $layout == 'raw')

			&& !$this->checkEditId('com_localise.edit.translation', $id))
		{
			// Somehow the person just went to the form - we don't allow that.
			$this->setError(JText::sprintf('JLIB_APPLICATION_ERROR_UNHELD_ID', $id));
			$this->setMessage($this->getError(), 'error');
			$this->setRedirect(JRoute::_('index.php?option=com_localise&view=translations', false));

			return false;
		}
		elseif ($vName == 'packagefile' && $layout == 'edit'

			&& !$this->checkEditId('com_localise.edit.packagefile', $id))
		{
			// Somehow the person just went to the form - we don't allow that.
			$this->setError(JText::sprintf('JLIB_APPLICATION_ERROR_UNHELD_ID', $id));
			$this->setMessage($this->getError(), 'error');
			$this->setRedirect(JRoute::_('index.php?option=com_localise&view=packages', false));

			return false;
		}
		elseif ($vName == 'package' && $layout == 'edit'

			&& !$this->checkEditId('com_localise.edit.package', $id))
		{
			// Somehow the person just went to the form - we don't allow that.
			$this->setError(JText::sprintf('JLIB_APPLICATION_ERROR_UNHELD_ID', $id));
			$this->setMessage($this->getError(), 'error');
			$this->setRedirect(JRoute::_('index.php?option=com_localise&view=packages', false));

			return false;
		}
		else
		{
			$this->input->set('view', $vName);
		}

		parent::display($cachable, $urlparams);
	}
}


1		<?php
2		/**
3		* @package Com_Localise
4		* @subpackage Controller
5		*
6		* @copyright Copyright (C) 2005 - 2015 Open Source Matters, Inc. All rights reserved.
7		* @license GNU General Public License version 2 or later; see LICENSE.txt
8		*/
9
10		defined('_JEXEC') or die;
11
12		/**
13		* Controller class for the localise component
14		*
15		* @package Extensions.Components
16		* @subpackage Localise
17		* @since 1.0
18		*/
19		class LocaliseController extends JControllerLegacy
20		{
21		/**
22		* Method to display a view.
23		*
24		* @param boolean $cachable If true, the view output will be cached
25		* @param array $urlparams An array of safe url parameters and their variable types, for valid values see {@link JFilterInput::clean()}.
26		*
27		* @return JController This object to support chaining.
28		*
29		* @since 1.5
30		*/
31		public function display($cachable = false, $urlparams = false)
32		{
33		require_once JPATH_COMPONENT . '/helpers/localise.php';
34		$app = JFactory::getApplication('administrator');
		0 ignored issues – show Unused Code introduced 2015-12-19 09:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$app` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
35
36		$vName = $this->input->get('view', 'languages');
37		$layout = $this->input->get('layout', 'default');
38		$id = $this->input->getInt('id');
39
40		if ($vName == 'translations')
41		{
42		$view = $this->getView('translations', 'html');
43		$packages = $this->getModel('Packages', 'LocaliseModel', array('ignore_request' => true));
44		$view->setModel($packages);
45		}
46		// Check for edit form.
47	View Code Duplication	elseif ($vName == 'language' && $layout == 'edit'
		0 ignored issues – show Duplication introduced 2015-12-19 09:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
48		&& !$this->checkEditId('com_localise.edit.language', $id))
49		{
50		// Somehow the person just went to the form - we don't allow that.
51		$this->setError(JText::sprintf('JLIB_APPLICATION_ERROR_UNHELD_ID', $id));
52		$this->setMessage($this->getError(), 'error');
53		$this->setRedirect(JRoute::_('index.php?option=com_localise&view=languages', false));
54
55		return false;
56		}
57	View Code Duplication	elseif ($vName == 'translation' && ($layout == 'edit' \|\| $layout == 'raw')
		0 ignored issues – show Duplication introduced 2015-12-19 09:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
58		&& !$this->checkEditId('com_localise.edit.translation', $id))
59		{
60		// Somehow the person just went to the form - we don't allow that.
61		$this->setError(JText::sprintf('JLIB_APPLICATION_ERROR_UNHELD_ID', $id));
62		$this->setMessage($this->getError(), 'error');
63		$this->setRedirect(JRoute::_('index.php?option=com_localise&view=translations', false));
64
65		return false;
66		}
67	View Code Duplication	elseif ($vName == 'packagefile' && $layout == 'edit'
		0 ignored issues – show Duplication introduced 2015-12-19 09:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
68		&& !$this->checkEditId('com_localise.edit.packagefile', $id))
69		{
70		// Somehow the person just went to the form - we don't allow that.
71		$this->setError(JText::sprintf('JLIB_APPLICATION_ERROR_UNHELD_ID', $id));
72		$this->setMessage($this->getError(), 'error');
73		$this->setRedirect(JRoute::_('index.php?option=com_localise&view=packages', false));
74
75		return false;
76		}
77	View Code Duplication	elseif ($vName == 'package' && $layout == 'edit'
		0 ignored issues – show Duplication introduced 2015-12-19 09:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
78		&& !$this->checkEditId('com_localise.edit.package', $id))
79		{
80		// Somehow the person just went to the form - we don't allow that.
81		$this->setError(JText::sprintf('JLIB_APPLICATION_ERROR_UNHELD_ID', $id));
82		$this->setMessage($this->getError(), 'error');
83		$this->setRedirect(JRoute::_('index.php?option=com_localise&view=packages', false));
84
85		return false;
86		}
87		else
88		{
89		$this->input->set('view', $vName);
90		}
91
92		parent::display($cachable, $urlparams);
93		}
94		}
95

GitHub Access Token became invalid

Issues (492)

Security Analysis no request data

component/admin/controller.php (5 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

joomla-projects / com_localise

GitHub Access Token became invalid

Issues (492)

Security Analysis no request data

component/admin/controller.php (5 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like