Issues in edit.php - New Issues - Inspection of "Merge pull request #320 from uzielweb/patch-2" - joomla-projects/com_localise - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( b9bf49...b5e3c2 )

unknown

created 2017-12-19 10:16 UTC

component/admin/views/language/tmpl/edit.php (1 issue)

Labels

Duplication 1

Severity

Informational 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * @package     Com_Localise
 * @subpackage  views
 *
 * @copyright   Copyright (C) 2005 - 2015 Open Source Matters, Inc. All rights reserved.
 * @license     GNU General Public License version 2 or later; see LICENSE.txt
 */

defined('_JEXEC') or die;

JHtml::_('behavior.formvalidation');
JHtml::_('formbehavior.chosen', 'select');

$fieldSets = $this->form->getFieldsets();
$ftpSets   = $this->formftp->getFieldsets();
$params    = JComponentHelper::getParams('com_localise');
$ref_tag   = $params->get('reference', 'en-GB');
$isNew     = empty($this->item->id);
$tag       = $this->item->tag ;
$client    = $this->item->client;

JHtml::_('script', 'media/com_localise/js/language-form.js', false, false, false, false);
?>
<script type="text/javascript">
	Joomla.submitbutton = function(task)
	{
		if (task == 'language.cancel' || document.formvalidator.isValid(document.id('localise-language-form')))
		{
			Joomla.submitform(task, document.getElementById('localise-language-form'));
		}
	}
</script>

<form action="<?php echo JRoute::_('index.php?option=com_localise&view=language&layout=edit&id=' . (int) $this->item->id); ?>" method="post" name="adminForm" id="localise-language-form" class="form-validate">
	<div class="row-fluid">
		<!-- Begin Localise Language -->
		<div class="span12 form-horizontal">
			<?php if ($isNew) : ?>
				<p><em><?php echo JText::_('COM_LOCALISE_COPY_REF_TO_NEW_LANG_FIRSTSAVE'); ?></em><p>
			<?php elseif (!$isNew && $client != 'installation') : ?>
				<p><em> <?php echo JText::sprintf('COM_LOCALISE_COPY_REF_TO_NEW_LANG_TIP', $ref_tag, $tag); ?></em></p>
			<?php endif; ?>
			<fieldset>
				<?php echo JHtml::_('bootstrap.startTabSet', 'myTab', array('active' => $this->ftp ? 'ftp' : 'default')); ?>
					<?php if ($this->ftp) : ?>
					<?php echo JHtml::_('bootstrap.addTab', 'myTab', 'ftp', JText::_($ftpSets['ftp']->label, true)); ?>

						<?php if (!empty($ftpSets['ftp']->description)):?>
							<p class="tip"><?php echo JText::_($ftpSets['ftp']->description); ?></p>
						<?php endif;?>

						<?php if (JError::isError($this->ftp)): ?>
							<p class="error"><?php echo JText::_($this->ftp->message); ?></p>
						<?php endif; ?>

						<?php foreach($this->formftp->getFieldset('ftp',false) as $field): ?>
						<div class="control-group">
							<div class="control-label">
								<?php echo $field->label; ?>
							</div>
							<div class="controls">
								<?php echo $field->input; ?>
							</div>
						</div>
						<?php endforeach; ?>

					<?php echo JHtml::_('bootstrap.endTab'); ?>

					<?php endif; ?>

					<?php echo JHtml::_('bootstrap.addTab', 'myTab', 'default', JText::_($fieldSets['default']->label, true)); ?>

						<div class="span6">
						<?php if (!empty($fieldSets['default']->description)) : ?>
							<p class="tip"><?php echo JText::_($fieldSets['default']->description); ?></p>
						<?php endif;?>
							<?php foreach($this->form->getFieldset('default') as $field): ?>
							<div class="control-group">
								<div class="control-label">
									<?php echo $field->label; ?>
								</div>
								<div class="controls">
									<?php echo $field->input; ?>
								</div>
							</div>
							<?php endforeach; ?>
						</div>
						<div class="span6">
						<?php if (!empty($fieldSets['meta']->description)) : ?>

							<p class="tip"><?php echo JText::_($fieldSets['meta']->description); ?></p>
						<?php endif;?>
							<?php foreach ($this->form->getFieldset('meta') as $field) : ?>
								<div class="control-group">
									<div class="control-label">
										<?php echo $field->label; ?>
									</div>
									<div class="controls">
										<?php echo $field->input; ?>
									</div>
								</div>
							<?php endforeach; ?>
							<?php if (version_compare(JVERSION, '3.7', 'ge')) : ?>
								<?php foreach ($this->form->getFieldset('metanew') as $field) : ?>
									<div class="control-group">
										<div class="control-label">
											<?php echo $field->label; ?>
										</div>
										<div class="controls">
											<?php echo $field->input; ?>
										</div>
									</div>
								<?php endforeach; ?>
							<?php endif;?>
						</div>

					<?php echo JHtml::_('bootstrap.endTab'); ?>

					<?php echo JHtml::_('bootstrap.addTab', 'myTab', 'author', JText::_($fieldSets['author']->label, true)); ?>

						<?php if (!empty($fieldSets['author']->description)):?>
							<p class="tip"><?php echo JText::_($fieldSets['author']->description); ?></p>
						<?php endif;?>

						<?php foreach($this->form->getFieldset('author') as $field): ?>
						<div class="control-group">
							<div class="control-label">
								<?php echo $field->label; ?>
							</div>
							<div class="controls">
								<?php echo $field->input; ?>
							</div>
						</div>
						<?php endforeach; ?>

					<?php echo JHtml::_('bootstrap.endTab'); ?>

					<?php echo JHtml::_('bootstrap.addTab', 'myTab', 'permissions', JText::_($fieldSets['permissions']->label, true)); ?>

						<?php if (!empty($fieldSets['permissions']->description)):?>
							<p class="tip"><?php echo JText::_($fieldSets['permissions']->description); ?></p>
						<?php endif;?>

						<?php foreach($this->form->getFieldset('permissions') as $field): ?>
						<div class="control-group form-vertical">
							<div class="controls">
								<?php echo $field->input; ?>
							</div>
						</div>
						<?php endforeach; ?>

					<?php echo JHtml::_('bootstrap.endTab'); ?>

					<input type="hidden" name="task" value="" />
					<?php echo JHtml::_('form.token'); ?>

				<?php echo JHtml::_('bootstrap.endTabSet'); ?>
			</fieldset>
		</div>
		<!-- End Localise Language -->
	</div>
</form>


1		<?php
2		/**
3		* @package Com_Localise
4		* @subpackage views
5		*
6		* @copyright Copyright (C) 2005 - 2015 Open Source Matters, Inc. All rights reserved.
7		* @license GNU General Public License version 2 or later; see LICENSE.txt
8		*/
9
10		defined('_JEXEC') or die;
11
12		JHtml::_('behavior.formvalidation');
13		JHtml::_('formbehavior.chosen', 'select');
14
15		$fieldSets = $this->form->getFieldsets();
16		$ftpSets = $this->formftp->getFieldsets();
17		$params = JComponentHelper::getParams('com_localise');
18		$ref_tag = $params->get('reference', 'en-GB');
19		$isNew = empty($this->item->id);
20		$tag = $this->item->tag ;
21		$client = $this->item->client;
22
23		JHtml::_('script', 'media/com_localise/js/language-form.js', false, false, false, false);
24		?>
25		<script type="text/javascript">
26		Joomla.submitbutton = function(task)
27		{
28		if (task == 'language.cancel' \|\| document.formvalidator.isValid(document.id('localise-language-form')))
29		{
30		Joomla.submitform(task, document.getElementById('localise-language-form'));
31		}
32		}
33		</script>
34
35		<form action="<?php echo JRoute::_('index.php?option=com_localise&view=language&layout=edit&id=' . (int) $this->item->id); ?>" method="post" name="adminForm" id="localise-language-form" class="form-validate">
36		<div class="row-fluid">
37		<!-- Begin Localise Language -->
38		<div class="span12 form-horizontal">
39		<?php if ($isNew) : ?>
40		<p><em><?php echo JText::_('COM_LOCALISE_COPY_REF_TO_NEW_LANG_FIRSTSAVE'); ?></em><p>
41		<?php elseif (!$isNew && $client != 'installation') : ?>
42		<p><em> <?php echo JText::sprintf('COM_LOCALISE_COPY_REF_TO_NEW_LANG_TIP', $ref_tag, $tag); ?></em></p>
43		<?php endif; ?>
44		<fieldset>
45		<?php echo JHtml::_('bootstrap.startTabSet', 'myTab', array('active' => $this->ftp ? 'ftp' : 'default')); ?>
46	View Code Duplication	<?php if ($this->ftp) : ?>
47		<?php echo JHtml::_('bootstrap.addTab', 'myTab', 'ftp', JText::_($ftpSets['ftp']->label, true)); ?>
48
49		<?php if (!empty($ftpSets['ftp']->description)):?>
50		<p class="tip"><?php echo JText::_($ftpSets['ftp']->description); ?></p>
51		<?php endif;?>
52
53		<?php if (JError::isError($this->ftp)): ?>
54		<p class="error"><?php echo JText::_($this->ftp->message); ?></p>
55		<?php endif; ?>
56
57		<?php foreach($this->formftp->getFieldset('ftp',false) as $field): ?>
58		<div class="control-group">
59		<div class="control-label">
60		<?php echo $field->label; ?>
61		</div>
62		<div class="controls">
63		<?php echo $field->input; ?>
64		</div>
65		</div>
66		<?php endforeach; ?>
67
68		<?php echo JHtml::_('bootstrap.endTab'); ?>
69
70		<?php endif; ?>
71
72		<?php echo JHtml::_('bootstrap.addTab', 'myTab', 'default', JText::_($fieldSets['default']->label, true)); ?>
73
74		<div class="span6">
75	View Code Duplication	<?php if (!empty($fieldSets['default']->description)) : ?>
76		<p class="tip"><?php echo JText::_($fieldSets['default']->description); ?></p>
77		<?php endif;?>
78		<?php foreach($this->form->getFieldset('default') as $field): ?>
79		<div class="control-group">
80		<div class="control-label">
81		<?php echo $field->label; ?>
82		</div>
83		<div class="controls">
84		<?php echo $field->input; ?>
85		</div>
86		</div>
87		<?php endforeach; ?>
88		</div>
89		<div class="span6">
90	View Code Duplication	<?php if (!empty($fieldSets['meta']->description)) : ?>
		0 ignored issues – show Duplication introduced 2017-12-19 10:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
91		<p class="tip"><?php echo JText::_($fieldSets['meta']->description); ?></p>
92		<?php endif;?>
93		<?php foreach ($this->form->getFieldset('meta') as $field) : ?>
94		<div class="control-group">
95		<div class="control-label">
96		<?php echo $field->label; ?>
97		</div>
98		<div class="controls">
99		<?php echo $field->input; ?>
100		</div>
101		</div>
102		<?php endforeach; ?>
103		<?php if (version_compare(JVERSION, '3.7', 'ge')) : ?>
104		<?php foreach ($this->form->getFieldset('metanew') as $field) : ?>
105		<div class="control-group">
106		<div class="control-label">
107		<?php echo $field->label; ?>
108		</div>
109		<div class="controls">
110		<?php echo $field->input; ?>
111		</div>
112		</div>
113		<?php endforeach; ?>
114		<?php endif;?>
115		</div>
116
117		<?php echo JHtml::_('bootstrap.endTab'); ?>
118
119		<?php echo JHtml::_('bootstrap.addTab', 'myTab', 'author', JText::_($fieldSets['author']->label, true)); ?>
120
121	View Code Duplication	<?php if (!empty($fieldSets['author']->description)):?>
122		<p class="tip"><?php echo JText::_($fieldSets['author']->description); ?></p>
123		<?php endif;?>
124
125		<?php foreach($this->form->getFieldset('author') as $field): ?>
126		<div class="control-group">
127		<div class="control-label">
128		<?php echo $field->label; ?>
129		</div>
130		<div class="controls">
131		<?php echo $field->input; ?>
132		</div>
133		</div>
134		<?php endforeach; ?>
135
136		<?php echo JHtml::_('bootstrap.endTab'); ?>
137
138		<?php echo JHtml::_('bootstrap.addTab', 'myTab', 'permissions', JText::_($fieldSets['permissions']->label, true)); ?>
139
140	View Code Duplication	<?php if (!empty($fieldSets['permissions']->description)):?>
141		<p class="tip"><?php echo JText::_($fieldSets['permissions']->description); ?></p>
142		<?php endif;?>
143
144		<?php foreach($this->form->getFieldset('permissions') as $field): ?>
145		<div class="control-group form-vertical">
146		<div class="controls">
147		<?php echo $field->input; ?>
148		</div>
149		</div>
150		<?php endforeach; ?>
151
152		<?php echo JHtml::_('bootstrap.endTab'); ?>
153
154		<input type="hidden" name="task" value="" />
155		<?php echo JHtml::_('form.token'); ?>
156
157		<?php echo JHtml::_('bootstrap.endTabSet'); ?>
158		</fieldset>
159		</div>
160		<!-- End Localise Language -->
161		</div>
162		</form>
163

GitHub Access Token became invalid

Push — develop ( b9bf49...b5e3c2 )

component/admin/views/language/tmpl/edit.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

joomla-projects / com_localise

GitHub Access Token became invalid

Push — develop ( b9bf49...b5e3c2 )

component/admin/views/language/tmpl/edit.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like