Issues in ClientTest.php (master) - Issues in master - joomla-framework/oauth1 - Measure and Improve Code Quality continuously with Scrutinizer

Issues (24)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

Tests/ClientTest.php (9 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * @copyright  Copyright (C) 2005 - 2018 Open Source Matters, Inc. All rights reserved.
 * @license    GNU General Public License version 2 or later; see LICENSE
 */

namespace Joomla\OAuth1\Tests;

use Joomla\Application\AbstractWebApplication;
use Joomla\Input\Input;
use Joomla\OAuth1\Client;
use Joomla\Registry\Registry;
use Joomla\Test\TestHelper;
use PHPUnit\Framework\TestCase;

require_once __DIR__ . '/stubs/ClientInspector.php';

/**
 * Test class for OAuth1 Client.
 *
 * @since  1.0
 */
class ClientTest extends TestCase
{
	/**
	 * @var    Input  input for the Client object.
	 * @since  1.0
	 */
	protected $input;

	/**
	 * @var    Registry  Options for the Client object.
	 * @since  1.0
	 */
	protected $options;

	/**
	 * @var    object  Mock http object.
	 * @since  1.0
	 */
	protected $client;

	/**
	 * An instance of the object to test.
	 *
	 * @var    ClientInspector
	 * @since  1.0
	 */
	protected $object;

	/**
	 * @var   AbstractWebApplication|\PHPUnit_Framework_MockObject_MockObject  The application object to send HTTP headers for redirects.
	 */
	protected $application;

	/**
	 * @var    string  Sample JSON string.
	 * @since  1.0
	 */
	protected $sampleString = '{"a":1,"b":2,"c":3,"d":4,"e":5}';

	/**
	 * @var    string  Sample JSON error message.
	 * @since  1.0
	 */
	protected $errorString = '{"errorCode":401, "message": "Generic error"}';

	/**
	 * Sets up the fixture, for example, opens a network connection.
	 * This method is called before a test is executed.
	 *
	 * @return void
	 */
	protected function setUp()
	{
		$_SERVER['HTTP_HOST'] = 'example.com';
		$_SERVER['HTTP_USER_AGENT'] = 'Mozilla/5.0';
		$_SERVER['REQUEST_URI'] = '/index.php';
		$_SERVER['SCRIPT_NAME'] = '/index.php';

		$key = "TEST_KEY";
		$secret = "TEST_SECRET";
		$my_url = "TEST_URL";
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

		$this->options = new Registry;
		$this->client = $this->getMockBuilder('Joomla\\Http\\Http')->getMock();
		$this->input = new Input;
		$this->application = $this->getMockForAbstractClass('Joomla\\Application\\AbstractWebApplication');

		$mockSession = $this->getMockBuilder('Joomla\\Session\\Session')
			->disableOriginalConstructor()
			->getMock();

		$this->application->setSession($mockSession);

		$this->options->set('consumer_key', $key);
		$this->options->set('consumer_secret', $secret);
		$this->object = new ClientInspector($this->options, $this->client, $this->input, $this->application);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
	}

	/**
	* Provides test data.
	*
	* @return array
	*
	* @since 1.0
	*/
	public function seedAuthenticate()
	{
		// Token, fail and oauth version.
		return array(
			array(array('key' => 'valid', 'secret' => 'valid'), false, '1.0'),
			array(null, false, '1.0'),
			array(null, false, '1.0a'),
			array(null, true, '1.0a')
			);
	}

	/**
	 * Tests the authenticate method
	 *
	 * @param   array    $token    The passed token.
	 * @param   boolean  $fail     Mark if should fail or not.
	 * @param   string   $version  Specify oauth version 1.0 or 1.0a.
	 *
	 * @return  void
	 *
	 * @dataProvider seedAuthenticate
	 * @since   1.0
	 */
	public function testAuthenticate($token, $fail, $version)
	{
		// Already got some credentials stored?
		if (!\is_null($token))
		{
			$this->object->setToken($token);
			$result = $this->object->authenticate();
			$this->assertEquals($result, $token);
		}
		else
		{
			$this->object->setOption('requestTokenURL', 'https://example.com/request_token');
			$this->object->setOption('authoriseURL', 'https://example.com/authorize');
			$this->object->setOption('accessTokenURL', 'https://example.com/access_token');

			// Request token.
			$returnData = new \stdClass;
			$returnData->code = 200;
			$returnData->body = 'oauth_token=token&oauth_token_secret=secret&oauth_callback_confirmed=true';

			$this->client->expects($this->at(0))
				->method('post')
				->with($this->object->getOption('requestTokenURL'))
				->will($this->returnValue($returnData));

			$input = TestHelper::getValue($this->object, 'input');
			$input->set('oauth_verifier', null);
			TestHelper::setValue($this->object, 'input', $input);

			if (strcmp($version, '1.0a') === 0)
			{
				$this->object->setOption('callback', 'TEST_URL');
			}

			$this->object->authenticate();

			$token = $this->object->getToken();
			$this->assertEquals($token['key'], 'token');
			$this->assertEquals($token['secret'], 'secret');

			// Access token.
			$input = TestHelper::getValue($this->object, 'input');

			if (strcmp($version, '1.0a') === 0)
			{
				TestHelper::setValue($this->object, 'version', $version);
				$data = array('oauth_verifier' => 'verifier', 'oauth_token' => 'token');
			}
			else
			{
				TestHelper::setValue($this->object, 'version', $version);
				$data = array('oauth_token' => 'token');
			}

			TestHelper::setValue($input, 'data', $data);

			// Get mock session
			$mockSession = $this->getMockBuilder('Joomla\\Session\\Session')
				->disableOriginalConstructor()
				->getMock();

			if ($fail)
			{
				$mockSession->expects($this->at(0))
							->method('get')
							->with('oauth_token.key', null)
							->will($this->returnValue('bad'));

				$mockSession->expects($this->at(1))
							->method('get')
							->with('oauth_token.secret', null)
							->will($this->returnValue('session'));

				$this->application->setSession($mockSession);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

				// expectException was added in PHPUnit 5.2 and setExpectedException removed in 6.0
				if (method_exists($this, 'expectException'))
				{
					$this->expectException('DomainException');
				}
				else
				{
					$this->setExpectedException('DomainException');

				}

				$result = $this->object->authenticate();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
			}

			$mockSession->expects($this->at(0))
						->method('get')
						->with('oauth_token.key', null)
						->will($this->returnValue('token'));

			$mockSession->expects($this->at(1))
						->method('get')
						->with('oauth_token.secret', null)
						->will($this->returnValue('secret'));

			$this->application->setSession($mockSession);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

			$returnData = new \stdClass;
			$returnData->code = 200;
			$returnData->body = 'oauth_token=token_key&oauth_token_secret=token_secret';

			$this->client->expects($this->at(0))
				->method('post')
				->with($this->object->getOption('accessTokenURL'))
				->will($this->returnValue($returnData));

			$result = $this->object->authenticate();

			$this->assertEquals($result['key'], 'token_key');
			$this->assertEquals($result['secret'], 'token_secret');
		}
	}

	/**
	 * Tests the generateRequestToken method - failure
	 *
	 * @return  void
	 *
	 * @since   1.0
	 * @expectedException  \DomainException
	 */
	public function testGenerateRequestTokenFailure()
	{
		$this->object->setOption('requestTokenURL', 'https://example.com/request_token');

		$returnData = new \stdClass;
		$returnData->code = 200;
		$returnData->body = 'oauth_token=token&oauth_token_secret=secret&oauth_callback_confirmed=false';

		$this->client->expects($this->at(0))
			->method('post')
			->with($this->object->getOption('requestTokenURL'))
			->will($this->returnValue($returnData));

		TestHelper::invoke($this->object, 'generateRequestToken');
	}

	/**
	* Provides test data.
	*
	* @return array
	*
	* @since  1.0
	*/
	public function seedOauthRequest()
	{
		// Method
		return array(
			array('GET'),
			array('PUT'),
			array('DELETE')
			);
	}

	/**
	 * Tests the oauthRequest method
	 *
	 * @param   string  $method  The request method.
	 *
	 * @dataProvider seedOauthRequest
	 * @return  void
	 *
	 * @since   1.0
	 */
	public function testOauthRequest($method)
	{
		$returnData = new \stdClass;
		$returnData->code = 200;
		$returnData->body = $this->sampleString;

		if (strcmp($method, 'PUT') === 0)
		{
			$data = array('key1' => 'value1', 'key2' => 'value2');
			$this->client->expects($this->at(0))
				->method($method, $data)
				->with('www.example.com')
				->will($this->returnValue($returnData));

			$this->assertThat(
				$this->object->oauthRequest('www.example.com', $method, array('oauth_token' => '1235'), $data, array('Content-Type' => 'multipart/form-data')),
				$this->equalTo($returnData)
				);
		}
		else
		{
			$this->client->expects($this->at(0))
				->method($method)
				->with('www.example.com')
				->will($this->returnValue($returnData));

			$this->assertThat(
				$this->object->oauthRequest('www.example.com', $method, array('oauth_token' => '1235'), array(), array('Content-Type' => 'multipart/form-data')),
				$this->equalTo($returnData)
				);
		}
	}

	/**
	 * Tests the safeEncode
	 *
	 * @return  void
	 *
	 * @since   1.0
	 */
	public function testSafeEncodeEmpty()
	{
		$this->assertThat(
			$this->object->safeEncode(null),
			$this->equalTo('')
			);
	}
}


Issues (24)

Security Analysis not enabled

Tests/ClientTest.php (9 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

1			<?php
2			/**
3			* @copyright Copyright (C) 2005 - 2018 Open Source Matters, Inc. All rights reserved.
4			* @license GNU General Public License version 2 or later; see LICENSE
5			*/
6
7			namespace Joomla\OAuth1\Tests;
8
9			use Joomla\Application\AbstractWebApplication;
10			use Joomla\Input\Input;
11			use Joomla\OAuth1\Client;
12			use Joomla\Registry\Registry;
13			use Joomla\Test\TestHelper;
14			use PHPUnit\Framework\TestCase;
15
16			require_once __DIR__ . '/stubs/ClientInspector.php';
17
18			/**
19			* Test class for OAuth1 Client.
20			*
21			* @since 1.0
22			*/
23			class ClientTest extends TestCase
24			{
25			/**
26			* @var Input input for the Client object.
27			* @since 1.0
28			*/
29			protected $input;
30
31			/**
32			* @var Registry Options for the Client object.
33			* @since 1.0
34			*/
35			protected $options;
36
37			/**
38			* @var object Mock http object.
39			* @since 1.0
40			*/
41			protected $client;
42
43			/**
44			* An instance of the object to test.
45			*
46			* @var ClientInspector
47			* @since 1.0
48			*/
49			protected $object;
50
51			/**
52			* @var AbstractWebApplication\|\PHPUnit_Framework_MockObject_MockObject The application object to send HTTP headers for redirects.
53			*/
54			protected $application;
55
56			/**
57			* @var string Sample JSON string.
58			* @since 1.0
59			*/
60			protected $sampleString = '{"a":1,"b":2,"c":3,"d":4,"e":5}';
61
62			/**
63			* @var string Sample JSON error message.
64			* @since 1.0
65			*/
66			protected $errorString = '{"errorCode":401, "message": "Generic error"}';
67
68			/**
69			* Sets up the fixture, for example, opens a network connection.
70			* This method is called before a test is executed.
71			*
72			* @return void
73			*/
74			protected function setUp()
75			{
76			$_SERVER['HTTP_HOST'] = 'example.com';
77			$_SERVER['HTTP_USER_AGENT'] = 'Mozilla/5.0';
78			$_SERVER['REQUEST_URI'] = '/index.php';
79			$_SERVER['SCRIPT_NAME'] = '/index.php';
80
81			$key = "TEST_KEY";
82			$secret = "TEST_SECRET";
83			$my_url = "TEST_URL";
			0 ignored issues – show Unused Code introduced 2016-01-30 19:27 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$my_url` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
84
85			$this->options = new Registry;
86			$this->client = $this->getMockBuilder('Joomla\\Http\\Http')->getMock();
87			$this->input = new Input;
88			$this->application = $this->getMockForAbstractClass('Joomla\\Application\\AbstractWebApplication');
89
90			$mockSession = $this->getMockBuilder('Joomla\\Session\\Session')
91			->disableOriginalConstructor()
92			->getMock();
93
94			$this->application->setSession($mockSession);
95
96			$this->options->set('consumer_key', $key);
97			$this->options->set('consumer_secret', $secret);
98			$this->object = new ClientInspector($this->options, $this->client, $this->input, $this->application);
			0 ignored issues – show Documentation introduced 2016-01-30 19:27 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$this->options` is of type `object<Joomla\Registry\Registry>`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Documentation introduced 2018-01-30 02:03 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$this->client` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Joomla\Http\Http>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Documentation introduced 2018-01-30 02:03 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$this->application` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Joomla\Application\AbstractWebApplication>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
99			}
100
101			/**
102			* Provides test data.
103			*
104			* @return array
105			*
106			* @since 1.0
107			*/
108			public function seedAuthenticate()
109			{
110			// Token, fail and oauth version.
111			return array(
112			array(array('key' => 'valid', 'secret' => 'valid'), false, '1.0'),
113			array(null, false, '1.0'),
114			array(null, false, '1.0a'),
115			array(null, true, '1.0a')
116			);
117			}
118
119			/**
120			* Tests the authenticate method
121			*
122			* @param array $token The passed token.
123			* @param boolean $fail Mark if should fail or not.
124			* @param string $version Specify oauth version 1.0 or 1.0a.
125			*
126			* @return void
127			*
128			* @dataProvider seedAuthenticate
129			* @since 1.0
130			*/
131			public function testAuthenticate($token, $fail, $version)
132			{
133			// Already got some credentials stored?
134			if (!\is_null($token))
135			{
136			$this->object->setToken($token);
137			$result = $this->object->authenticate();
138			$this->assertEquals($result, $token);
139			}
140			else
141			{
142			$this->object->setOption('requestTokenURL', 'https://example.com/request_token');
143			$this->object->setOption('authoriseURL', 'https://example.com/authorize');
144			$this->object->setOption('accessTokenURL', 'https://example.com/access_token');
145
146			// Request token.
147			$returnData = new \stdClass;
148			$returnData->code = 200;
149			$returnData->body = 'oauth_token=token&oauth_token_secret=secret&oauth_callback_confirmed=true';
150
151			$this->client->expects($this->at(0))
152			->method('post')
153			->with($this->object->getOption('requestTokenURL'))
154			->will($this->returnValue($returnData));
155
156			$input = TestHelper::getValue($this->object, 'input');
157			$input->set('oauth_verifier', null);
158			TestHelper::setValue($this->object, 'input', $input);
159
160			if (strcmp($version, '1.0a') === 0)
161			{
162			$this->object->setOption('callback', 'TEST_URL');
163			}
164
165			$this->object->authenticate();
166
167			$token = $this->object->getToken();
168			$this->assertEquals($token['key'], 'token');
169			$this->assertEquals($token['secret'], 'secret');
170
171			// Access token.
172			$input = TestHelper::getValue($this->object, 'input');
173
174			if (strcmp($version, '1.0a') === 0)
175			{
176			TestHelper::setValue($this->object, 'version', $version);
177			$data = array('oauth_verifier' => 'verifier', 'oauth_token' => 'token');
178			}
179			else
180			{
181			TestHelper::setValue($this->object, 'version', $version);
182			$data = array('oauth_token' => 'token');
183			}
184
185			TestHelper::setValue($input, 'data', $data);
186
187			// Get mock session
188			$mockSession = $this->getMockBuilder('Joomla\\Session\\Session')
189			->disableOriginalConstructor()
190			->getMock();
191
192			if ($fail)
193			{
194			$mockSession->expects($this->at(0))
195			->method('get')
196			->with('oauth_token.key', null)
197			->will($this->returnValue('bad'));
198
199			$mockSession->expects($this->at(1))
200			->method('get')
201			->with('oauth_token.secret', null)
202			->will($this->returnValue('session'));
203
204			$this->application->setSession($mockSession);
			0 ignored issues – show Documentation introduced 2018-01-30 02:03 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$mockSession` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Joomla\Session\Session>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Bug introduced 2017-08-06 16:22 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `setSession` does only exist in `Joomla\Application\AbstractWebApplication`, but not in `PHPUnit_Framework_MockObject_MockObject`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
205
206			// expectException was added in PHPUnit 5.2 and setExpectedException removed in 6.0
207			if (method_exists($this, 'expectException'))
208			{
209			$this->expectException('DomainException');
210			}
211			else
212			{
213			$this->setExpectedException('DomainException');
			0 ignored issues – show Bug introduced 2017-02-19 19:58 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `setExpectedException()` does not exist on `Joomla\OAuth1\Tests\ClientTest`. Did you maybe mean `setExpectedExceptionFromAnnotation()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
214			}
215
216			$result = $this->object->authenticate();
			0 ignored issues – show Unused Code introduced 2016-01-30 19:27 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$result` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
217			}
218
219			$mockSession->expects($this->at(0))
220			->method('get')
221			->with('oauth_token.key', null)
222			->will($this->returnValue('token'));
223
224			$mockSession->expects($this->at(1))
225			->method('get')
226			->with('oauth_token.secret', null)
227			->will($this->returnValue('secret'));
228
229			$this->application->setSession($mockSession);
			0 ignored issues – show Documentation introduced 2018-01-30 02:03 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$mockSession` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Joomla\Session\Session>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
230
231			$returnData = new \stdClass;
232			$returnData->code = 200;
233			$returnData->body = 'oauth_token=token_key&oauth_token_secret=token_secret';
234
235			$this->client->expects($this->at(0))
236			->method('post')
237			->with($this->object->getOption('accessTokenURL'))
238			->will($this->returnValue($returnData));
239
240			$result = $this->object->authenticate();
241
242			$this->assertEquals($result['key'], 'token_key');
243			$this->assertEquals($result['secret'], 'token_secret');
244			}
245			}
246
247			/**
248			* Tests the generateRequestToken method - failure
249			*
250			* @return void
251			*
252			* @since 1.0
253			* @expectedException \DomainException
254			*/
255			public function testGenerateRequestTokenFailure()
256			{
257			$this->object->setOption('requestTokenURL', 'https://example.com/request_token');
258
259			$returnData = new \stdClass;
260			$returnData->code = 200;
261			$returnData->body = 'oauth_token=token&oauth_token_secret=secret&oauth_callback_confirmed=false';
262
263			$this->client->expects($this->at(0))
264			->method('post')
265			->with($this->object->getOption('requestTokenURL'))
266			->will($this->returnValue($returnData));
267
268			TestHelper::invoke($this->object, 'generateRequestToken');
269			}
270
271			/**
272			* Provides test data.
273			*
274			* @return array
275			*
276			* @since 1.0
277			*/
278			public function seedOauthRequest()
279			{
280			// Method
281			return array(
282			array('GET'),
283			array('PUT'),
284			array('DELETE')
285			);
286			}
287
288			/**
289			* Tests the oauthRequest method
290			*
291			* @param string $method The request method.
292			*
293			* @dataProvider seedOauthRequest
294			* @return void
295			*
296			* @since 1.0
297			*/
298			public function testOauthRequest($method)
299			{
300			$returnData = new \stdClass;
301			$returnData->code = 200;
302			$returnData->body = $this->sampleString;
303
304			if (strcmp($method, 'PUT') === 0)
305			{
306			$data = array('key1' => 'value1', 'key2' => 'value2');
307			$this->client->expects($this->at(0))
308			->method($method, $data)
309			->with('www.example.com')
310			->will($this->returnValue($returnData));
311
312			$this->assertThat(
313			$this->object->oauthRequest('www.example.com', $method, array('oauth_token' => '1235'), $data, array('Content-Type' => 'multipart/form-data')),
314			$this->equalTo($returnData)
315			);
316			}
317			else
318			{
319			$this->client->expects($this->at(0))
320			->method($method)
321			->with('www.example.com')
322			->will($this->returnValue($returnData));
323
324			$this->assertThat(
325			$this->object->oauthRequest('www.example.com', $method, array('oauth_token' => '1235'), array(), array('Content-Type' => 'multipart/form-data')),
326			$this->equalTo($returnData)
327			);
328			}
329			}
330
331			/**
332			* Tests the safeEncode
333			*
334			* @return void
335			*
336			* @since 1.0
337			*/
338			public function testSafeEncodeEmpty()
339			{
340			$this->assertThat(
341			$this->object->safeEncode(null),
342			$this->equalTo('')
343			);
344			}
345			}
346

joomla-framework / oauth1

Issues (24)

Security Analysis not enabled

Tests/ClientTest.php (9 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Duplication Side-by-Side

Filter issues like