JFormFieldLanguageTest - Code Metrics - joomla-framework/form - Measure and Improve Code Quality continuously with Scrutinizer

JFormFieldLanguageTest A
last analyzed 2021-04-26 11:24 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	103
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

Metric	Value
dl	0
loc	103
rs	10
c	0
b	0
f	0
wmc	4
lcom	1
cbo	4

4 Methods

Rating	Name	Size	Complexity
A	setUp()	7	1
A	getDataSet()	4	1
A	testGetInput()	30	1
A	testCreateLanguageList()	30	1

<?php
/**
 * @copyright  Copyright (C) 2005 - 2016 Open Source Matters, Inc. All rights reserved.
 * @license    GNU General Public License version 2 or later; see LICENSE
 */

namespace Joomla\Form\Tests;

use Joomla\Test\TestDatabase;
use Joomla\Form\Field_Language;

/**
 * Test class for JFormFieldLanguage.
 *
 * @since  1.0
 */
class JFormFieldLanguageTest extends TestDatabase

{
	/**
	 * Sets up dependencies for the test.
	 *
	 * @return  void
	 *
	 * @since   1.0
	 */
	protected function setUp()
	{
		// The real class cannot be autoloaded
		\Joomla\Form\FormHelper::loadFieldClass('language');

		parent::setUp();

	}

	/**
	 * Gets the data set to be loaded into the database during setup
	 *
	 * @return  \PHPUnit_Extensions_Database_DataSet_XmlDataSet  dataset
	 *
	 * @since   1.0
	 */
	protected function getDataSet()
	{
		return $this->createXMLDataSet(__DIR__ . '/testfiles/JFormField.xml');
	}

	/**
	 * Test the getInput method.
	 *
	 * @return  void
	 *
	 * @since   1.0
	 */
	public function testGetInput()
	{
		$form = new JFormInspector('form1');

		$this->assertThat(
			$form->load('<form><field name="language" type="language" /></form>'),
			$this->isTrue(),
			'Line:' . __LINE__ . ' XML string should load successfully.'
		);

		/** @var Field_Language $field */
		$field = \Joomla\Form\FormHelper::loadFieldType('language');

		$field->setForm($form);

		$this->assertThat(
			$field->setup($form->getXml()->field, 'value'),
			$this->isTrue(),
			'Line:' . __LINE__ . ' The setup method should return true.'
		);

		$this->markTestIncomplete('Problems encountered in next assertion');

		$this->assertThat(
			strlen($field->input),
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
			$this->greaterThan(0),
			'Line:' . __LINE__ . ' The getInput method should return something without error.'
		);

		// TODO: Should check all the attributes have come in properly.
	}

	/**
	 * Test...
	 *
	 * @return void
	 */
	public function testCreateLanguageList()
	{
		/** @var Field_Language $field */
		$field = \Joomla\Form\FormHelper::loadFieldType('language');

		$field->setForm(new JFormInspector('form1'));
		$reflection = new \ReflectionClass($field);
		$method = $reflection->getMethod('createLanguageList');
		$method->setAccessible(true);

		$list = $method->invokeArgs(
			$field,
			array(
				'en-GB',
				__DIR__ . '/data'
			)
		);

		$listCompareEqual = array(
			array(
				'text' => 'English (United Kingdom)',
				'value' => 'en-GB',
				'selected' => 'selected="selected"'
			)
		);

		$this->assertEquals(
			$listCompareEqual,
			$list
		);
	}
}


1			<?php
2			/**
3			* @copyright Copyright (C) 2005 - 2016 Open Source Matters, Inc. All rights reserved.
4			* @license GNU General Public License version 2 or later; see LICENSE
5			*/
6
7			namespace Joomla\Form\Tests;
8
9			use Joomla\Test\TestDatabase;
10			use Joomla\Form\Field_Language;
11
12			/**
13			* Test class for JFormFieldLanguage.
14			*
15			* @since 1.0
16			*/
17			class JFormFieldLanguageTest extends TestDatabase
			0 ignored issues – show Deprecated Code introduced 2021-04-26 11:24 UTC by Report Bug Copy Issue Report The class `Joomla\Test\TestDatabase` has been deprecated with message: 2.0 Deprecated due to the deprecation of `phpunit/dbunit` This class, trait or interface has been deprecated. The supplier of the file has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the type will be removed from the class and what other constant to use instead. Loading history...
18			{
19			/**
20			* Sets up dependencies for the test.
21			*
22			* @return void
23			*
24			* @since 1.0
25			*/
26			protected function setUp()
27			{
28			// The real class cannot be autoloaded
29			\Joomla\Form\FormHelper::loadFieldClass('language');
30
31			parent::setUp();
			0 ignored issues – show Deprecated Code introduced 2021-04-26 11:24 UTC by Report Bug Copy Issue Report The method `Joomla\Test\TestDatabase::setUp()` has been deprecated with message: 2.0 This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
32			}
33
34			/**
35			* Gets the data set to be loaded into the database during setup
36			*
37			* @return \PHPUnit_Extensions_Database_DataSet_XmlDataSet dataset
38			*
39			* @since 1.0
40			*/
41			protected function getDataSet()
42			{
43			return $this->createXMLDataSet(__DIR__ . '/testfiles/JFormField.xml');
44			}
45
46			/**
47			* Test the getInput method.
48			*
49			* @return void
50			*
51			* @since 1.0
52			*/
53			public function testGetInput()
54			{
55			$form = new JFormInspector('form1');
56
57			$this->assertThat(
58			$form->load('<form><field name="language" type="language" /></form>'),
59			$this->isTrue(),
60			'Line:' . __LINE__ . ' XML string should load successfully.'
61			);
62
63			/** @var Field_Language $field */
64			$field = \Joomla\Form\FormHelper::loadFieldType('language');
			0 ignored issues – show Deprecated Code introduced 2021-04-26 11:24 UTC by Report Bug Copy Issue Report The method `Joomla\Form\FormHelper::loadFieldType()` has been deprecated with message: 2.0 Field objects should be autoloaded This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
65			$field->setForm($form);
66
67			$this->assertThat(
68			$field->setup($form->getXml()->field, 'value'),
69			$this->isTrue(),
70			'Line:' . __LINE__ . ' The setup method should return true.'
71			);
72
73			$this->markTestIncomplete('Problems encountered in next assertion');
74
75			$this->assertThat(
76			strlen($field->input),
			0 ignored issues – show Documentation introduced 2021-04-26 11:24 UTC by Report Bug Copy Issue Report The property `$input` is declared protected in `Joomla\Form\Field`. Since you implemented `__get()`, maybe consider adding a @property or @property-read annotation. This makes it easier for IDEs to provide auto-completion. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
77			$this->greaterThan(0),
78			'Line:' . __LINE__ . ' The getInput method should return something without error.'
79			);
80
81			// TODO: Should check all the attributes have come in properly.
82			}
83
84			/**
85			* Test...
86			*
87			* @return void
88			*/
89			public function testCreateLanguageList()
90			{
91			/** @var Field_Language $field */
92			$field = \Joomla\Form\FormHelper::loadFieldType('language');
			0 ignored issues – show Deprecated Code introduced 2021-04-26 11:24 UTC by Report Bug Copy Issue Report The method `Joomla\Form\FormHelper::loadFieldType()` has been deprecated with message: 2.0 Field objects should be autoloaded This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
93			$field->setForm(new JFormInspector('form1'));
94			$reflection = new \ReflectionClass($field);
95			$method = $reflection->getMethod('createLanguageList');
96			$method->setAccessible(true);
97
98			$list = $method->invokeArgs(
99			$field,
100			array(
101			'en-GB',
102			__DIR__ . '/data'
103			)
104			);
105
106			$listCompareEqual = array(
107			array(
108			'text' => 'English (United Kingdom)',
109			'value' => 'en-GB',
110			'selected' => 'selected="selected"'
111			)
112			);
113
114			$this->assertEquals(
115			$listCompareEqual,
116			$list
117			);
118			}
119			}
120

joomla-framework / form

JFormFieldLanguageTest A last analyzed 2021-04-26 11:24 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

Duplication Side-by-Side

Filter issues like

JFormFieldLanguageTest A
last analyzed 2021-04-26 11:24 UTC