Field_Spacer - Code Metrics - joomla-framework/form - Measure and Improve Code Quality continuously with Scrutinizer

Field_Spacer A
last analyzed 2021-04-26 11:24 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	94
Duplicated Lines	8.51 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

Metric	Value
dl	8
loc	94
rs	10
c	0
b	0
f	0
wmc	11
lcom	1
cbo	2

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getInput()	0	4	1
B	getLabel()	8	49	9
A	getTitle()	0	4	1

How to fix Duplicated Code

<?php
/**
 * Part of the Joomla Framework Form Package
 *
 * @copyright  Copyright (C) 2005 - 2016 Open Source Matters, Inc. All rights reserved.
 * @license    GNU General Public License version 2 or later; see LICENSE
 */

namespace Joomla\Form;

use Joomla\Language\Text;

/**
 * Form Field class for the Joomla Framework.
 * Provides spacer markup to be used in form layouts.
 *
 * @since       1.0
 * @deprecated  The joomla/form package is deprecated
 */
class Field_Spacer extends Field

{
	/**
	 * The form field type.
	 *
	 * @var    string
	 * @since  1.0
	 */
	protected $type = 'Spacer';

	/**
	 * Method to get the field input markup for a spacer.
	 * The spacer does not have accept input.
	 *
	 * @return  string  The field input markup.
	 *
	 * @since   1.0
	 */
	protected function getInput()
	{
		return ' ';
	}

	/**
	 * Method to get the field label markup for a spacer.
	 * Use the label text or name from the XML element as the spacer or
	 * Use a hr="true" to automatically generate plain hr markup
	 *
	 * @return  string  The field label markup.
	 *
	 * @since   1.0
	 */
	protected function getLabel()
	{
		$html = array();
		$class = $this->element['class'] ? (string) $this->element['class'] : '';

		$html[] = '<span class="spacer">';
		$html[] = '<span class="before"></span>';
		$html[] = '<span class="' . $class . '">';

		if ((string) $this->element['hr'] == 'true')
		{
			$html[] = '<hr class="' . $class . '" />';
		}
		else
		{
			$label = '';

			// Get the label text from the XML element, defaulting to the element name.
			$text = $this->element['label'] ? (string) $this->element['label'] : (string) $this->element['name'];
			$text = $this->translateLabel ? Text::_($text) : $text;


			// Build the class for the label.
			$class = !empty($this->description) ? 'hasTip' : '';
			$class = $this->required == true ? $class . ' required' : $class;


			// Add the opening label tag and main attributes attributes.
			$label .= '<label id="' . $this->id . '-lbl" class="' . $class . '"';

			// If a description is specified, use it to build a tooltip.
			if (!empty($this->description))

			{
				$label .= ' title="'
					. htmlspecialchars(
					trim($text, ':') . '::' . ($this->translateDescription ? Text::_($this->description) : $this->description),

					ENT_COMPAT, 'UTF-8'
				) . '"';
			}

			// Add the label text and closing tag.
			$label .= '>' . $text . '</label>';
			$html[] = $label;
		}

		$html[] = '</span>';
		$html[] = '<span class="after"></span>';
		$html[] = '</span>';

		return implode('', $html);
	}

	/**
	 * Method to get the field title.
	 *
	 * @return  string  The field title.
	 *
	 * @since   1.0
	 */
	protected function getTitle()
	{
		return $this->getLabel();
	}
}


1		<?php
2		/**
3		* Part of the Joomla Framework Form Package
4		*
5		* @copyright Copyright (C) 2005 - 2016 Open Source Matters, Inc. All rights reserved.
6		* @license GNU General Public License version 2 or later; see LICENSE
7		*/
8
9		namespace Joomla\Form;
10
11		use Joomla\Language\Text;
12
13		/**
14		* Form Field class for the Joomla Framework.
15		* Provides spacer markup to be used in form layouts.
16		*
17		* @since 1.0
18		* @deprecated The joomla/form package is deprecated
19		*/
20		class Field_Spacer extends Field
		0 ignored issues – show Deprecated Code introduced 2021-04-26 11:24 UTC by Report Bug Copy Issue Report The class `Joomla\Form\Field` has been deprecated with message: The joomla/form package is deprecated This class, trait or interface has been deprecated. The supplier of the file has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the type will be removed from the class and what other constant to use instead. Loading history...
21		{
22		/**
23		* The form field type.
24		*
25		* @var string
26		* @since 1.0
27		*/
28		protected $type = 'Spacer';
29
30		/**
31		* Method to get the field input markup for a spacer.
32		* The spacer does not have accept input.
33		*
34		* @return string The field input markup.
35		*
36		* @since 1.0
37		*/
38		protected function getInput()
39		{
40		return ' ';
41		}
42
43		/**
44		* Method to get the field label markup for a spacer.
45		* Use the label text or name from the XML element as the spacer or
46		* Use a hr="true" to automatically generate plain hr markup
47		*
48		* @return string The field label markup.
49		*
50		* @since 1.0
51		*/
52		protected function getLabel()
53		{
54		$html = array();
55		$class = $this->element['class'] ? (string) $this->element['class'] : '';
56
57		$html[] = '<span class="spacer">';
58		$html[] = '<span class="before"></span>';
59		$html[] = '<span class="' . $class . '">';
60
61		if ((string) $this->element['hr'] == 'true')
62		{
63		$html[] = '<hr class="' . $class . '" />';
64		}
65		else
66		{
67		$label = '';
68
69		// Get the label text from the XML element, defaulting to the element name.
70		$text = $this->element['label'] ? (string) $this->element['label'] : (string) $this->element['name'];
71		$text = $this->translateLabel ? Text::_($text) : $text;
		0 ignored issues – show Deprecated Code introduced 2021-04-26 11:24 UTC by Report Bug Copy Issue Report The method `Joomla\Language\Text::_()` has been deprecated with message: 2.0 Will be replaced with a `translate` method. This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
72
73		// Build the class for the label.
74		$class = !empty($this->description) ? 'hasTip' : '';
75		$class = $this->required == true ? $class . ' required' : $class;
		0 ignored issues – show Coding Style Best Practice introduced 2016-01-01 23:45 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing two booleans. Considering using the strict comparison `===` instead. When comparing two booleans, it is generally considered safer to use the strict comparison operator. Loading history...
76
77		// Add the opening label tag and main attributes attributes.
78		$label .= '<label id="' . $this->id . '-lbl" class="' . $class . '"';
79
80		// If a description is specified, use it to build a tooltip.
81	View Code Duplication	if (!empty($this->description))
		0 ignored issues – show Duplication introduced 2016-01-01 23:45 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
82		{
83		$label .= ' title="'
84		. htmlspecialchars(
85		trim($text, ':') . '::' . ($this->translateDescription ? Text::_($this->description) : $this->description),
		0 ignored issues – show Deprecated Code introduced 2021-04-26 11:24 UTC by Report Bug Copy Issue Report The method `Joomla\Language\Text::_()` has been deprecated with message: 2.0 Will be replaced with a `translate` method. This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
86		ENT_COMPAT, 'UTF-8'
87		) . '"';
88		}
89
90		// Add the label text and closing tag.
91		$label .= '>' . $text . '</label>';
92		$html[] = $label;
93		}
94
95		$html[] = '</span>';
96		$html[] = '<span class="after"></span>';
97		$html[] = '</span>';
98
99		return implode('', $html);
100		}
101
102		/**
103		* Method to get the field title.
104		*
105		* @return string The field title.
106		*
107		* @since 1.0
108		*/
109		protected function getTitle()
110		{
111		return $this->getLabel();
112		}
113		}
114

joomla-framework / form

Field_Spacer A last analyzed 2021-04-26 11:24 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like

Field_Spacer A
last analyzed 2021-04-26 11:24 UTC