Joomla\Cache\Tests\MemcachedTest::setUp()

Complexity

Conditions	11
Paths	35

Size

Total Lines

66

Duplication

Lines	11
Ratio	16.67 %

Importance

Changes

0

<?php
	public function setUp()
	{
		if (!class_exists('Memcached'))
		{
			$this->markTestSkipped(
				'The Memcached class does not exist.'
			);

			return;
		}

		// Parse the DSN details for the test server
		$dsn = defined('JTEST_CACHE_MEMCACHED_DSN') ? JTEST_CACHE_MEMCACHED_DSN : getenv('JTEST_CACHE_MEMCACHED_DSN');

		if ($dsn)
		{
			$options = $this->cacheOptions;

			if (!$options)

The expression $options of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

			{
				$options = array();
			}

			// First let's trim the memcached: part off the front of the DSN if it exists.
			if (strpos($dsn, 'memcached:') === 0)
			{
				$dsn = substr($dsn, 10);
			}

			if (!is_array($options))
			{
				$options = array($options);
			}

			// Split the DSN into its parts over semicolons.
			$parts = explode(';', $dsn);

			if (!isset($options['memcache.servers']))
			{
				$server = new \stdClass;

				// Parse each part and populate the options array.
				foreach ($parts as $part)

This code seems to be duplicated across your project.

				{
					list ($k, $v) = explode('=', $part, 2);
					switch ($k)
					{
						case 'host':
						case 'port':
							$server->$k = $v;
							break;
					}
				}
				$options['memcache.servers'] = array($server);
			}

			$this->cacheOptions = $options;
		}
		else
		{
			$this->markTestSkipped('No configuration for Memcached given');
		}

		$this->cacheClass = 'Joomla\\Cache\\Memcached';
		parent::setUp();
	}
}