App\Wizard\Import\ProjectSteps\SelectWorksheetsStep

Complexity

Total Complexity

17

Size/Duplication

Total Lines	107
Duplicated Lines	0 %

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	rules()	0	4	1
A	validate()	0	6	1
A	fields()	0	7	1
D	PreProcess()	0	36	11
B	process()	0	38	3

<?php

/** Created by PhpStorm,  User: jonphipps,  Date: 2017-05-31,  Time: 11:14 AM */

namespace App\Wizard\Import\ProjectSteps;

use App\Jobs\ParseVocabulary;
use App\Models\Batch;
use App\Models\ConceptAttribute;
use App\Models\ElementAttribute;
use App\Models\Export;
use App\Models\Import;
use Illuminate\Http\Request;
use Illuminate\Support\Facades\Validator;
use Smajti1\Laravel\Step;
use Smajti1\Laravel\Wizard;
use function dispatch;
use function explode;

class SelectWorksheetsStep extends Step
{
    public static $label = 'Choose the Worksheets...';
    public static $slug  = 'worksheets';
    public static $view  = 'frontend.import.project.steps.worksheets';

    public function fields(): array
    {
        return [
            [
                'name'  => 'worksheets',
                'label' => 'Select the worksheets to import',
                'type'  => 'jqxgrid_select',
            ],
        ];
    }

    public function PreProcess(Request $request, Wizard $wizard)

The parameter $request is not used and could be removed.

    {
        $worksheets = [];
        $sheets     = $wizard->data()['googlesheets'];
        //it's already in the correct form
        if (is_array($sheets) && isset($sheets[0])) {
            return;
        }
        foreach ($sheets as $key => $worksheet) {
            $export               = Export::find($worksheet['id']);
            $sheet['worksheet']   = $export->worksheet;
            $sheet['languages']   = $export->languages;
            $sheet['exported_at'] = $export->created_at->toDayDateTimeString();

The method toDayDateTimeString() does not exist on DateTime. It seems like you code against a sub-type of said class. However, the method does not exist in MockeryTest_ClassThatDescendsFromInternalClass. Are you sure you never get one of those?

            if ($export->elementset) {
                $id                     = $export->elementset->id;
                $sheet['last_edit']     = ElementAttribute::getLatestDateForElementSet($id);
                $sheet['elementset_id'] = $id;
            }
            if ($export->vocabulary) {
                $id                     = $export->vocabulary->id;
                $sheet['last_edit']     = ConceptAttribute::getLatestDateForVocabulary($id);
                $sheet['vocabulary_id'] = $id;
            }
            $sheet['last_edit']            =
                $sheet['last_edit'] ? $sheet['last_edit']->toDayDateTimeString() : 'Never Edited';

The variable $sheet seems to be defined later in this foreach loop on line 47. Are you sure it is defined here?

            $sheet['id']                   = $export->id . '::' . $key;
            $lastImport                    = $export->getLatestImport();
            $sheet['last_import']          =
                ($lastImport && $lastImport->imported_at) ? $lastImport->imported_at->toDayDateTimeString() :
                    'Never Imported';
            $sheet['last_import_batch_id'] = ($lastImport && $lastImport->batch_id) ? $lastImport->batch_id : '';
            $worksheets[]                  = $sheet;
        }
        $data                 = $wizard->data();
        $data['googlesheets'] = $worksheets;
        $wizard->data($data);
    }

    public function process(Request $request): void
    {
        $worksheets[] = json_decode($request->selected_worksheets);

$worksheets was never initialized. Although not strictly required by PHP, it is generally a good practice to add $worksheets = array(); before regardless.

        $spreadsheet  = $this->wizard->dataGet('spreadsheet');
        $batch_id     = $this->wizard->dataGet('batch_id');
        /** @var Batch $batch */
        $batch                = Batch::findOrFail($batch_id);
        $batch->total_count   = count($worksheets[0]);
        $unfinishedImports    = $batch->imports()->whereNull('imported_at');
        if ($unfinishedImports) {
            $unfinishedImports->delete();
        }
        $batch->save();

        // setup a job for each worksheet
        foreach ($worksheets[0] as $worksheet) {
            [ $export_id, $worksheet_id ] = explode('::', $worksheet);
            $export                       = Export::find($export_id);
            $import                       =
                Import::create([
                    'worksheet'     => $worksheet_id,
                    'source'        => 'Google',
                    'user_id'       => auth()->id(),
                    'batch_id'      => $batch_id,
                    'schema_id'     => $export->schema_id,
                    'vocabulary_id' => $export->vocabulary_id,
                ]);
            $export->addImports($import);
            // setup a job to run the worksheet processor to get the change instructions for each vocab
            dispatch(new ParseVocabulary($import, $worksheet_id, $spreadsheet));
            // each worksheet being processed will have its own checkbox table, hidden as a master->detail
            //it should look as if each of the worksheet selection rows had simply expanded to show the instructions
            // the row itself should have the master of the master-detail row just below with a summary of the changes
            $foo = 'bar';

The assignment to $foo is dead and can be removed.

        }

        // save progress to session
        $this->saveProgress($request, ['googlesheets' => $this->wizard->dataGet('googlesheets')]);
    }

    public function validate(Request $request)
    {
        Validator::make(['selected_worksheets' => json_decode($request->selected_worksheets)],
            ['selected_worksheets'          => 'required'],
            ['selected_worksheets.required' => 'You must select at least one worksheet before you can move to the next step.'])
            ->validate();
    }

    public function rules(Request $request = null)
    {
        return [
            'selected_worksheets' => 'required',
        ];
    }
}