App\Jobs\Publish

Complexity

Total Complexity

6

Size/Duplication

Total Lines	83
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
B	handle()	0	49	5

<?php

namespace App\Jobs;

use App\Exceptions\GithubAuthenticationException;
use App\Models\Release;
use App\Notifications\Frontend\ReleaseWasPublished;
use App\Services\Publish\Git;
use App\Services\Publish\GitHubService;
use Illuminate\Bus\Queueable;
use Illuminate\Contracts\Queue\ShouldQueue;
use Illuminate\Foundation\Bus\Dispatchable;
use Illuminate\Queue\InteractsWithQueue;
use Illuminate\Queue\SerializesModels;
use Illuminate\Support\Carbon;
use Illuminate\Support\Facades\Redirect;

class Publish implements ShouldQueue
{
    use Dispatchable, InteractsWithQueue, Queueable, SerializesModels;

The trait Illuminate\Queue\SerializesModels requires some properties which are not provided by App\Jobs\Publish: $id, $class

    /**
     * @var Release
     */
    private $release;
    /**
     * @var string
     */
    private $disk;

    /**
     * Create a new job instance.
     *
     * @param Release $release
     * @param string  $disk
     */
    public function __construct(Release $release, $disk = GenerateRdf::REPO_ROOT)
    {
        $this->release = $release;
        $this->disk    = $disk;
    }

    /**
     * Execute the job.
     *
     * @return void
     * @throws \InvalidArgumentException
     * @throws \GitWrapper\GitException
     * @throws \Symfony\Component\Process\Exception\RuntimeException
     * @throws \Symfony\Component\Process\Exception\ProcessFailedException
     * @throws \Symfony\Component\Process\Exception\LogicException
     */
    public function handle()
    {
        //todo:lot's more try/catch here
        $project = $this->release->project;
        $repo    = $project->repo;

The assignment to $repo is dead and can be removed.

        $user    = $this->release->user;

        //todo: rdf generator shouldn't responsible for storage management
        Git::initDir($project, $this->disk, $user);

It seems like $project can also be of type null; however, parameter $project of App\Services\Publish\Git::initDir() does only seem to accept App\Models\Project, maybe add an additional type check?

It seems like $user can also be of type null; however, parameter $user of App\Services\Publish\Git::initDir() does only seem to accept App\Models\Access\User\User, maybe add an additional type check?

        //todo: this section should be in a transaction
        $this->release->published_at = Carbon::now();
        $this->release->save();
        //foreach selected vocabulary
        $vocabs = $this->release->vocabularies()->get();
        foreach ($vocabs as $vocab) {
            $job = new GenerateRdf($vocab, $this->release, $this->disk);
            $job->handle();
        }
        $vocabs = $this->release->elementsets()->get();
        foreach ($vocabs as $vocab) {
            $job = new GenerateRdf($vocab, $this->release, $this->disk);
            $job->handle();
        }
        //when the jobs are complete:
        //commit the generated rdf with the version as the commit message
        Git::commitDir($project, $this->release->name, $this->disk);

        if ($project->repo) {
            //push the repo to github
            Git::updateRemote($this->release, $this->disk, $user);
            //push the release to GitHub
            $gitHub = new GitHubService($this->release);
            try {
                $gitHub->setRelease();
            }
            catch (GithubAuthenticationException $e) {
                Redirect::back()->withErrors([
                    'You\'re trying to access GitHub, but you don\'t seem to have any current GitHub credentials.',
                    'You must logout of the OMR, and login to the OMR again using the \'Login with GitHub\' link.',
                ]);
            }
        } else {
            //tag the commit with the version
            Git::tagDir($project, $this->release->tag_name, $this->disk);
        }
        //todo: run the GenerateDocs job
        //notify the user that it's done
        $this->release->User->notify(new ReleaseWasPublished($this->release));

The property User does not seem to exist on App\Models\Release. Are you sure there is no database migration missing?

    }
}